]> git.cameronkatri.com Git - pw-darwin.git/blobdiff - pw/pw_user.c
Let the afterinstall target ignore failures from running chflags. This
[pw-darwin.git] / pw / pw_user.c
index f7a6c5689618391b499807f5969bfd95edc65d0e..c8364cad51f4298df03c28c651b04dc65b7afe93 100644 (file)
@@ -41,19 +41,11 @@ static const char rcsid[] =
 #include <sys/time.h>
 #include <sys/resource.h>
 #include <unistd.h>
-#include <utmp.h>
 #include <login_cap.h>
-#if defined(USE_MD5RAND)
-#include <md5.h>
-#endif
 #include "pw.h"
 #include "bitmap.h"
 
-#if (MAXLOGNAME-1) > UT_NAMESIZE
-#define LOGNAMESIZE UT_NAMESIZE
-#else
 #define LOGNAMESIZE (MAXLOGNAME-1)
-#endif
 
 static         char locked_str[] = "*LOCKED*";
 
@@ -115,6 +107,9 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        struct stat     st;
        char            line[_PASSWORD_LEN+1];
        FILE           *fp;
+       mode_t dmode;
+       char *dmode_c;
+       void *set = NULL;
 
        static struct passwd fakeuser =
        {
@@ -156,6 +151,16 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                cnf->home = arg->val;
        }
 
+       if ((arg = getarg(args, 'M')) != NULL) {
+               dmode_c = arg->val;
+               if ((set = setmode(dmode_c)) == NULL)
+                       errx(EX_DATAERR, "invalid directory creation mode '%s'",
+                           dmode_c);
+               dmode = getmode(set, S_IRWXU | S_IRWXG | S_IRWXO);
+               free(set);
+               cnf->homemode = dmode;
+       }
+
        /*
         * If we'll need to use it or we're updating it,
         * then create the base home directory if necessary
@@ -181,19 +186,23 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        if (strchr(cnf->home+1, '/') == NULL) {
                                strcpy(dbuf, "/usr");
                                strncat(dbuf, cnf->home, MAXPATHLEN-5);
-                               if (mkdir(dbuf, 0755) != -1 || errno == EEXIST) {
+                               if (mkdir(dbuf, cnf->homemode) != -1 || errno == EEXIST) {
                                        chown(dbuf, 0, 0);
-                                       symlink(dbuf, cnf->home);
+                                       /*
+                                        * Skip first "/" and create symlink:
+                                        * /home -> usr/home
+                                        */
+                                       symlink(dbuf+1, cnf->home);
                                }
                                /* If this falls, fall back to old method */
                        }
-                       p = strncpy(dbuf, cnf->home, sizeof dbuf);
-                       dbuf[MAXPATHLEN-1] = '\0';
+                       strlcpy(dbuf, cnf->home, sizeof(dbuf));
+                       p = dbuf;
                        if (stat(dbuf, &st) == -1) {
                                while ((p = strchr(++p, '/')) != NULL) {
                                        *p = '\0';
                                        if (stat(dbuf, &st) == -1) {
-                                               if (mkdir(dbuf, 0755) == -1)
+                                               if (mkdir(dbuf, cnf->homemode) == -1)
                                                        goto direrr;
                                                chown(dbuf, 0, 0);
                                        } else if (!S_ISDIR(st.st_mode))
@@ -202,7 +211,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                }
                        }
                        if (stat(dbuf, &st) == -1) {
-                               if (mkdir(dbuf, 0755) == -1) {
+                               if (mkdir(dbuf, cnf->homemode) == -1) {
                                direrr: err(EX_OSFILE, "mkdir '%s'", dbuf);
                                }
                                chown(dbuf, 0, 0);
@@ -396,8 +405,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                         * invalidated by deletion
                         */
                        sprintf(file, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
-                       strncpy(home, pwd->pw_dir, sizeof home);
-                       home[sizeof home - 1] = '\0';
+                       strlcpy(home, pwd->pw_dir, sizeof(home));
 
                        rc = delpwent(pwd);
                        if (rc == -1)
@@ -648,7 +656,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                return EX_IOERR;
                        }
                        line[b] = '\0';
-                       if ((p = strpbrk(line, " \t\r\n")) != NULL)
+                       if ((p = strpbrk(line, "\r\n")) != NULL)
                                *p = '\0';
                        if (!*line)
                                errx(EX_DATAERR, "empty password read on file descriptor %d", fd);
@@ -760,7 +768,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * existing files will *not* be overwritten.
         */
        if (!PWALTDIR() && getarg(args, 'm') != NULL && pwd->pw_dir && *pwd->pw_dir == '/' && pwd->pw_dir[1]) {
-               copymkdir(pwd->pw_dir, cnf->dotdir, 0755, pwd->pw_uid, pwd->pw_gid);
+               copymkdir(pwd->pw_dir, cnf->dotdir, cnf->homemode, pwd->pw_uid, pwd->pw_gid);
                pw_log(cnf, mode, W_USER, "%s(%ld) home %s made",
                       pwd->pw_name, (long) pwd->pw_uid, pwd->pw_dir);
        }
@@ -978,8 +986,7 @@ shell_path(char const * path, char *shells[], char *sh)
                /*
                 * We need to search paths
                 */
-               strncpy(paths, path, sizeof paths);
-               paths[sizeof paths - 1] = '\0';
+               strlcpy(paths, path, sizeof(paths));
                for (p = strtok(paths, ": \t\r\n"); p != NULL; p = strtok(NULL, ": \t\r\n")) {
                        int             i;
                        static char     shellpath[256];
@@ -1014,88 +1021,40 @@ pw_shellpolicy(struct userconf * cnf, struct cargs * args, char *newshell)
        return shell_path(cnf->shelldir, cnf->shells, sh ? sh : cnf->shell_default);
 }
 
-static char const chars[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ.";
+#define        SALTSIZE        32
+
+static char const chars[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ./";
 
 char           *
 pw_pwcrypt(char *password)
 {
        int             i;
-       char            salt[12];
+       char            salt[SALTSIZE + 1];
 
        static char     buf[256];
 
        /*
         * Calculate a salt value
         */
-       for (i = 0; i < 8; i++)
-               salt[i] = chars[arc4random() % 63];
-       salt[i] = '\0';
+       for (i = 0; i < SALTSIZE; i++)
+               salt[i] = chars[arc4random_uniform(sizeof(chars) - 1)];
+       salt[SALTSIZE] = '\0';
 
        return strcpy(buf, crypt(password, salt));
 }
 
-#if defined(USE_MD5RAND)
-u_char *
-pw_getrand(u_char *buf, int len)       /* cryptographically secure rng */
-{
-       int i;
-       for (i=0;i<len;i+=16) {
-               u_char ubuf[16];
-
-               MD5_CTX md5_ctx;
-               struct timeval tv, tvo;
-               struct rusage ru;
-               int n=0;
-               int t;
-
-               MD5Init (&md5_ctx);
-               t=getpid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               t=getppid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               gettimeofday (&tvo, NULL);
-               do {
-                       getrusage (RUSAGE_SELF, &ru);
-                       MD5Update (&md5_ctx, (u_char*)&ru, sizeof ru);
-                       gettimeofday (&tv, NULL);
-                       MD5Update (&md5_ctx, (u_char*)&tv, sizeof tv);
-               } while (n++<20 || tv.tv_usec-tvo.tv_usec<100*1000);
-               MD5Final (ubuf, &md5_ctx);
-               memcpy(buf+i, ubuf, MIN(16, len-i));
-       }
-       return buf;
-}
-
-#else  /* Portable version */
-
-static u_char *
-pw_getrand(u_char *buf, int len)
-{
-       int i;
-
-       for (i = 0; i < len; i++) {
-               unsigned long val = arc4random();
-               /* Use all bits in the random value */
-               buf[i]=(u_char)((val >> 24) ^ (val >> 16) ^ (val >> 8) ^ val);
-       }
-       return buf;
-}
-
-#endif
 
 static char    *
 pw_password(struct userconf * cnf, struct cargs * args, char const * user)
 {
        int             i, l;
        char            pwbuf[32];
-       u_char          rndbuf[sizeof pwbuf];
 
        switch (cnf->default_password) {
        case -1:                /* Random password */
                l = (arc4random() % 8 + 8);     /* 8 - 16 chars */
-               pw_getrand(rndbuf, l);
                for (i = 0; i < l; i++)
-                       pwbuf[i] = chars[rndbuf[i] % (sizeof(chars)-1)];
+                       pwbuf[i] = chars[arc4random_uniform(sizeof(chars)-1)];
                pwbuf[i] = '\0';
 
                /*
@@ -1118,8 +1077,7 @@ pw_password(struct userconf * cnf, struct cargs * args, char const * user)
                return "*";
 
        case 1:         /* user's name */
-               strncpy(pwbuf, user, sizeof pwbuf);
-               pwbuf[sizeof pwbuf - 1] = '\0';
+               strlcpy(pwbuf, user, sizeof(pwbuf));
                break;
        }
        return pw_pwcrypt(pwbuf);
@@ -1144,17 +1102,14 @@ print_user(struct passwd * pwd, int pretty, int v7)
                struct tm *    tptr;
 
                if ((p = strtok(pwd->pw_gecos, ",")) != NULL) {
-                       strncpy(uname, p, sizeof uname);
-                       uname[sizeof uname - 1] = '\0';
+                       strlcpy(uname, p, sizeof(uname));
                        if ((p = strtok(NULL, ",")) != NULL) {
-                               strncpy(office, p, sizeof office);
-                               office[sizeof office - 1] = '\0';
+                               strlcpy(office, p, sizeof(office));
                                if ((p = strtok(NULL, ",")) != NULL) {
-                                       strncpy(wphone, p, sizeof wphone);
-                                       wphone[sizeof wphone - 1] = '\0';
+                                       strlcpy(wphone, p, sizeof(wphone));
                                        if ((p = strtok(NULL, "")) != NULL) {
-                                               strncpy(hphone, p, sizeof hphone);
-                                               hphone[sizeof hphone - 1] = '\0';
+                                               strlcpy(hphone, p,
+                                                   sizeof(hphone));
                                        }
                                }
                        }