Cast uid/git to uintmax_t when using printf-like functions so the size of

[pw-darwin.git] / pw / pwupd.c

diff --git a/pw/pwupd.c b/pw/pwupd.c
index e8defa3fb64ba3cca1b2834645dd42402ca0f5e1..f9e1959f44a7c3d9de10179bdc5505113e4889b7 100644 (file)
--- a/pw/pwupd.c
+++ b/pw/pwupd.c
@@ -33,7 +33,6 @@ static const char rcsid[] =
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#include <stdarg.h>
 #include <pwd.h>
 #include <libutil.h>
 #include <errno.h>
@@ -45,49 +44,29 @@ static const char rcsid[] =
 
 #include "pwupd.h"
 
-static char pathpwd[] = _PATH_PWD;
-static char * pwpath = pathpwd;
- 
-int
-setpwdir(const char * dir)
-{
-       if (dir == NULL)
-               return (-1);
-       else
-               pwpath = strdup(dir);
-       if (pwpath == NULL)
-               return (-1);
-
-       return (0);
-}
-
 char *
 getpwpath(char const * file)
 {
        static char pathbuf[MAXPATHLEN];
 
-       snprintf(pathbuf, sizeof pathbuf, "%s/%s", pwpath, file);
+       snprintf(pathbuf, sizeof pathbuf, "%s/%s", conf.etcpath, file);
 
        return (pathbuf);
 }
 
 static int
-pwdb(char *arg,...)
+pwdb_check(void)
 {
        int             i = 0;
        pid_t           pid;
-       va_list         ap;
        char           *args[10];
 
        args[i++] = _PATH_PWD_MKDB;
-       va_start(ap, arg);
-       while (i < 6 && arg != NULL) {
-               args[i++] = arg;
-               arg = va_arg(ap, char *);
-       }
-       if (pwpath != pathpwd) {
+       args[i++] = "-C";
+
+       if (strcmp(conf.etcpath, _PATH_PWD) != 0) {
                args[i++] = "-d";
-               args[i++] = pwpath;
+               args[i++] = conf.etcpath;
        }
        args[i++] = getpwpath(_MASTERPASSWD);
        args[i] = NULL;
@@ -102,7 +81,6 @@ pwdb(char *arg,...)
                if (WEXITSTATUS(i))
                        i = EIO;
        }
-       va_end(ap);
 
        return (i);
 }
@@ -110,45 +88,43 @@ pwdb(char *arg,...)
 static int
 pw_update(struct passwd * pwd, char const * user)
 {
-       int             rc = 0;
-
-       rc = pwdb("-C", (char *)NULL);  /* Check only */
-       if (rc == 0) {
-               int pfd, tfd;
-               struct passwd *pw = NULL;
-               struct passwd *old_pw = NULL;
-
-               if (pwd != NULL)
-                       pw = pw_dup(pwd);
-
-               if (user != NULL)
-                       old_pw = GETPWNAM(user);
-
-               if (pw_init(pwpath, NULL))
-                       err(1, "pw_init()");
-               if ((pfd = pw_lock()) == -1) {
-                       pw_fini();
-                       err(1, "pw_lock()");
-               }
-               if ((tfd = pw_tmp(-1)) == -1) {
-                       pw_fini();
-                       err(1, "pw_tmp()");
-               }
-               if (pw_copy(pfd, tfd, pw, old_pw) == -1) {
-                       pw_fini();
-                       err(1, "pw_copy()");
-               }
-               /*
-                * in case of deletion of a user, the whole database
-                * needs to be regenerated
-                */
-               if (pw_mkdb(pw != NULL ? pw->pw_name : NULL) == -1) {
-                       pw_fini();
-                       err(1, "pw_mkdb()");
-               }
-               free(pw);
+       struct passwd   *pw = NULL;
+       struct passwd   *old_pw = NULL;
+       int              rc, pfd, tfd;
+
+       if ((rc = pwdb_check()) != 0)
+               return (rc);
+
+       if (pwd != NULL)
+               pw = pw_dup(pwd);
+
+       if (user != NULL)
+               old_pw = GETPWNAM(user);
+
+       if (pw_init(conf.etcpath, NULL))
+               err(1, "pw_init()");
+       if ((pfd = pw_lock()) == -1) {
+               pw_fini();
+               err(1, "pw_lock()");
+       }
+       if ((tfd = pw_tmp(-1)) == -1) {
+               pw_fini();
+               err(1, "pw_tmp()");
+       }
+       if (pw_copy(pfd, tfd, pw, old_pw) == -1) {
+               pw_fini();
+               err(1, "pw_copy()");
+       }
+       /*
+        * in case of deletion of a user, the whole database
+        * needs to be regenerated
+        */
+       if (pw_mkdb(pw != NULL ? pw->pw_name : NULL) == -1) {
                pw_fini();
+               err(1, "pw_mkdb()");
        }
+       free(pw);
+       pw_fini();
 
        return (0);
 }
@@ -170,9 +146,6 @@ chgpwent(char const * login, struct passwd * pwd)
 int
 delpwent(struct passwd * pwd)
 {
-       char login[MAXLOGNAME];
-       
-       strlcpy(login, pwd->pw_name, MAXLOGNAME);
 
-       return (pw_update(NULL, login));
+       return (pw_update(NULL, pwd->pw_name));
 }