]> git.cameronkatri.com Git - pw-darwin.git/blobdiff - pw/pw_user.c
Let the afterinstall target ignore failures from running chflags. This
[pw-darwin.git] / pw / pw_user.c
index 395b69a836e59f40e760d85ebe7cd65fb7b43f9a..c8364cad51f4298df03c28c651b04dc65b7afe93 100644 (file)
@@ -41,20 +41,12 @@ static const char rcsid[] =
 #include <sys/time.h>
 #include <sys/resource.h>
 #include <unistd.h>
-#include <utmp.h>
-#if defined(USE_MD5RAND)
-#include <md5.h>
-#endif
+#include <login_cap.h>
 #include "pw.h"
 #include "bitmap.h"
 
-#if (MAXLOGNAME-1) > UT_NAMESIZE
-#define LOGNAMESIZE UT_NAMESIZE
-#else
 #define LOGNAMESIZE (MAXLOGNAME-1)
-#endif
 
-static          int randinit;
 static         char locked_str[] = "*LOCKED*";
 
 static int      print_user(struct passwd * pwd, int pretty, int v7);
@@ -67,7 +59,7 @@ static char    *pw_shellpolicy(struct userconf * cnf, struct cargs * args, char
 static char    *pw_password(struct userconf * cnf, struct cargs * args, char const * user);
 static char    *shell_path(char const * path, char *shells[], char *sh);
 static void     rmat(uid_t uid);
-static void    rmskey(char const * name);
+static void     rmopie(char const * name);
 
 /*-
  * -C config      configuration file
@@ -86,6 +78,7 @@ static void   rmskey(char const * name);
  * -L class       user class
  * -l name        new login name
  * -h fd          password filehandle
+ * -H fd          encrypted password filehandle
  * -F             force print or add
  *   Setting defaults:
  * -D             set user defaults
@@ -113,6 +106,10 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        struct group   *grp;
        struct stat     st;
        char            line[_PASSWORD_LEN+1];
+       FILE           *fp;
+       mode_t dmode;
+       char *dmode_c;
+       void *set = NULL;
 
        static struct passwd fakeuser =
        {
@@ -154,6 +151,16 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                cnf->home = arg->val;
        }
 
+       if ((arg = getarg(args, 'M')) != NULL) {
+               dmode_c = arg->val;
+               if ((set = setmode(dmode_c)) == NULL)
+                       errx(EX_DATAERR, "invalid directory creation mode '%s'",
+                           dmode_c);
+               dmode = getmode(set, S_IRWXU | S_IRWXG | S_IRWXO);
+               free(set);
+               cnf->homemode = dmode;
+       }
+
        /*
         * If we'll need to use it or we're updating it,
         * then create the base home directory if necessary
@@ -179,19 +186,23 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        if (strchr(cnf->home+1, '/') == NULL) {
                                strcpy(dbuf, "/usr");
                                strncat(dbuf, cnf->home, MAXPATHLEN-5);
-                               if (mkdir(dbuf, 0755) != -1 || errno == EEXIST) {
+                               if (mkdir(dbuf, cnf->homemode) != -1 || errno == EEXIST) {
                                        chown(dbuf, 0, 0);
-                                       symlink(dbuf, cnf->home);
+                                       /*
+                                        * Skip first "/" and create symlink:
+                                        * /home -> usr/home
+                                        */
+                                       symlink(dbuf+1, cnf->home);
                                }
                                /* If this falls, fall back to old method */
                        }
-                       p = strncpy(dbuf, cnf->home, sizeof dbuf);
-                       dbuf[MAXPATHLEN-1] = '\0';
+                       strlcpy(dbuf, cnf->home, sizeof(dbuf));
+                       p = dbuf;
                        if (stat(dbuf, &st) == -1) {
                                while ((p = strchr(++p, '/')) != NULL) {
                                        *p = '\0';
                                        if (stat(dbuf, &st) == -1) {
-                                               if (mkdir(dbuf, 0755) == -1)
+                                               if (mkdir(dbuf, cnf->homemode) == -1)
                                                        goto direrr;
                                                chown(dbuf, 0, 0);
                                        } else if (!S_ISDIR(st.st_mode))
@@ -200,7 +211,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                }
                        }
                        if (stat(dbuf, &st) == -1) {
-                               if (mkdir(dbuf, 0755) == -1) {
+                               if (mkdir(dbuf, cnf->homemode) == -1) {
                                direrr: err(EX_OSFILE, "mkdir '%s'", dbuf);
                                }
                                chown(dbuf, 0, 0);
@@ -219,12 +230,15 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                cnf->password_days = atoi(arg->val);
 
        if ((arg = getarg(args, 'g')) != NULL) {
-               p = arg->val;
-               if ((grp = GETGRNAM(p)) == NULL) {
-                       if (!isdigit(*p) || (grp = GETGRGID((gid_t) atoi(p))) == NULL)
-                               errx(EX_NOUSER, "group `%s' does not exist", p);
+               if (!*(p = arg->val))   /* Handle empty group list specially */
+                       cnf->default_group = "";
+               else {
+                       if ((grp = GETGRNAM(p)) == NULL) {
+                               if (!isdigit((unsigned char)*p) || (grp = GETGRGID((gid_t) atoi(p))) == NULL)
+                                       errx(EX_NOUSER, "group `%s' does not exist", p);
+                       }
+                       cnf->default_group = newstr(grp->gr_name);
                }
-               cnf->default_group = newstr(grp->gr_name);
        }
        if ((arg = getarg(args, 'L')) != NULL)
                cnf->default_class = pw_checkname((u_char *)arg->val, 0);
@@ -234,7 +248,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
 
                for (p = strtok(arg->val, ", \t"); p != NULL; p = strtok(NULL, ", \t")) {
                        if ((grp = GETGRNAM(p)) == NULL) {
-                               if (!isdigit(*p) || (grp = GETGRGID((gid_t) atoi(p))) == NULL)
+                               if (!isdigit((unsigned char)*p) || (grp = GETGRGID((gid_t) atoi(p))) == NULL)
                                        errx(EX_NOUSER, "group `%s' does not exist", p);
                        }
                        if (extendarray(&cnf->groups, &cnf->numgroups, i + 2) != -1)
@@ -252,6 +266,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        if ((arg = getarg(args, 's')) != NULL)
                cnf->shell_default = arg->val;
 
+       if ((arg = getarg(args, 'w')) != NULL)
+               cnf->default_password = boolean_val(arg->val, cnf->default_password);
        if (mode == M_ADD && getarg(args, 'D')) {
                if (getarg(args, 'n') != NULL)
                        errx(EX_DATAERR, "can't combine `-D' with `-n name'");
@@ -267,8 +283,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        if ((p = strtok(NULL, " ,\t")) == NULL || (cnf->max_gid = (gid_t) atoi(p)) < cnf->min_gid)
                                cnf->max_gid = 32000;
                }
-               if ((arg = getarg(args, 'w')) != NULL)
-                       cnf->default_password = boolean_val(arg->val, cnf->default_password);
 
                arg = getarg(args, 'C');
                if (write_userconfig(arg ? arg->val : NULL))
@@ -372,10 +386,10 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
 
                        if (!PWALTDIR()) {
                                /*
-                                * Remove skey record from /etc/skeykeys
+                                * Remove opie record from /etc/opiekeys
                                 */
 
-                               rmskey(pwd->pw_name);
+                               rmopie(pwd->pw_name);
 
                                /*
                                 * Remove crontabs
@@ -391,8 +405,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                         * invalidated by deletion
                         */
                        sprintf(file, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
-                       strncpy(home, pwd->pw_dir, sizeof home);
-                       home[sizeof home - 1] = '\0';
+                       strlcpy(home, pwd->pw_dir, sizeof(home));
 
                        rc = delpwent(pwd);
                        if (rc == -1)
@@ -455,7 +468,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        edited = 1;
                }
 
-               if ((arg = getarg(args, 'u')) != NULL && isdigit(*arg->val)) {
+               if ((arg = getarg(args, 'u')) != NULL && isdigit((unsigned char)*arg->val)) {
                        pwd->pw_uid = (uid_t) atol(arg->val);
                        edited = 1;
                        if (pwd->pw_uid != 0 && strcmp(pwd->pw_name, "root") == 0)
@@ -468,7 +481,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        gid_t newgid = (gid_t) GETGRNAM(cnf->default_group)->gr_gid;
                        if (newgid != pwd->pw_gid) {
                                edited = 1;
-                               pwd->pw_gid = pwd->pw_gid;
+                               pwd->pw_gid = newgid;
                        }
                }
 
@@ -532,6 +545,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                }
 
                if ((arg  = getarg(args, 'd')) != NULL) {
+                       if (strcmp(pwd->pw_dir, arg->val))
+                               edited = 1;
                        if (stat(pwd->pw_dir = arg->val, &st) == -1) {
                                if (getarg(args, 'm') == NULL && strcmp(pwd->pw_dir, "/nonexistent") != 0)
                                  warnx("WARNING: home `%s' does not exist", pwd->pw_dir);
@@ -539,12 +554,21 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                warnx("WARNING: home `%s' is not a directory", pwd->pw_dir);
                }
 
-               if ((arg = getarg(args, 'w')) != NULL && getarg(args, 'h') == NULL) {
+               if ((arg = getarg(args, 'w')) != NULL &&
+                   getarg(args, 'h') == NULL && getarg(args, 'H') == NULL) {
+                       login_cap_t *lc;
+
+                       lc = login_getpwclass(pwd);
+                       if (lc == NULL ||
+                           login_setcryptfmt(lc, "md5", NULL) == NULL)
+                               warn("setting crypt(3) format");
+                       login_close(lc);
                        pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
                        edited = 1;
                }
 
        } else {
+               login_cap_t *lc;
 
                /*
                 * Add code
@@ -561,13 +585,17 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                pwd = &fakeuser;
                pwd->pw_name = a_name->val;
                pwd->pw_class = cnf->default_class ? cnf->default_class : "";
-               pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
                pwd->pw_uid = pw_uidpolicy(cnf, args);
                pwd->pw_gid = pw_gidpolicy(cnf, args, pwd->pw_name, (gid_t) pwd->pw_uid);
                pwd->pw_change = pw_pwdpolicy(cnf, args);
                pwd->pw_expire = pw_exppolicy(cnf, args);
                pwd->pw_dir = pw_homepolicy(cnf, args, pwd->pw_name);
                pwd->pw_shell = pw_shellpolicy(cnf, args, NULL);
+               lc = login_getpwclass(pwd);
+               if (lc == NULL || login_setcryptfmt(lc, "md5", NULL) == NULL)
+                       warn("setting crypt(3) format");
+               login_close(lc);
+               pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
                edited = 1;
 
                if (pwd->pw_uid == 0 && strcmp(pwd->pw_name, "root") != 0)
@@ -585,14 +613,20 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                }
        }
 
-       if ((arg = getarg(args, 'h')) != NULL) {
-               if (strcmp(arg->val, "-") == 0)
-                       pwd->pw_passwd = "*";   /* No access */
-               else {
+       if ((arg = getarg(args, 'h')) != NULL ||
+           (arg = getarg(args, 'H')) != NULL) {
+               if (strcmp(arg->val, "-") == 0) {
+                       if (!pwd->pw_passwd || *pwd->pw_passwd != '*') {
+                               pwd->pw_passwd = "*";   /* No access */
+                               edited = 1;
+                       }
+               } else {
                        int             fd = atoi(arg->val);
+                       int             precrypt = (arg->ch == 'H');
                        int             b;
                        int             istty = isatty(fd);
                        struct termios  t;
+                       login_cap_t     *lc;
 
                        if (istty) {
                                if (tcgetattr(fd, &t) == -1)
@@ -603,7 +637,10 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                        /* Disable echo */
                                        n.c_lflag &= ~(ECHO);
                                        tcsetattr(fd, TCSANOW, &n);
-                                       printf("%sassword for user %s:", (mode == M_UPDATE) ? "New p" : "P", pwd->pw_name);
+                                       printf("%s%spassword for user %s:",
+                                            (mode == M_UPDATE) ? "new " : "",
+                                            precrypt ? "encrypted " : "",
+                                            pwd->pw_name);
                                        fflush(stdout);
                                }
                        }
@@ -614,15 +651,27 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                fflush(stdout);
                        }
                        if (b < 0) {
-                               warn("-h file descriptor");
+                               warn("-%c file descriptor", precrypt ? 'H' :
+                                   'h');
                                return EX_IOERR;
                        }
                        line[b] = '\0';
-                       if ((p = strpbrk(line, " \t\r\n")) != NULL)
+                       if ((p = strpbrk(line, "\r\n")) != NULL)
                                *p = '\0';
                        if (!*line)
                                errx(EX_DATAERR, "empty password read on file descriptor %d", fd);
-                       pwd->pw_passwd = pw_pwcrypt(line);
+                       if (precrypt) {
+                               if (strchr(line, ':') != NULL)
+                                       return EX_DATAERR;
+                               pwd->pw_passwd = line;
+                       } else {
+                               lc = login_getpwclass(pwd);
+                               if (lc == NULL ||
+                                   login_setcryptfmt(lc, "md5", NULL) == NULL)
+                                       warn("setting crypt(3) format");
+                               login_close(lc);
+                               pwd->pw_passwd = pw_pwcrypt(line);
+                       }
                        edited = 1;
                }
        }
@@ -681,12 +730,20 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        if (mode == M_ADD || getarg(args, 'G') != NULL)
                editgroups(pwd->pw_name, cnf->groups);
 
-       /* pwd may have been invalidated */
-       if ((pwd = GETPWNAM(a_name->val)) == NULL)
+       /* go get a current version of pwd */
+       pwd = GETPWNAM(a_name->val);
+       if (pwd == NULL) {
+               /* This will fail when we rename, so special case that */
+               if (mode == M_UPDATE && (arg = getarg(args, 'l')) != NULL) {
+                       a_name->val = arg->val;         /* update new name */
+                       pwd = GETPWNAM(a_name->val);    /* refetch renamed rec */
+               }
+       }
+       if (pwd == NULL)        /* can't go on without this */
                errx(EX_NOUSER, "user '%s' disappeared during update", a_name->val);
 
        grp = GETGRGID(pwd->pw_gid);
-       pw_log(cnf, mode, W_USER, "%s(%ld):%s(%d):%s:%s:%s",
+       pw_log(cnf, mode, W_USER, "%s(%ld):%s(%ld):%s:%s:%s",
               pwd->pw_name, (long) pwd->pw_uid,
            grp ? grp->gr_name : "unknown", (long) (grp ? grp->gr_gid : -1),
               pwd->pw_gecos, pwd->pw_dir, pwd->pw_shell);
@@ -697,48 +754,47 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * doesn't hurt anything to create the empty mailfile
         */
        if (mode == M_ADD) {
-               FILE           *fp;
-
                if (!PWALTDIR()) {
                        sprintf(line, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
                        close(open(line, O_RDWR | O_CREAT, 0600));      /* Preserve contents &
                                                                         * mtime */
                        chown(line, pwd->pw_uid, pwd->pw_gid);
-
-                       /*
-                        * Send mail to the new user as well, if we are asked to
-                        */
-                       if (cnf->newmail && *cnf->newmail && (fp = fopen(cnf->newmail, "r")) != NULL) {
-                               FILE           *pfp = popen(_PATH_SENDMAIL " -t", "w");
-
-                               if (pfp == NULL)
-                                       warn("sendmail");
-                               else {
-                                       fprintf(pfp, "From: root\n" "To: %s\n" "Subject: Welcome!\n\n", pwd->pw_name);
-                                       while (fgets(line, sizeof(line), fp) != NULL) {
-                                               /* Do substitutions? */
-                                               fputs(line, pfp);
-                                       }
-                                       pclose(pfp);
-                                       pw_log(cnf, mode, W_USER, "%s(%ld) new user mail sent",
-                                              pwd->pw_name, (long) pwd->pw_uid);
-                               }
-                               fclose(fp);
-                       }
                }
        }
 
        /*
-        * Finally, let's create and populate the user's home directory. Note
+        * Let's create and populate the user's home directory. Note
         * that this also `works' for editing users if -m is used, but
         * existing files will *not* be overwritten.
         */
        if (!PWALTDIR() && getarg(args, 'm') != NULL && pwd->pw_dir && *pwd->pw_dir == '/' && pwd->pw_dir[1]) {
-               copymkdir(pwd->pw_dir, cnf->dotdir, 0755, pwd->pw_uid, pwd->pw_gid);
+               copymkdir(pwd->pw_dir, cnf->dotdir, cnf->homemode, pwd->pw_uid, pwd->pw_gid);
                pw_log(cnf, mode, W_USER, "%s(%ld) home %s made",
                       pwd->pw_name, (long) pwd->pw_uid, pwd->pw_dir);
        }
 
+
+       /*
+        * Finally, send mail to the new user as well, if we are asked to
+        */
+       if (mode == M_ADD && !PWALTDIR() && cnf->newmail && *cnf->newmail && (fp = fopen(cnf->newmail, "r")) != NULL) {
+               FILE           *pfp = popen(_PATH_SENDMAIL " -t", "w");
+               
+               if (pfp == NULL)
+                       warn("sendmail");
+               else {
+                       fprintf(pfp, "From: root\n" "To: %s\n" "Subject: Welcome!\n\n", pwd->pw_name);
+                       while (fgets(line, sizeof(line), fp) != NULL) {
+                               /* Do substitutions? */
+                               fputs(line, pfp);
+                       }
+                       pclose(pfp);
+                       pw_log(cnf, mode, W_USER, "%s(%ld) new user mail sent",
+                           pwd->pw_name, (long) pwd->pw_uid);
+               }
+               fclose(fp);
+       }
+
        return EXIT_SUCCESS;
 }
 
@@ -819,7 +875,7 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
        if (a_gid != NULL) {
                if ((grp = GETGRNAM(a_gid->val)) == NULL) {
                        gid = (gid_t) atol(a_gid->val);
-                       if ((gid == 0 && !isdigit(*a_gid->val)) || (grp = GETGRGID(gid)) == NULL)
+                       if ((gid == 0 && !isdigit((unsigned char)*a_gid->val)) || (grp = GETGRGID(gid)) == NULL)
                                errx(EX_NOUSER, "group `%s' is not defined", a_gid->val);
                }
                gid = grp->gr_gid;
@@ -857,9 +913,9 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                        if ((grp = GETGRNAM(nam)) != NULL)
                                gid = grp->gr_gid;
                }
-               a_gid = grpargs.lh_first;
+               a_gid = LIST_FIRST(&grpargs);
                while (a_gid != NULL) {
-                       struct carg    *t = a_gid->list.le_next;
+                       struct carg    *t = LIST_NEXT(a_gid, list);
                        LIST_REMOVE(a_gid, list);
                        a_gid = t;
                }
@@ -930,8 +986,7 @@ shell_path(char const * path, char *shells[], char *sh)
                /*
                 * We need to search paths
                 */
-               strncpy(paths, path, sizeof paths);
-               paths[sizeof paths - 1] = '\0';
+               strlcpy(paths, path, sizeof(paths));
                for (p = strtok(paths, ": \t\r\n"); p != NULL; p = strtok(NULL, ": \t\r\n")) {
                        int             i;
                        static char     shellpath[256];
@@ -966,111 +1021,48 @@ pw_shellpolicy(struct userconf * cnf, struct cargs * args, char *newshell)
        return shell_path(cnf->shelldir, cnf->shells, sh ? sh : cnf->shell_default);
 }
 
-static char const chars[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ.";
+#define        SALTSIZE        32
+
+static char const chars[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ./";
 
 char           *
 pw_pwcrypt(char *password)
 {
        int             i;
-       char            salt[12];
+       char            salt[SALTSIZE + 1];
 
        static char     buf[256];
 
        /*
         * Calculate a salt value
         */
-       if (!randinit) {
-               randinit = 1;
-#ifdef __FreeBSD__
-               srandomdev();
-#else
-               srandom((unsigned long) (time(NULL) ^ getpid()));
-#endif
-       }
-       for (i = 0; i < 8; i++)
-               salt[i] = chars[random() % 63];
-       salt[i] = '\0';
+       for (i = 0; i < SALTSIZE; i++)
+               salt[i] = chars[arc4random_uniform(sizeof(chars) - 1)];
+       salt[SALTSIZE] = '\0';
 
        return strcpy(buf, crypt(password, salt));
 }
 
-#if defined(USE_MD5RAND)
-u_char *
-pw_getrand(u_char *buf, int len)       /* cryptographically secure rng */
-{
-       int i;
-       for (i=0;i<len;i+=16) {
-               u_char ubuf[16];
-
-               MD5_CTX md5_ctx;
-               struct timeval tv, tvo;
-               struct rusage ru;
-               int n=0;
-               int t;
-
-               MD5Init (&md5_ctx);
-               t=getpid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               t=getppid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               gettimeofday (&tvo, NULL);
-               do {
-                       getrusage (RUSAGE_SELF, &ru);
-                       MD5Update (&md5_ctx, (u_char*)&ru, sizeof ru);
-                       gettimeofday (&tv, NULL);
-                       MD5Update (&md5_ctx, (u_char*)&tv, sizeof tv);
-               } while (n++<20 || tv.tv_usec-tvo.tv_usec<100*1000);
-               MD5Final (ubuf, &md5_ctx);
-               memcpy(buf+i, ubuf, MIN(16, len-n));
-       }
-       return buf;
-}
-
-#else  /* Portable version */
-
-static u_char *
-pw_getrand(u_char *buf, int len)
-{
-       int i;
-
-       for (i = 0; i < len; i++) {
-               unsigned long val = random();
-               /* Use all bits in the random value */
-               buf[i]=(u_char)((val >> 24) ^ (val >> 16) ^ (val >> 8) ^ val);
-       }
-       return buf;
-}
-
-#endif
 
 static char    *
 pw_password(struct userconf * cnf, struct cargs * args, char const * user)
 {
        int             i, l;
        char            pwbuf[32];
-       u_char          rndbuf[sizeof pwbuf];
 
        switch (cnf->default_password) {
        case -1:                /* Random password */
-               if (!randinit) {
-                       randinit = 1;
-#ifdef __FreeBSD__
-                       srandomdev();
-#else
-                       srandom((unsigned long) (time(NULL) ^ getpid()));
-#endif
-               }
-               l = (random() % 8 + 8); /* 8 - 16 chars */
-               pw_getrand(rndbuf, l);
+               l = (arc4random() % 8 + 8);     /* 8 - 16 chars */
                for (i = 0; i < l; i++)
-                       pwbuf[i] = chars[rndbuf[i] % (sizeof(chars)-1)];
+                       pwbuf[i] = chars[arc4random_uniform(sizeof(chars)-1)];
                pwbuf[i] = '\0';
 
                /*
                 * We give this information back to the user
                 */
-               if (getarg(args, 'h') == NULL && getarg(args, 'N') == NULL) {
-                       if (isatty(1))
+               if (getarg(args, 'h') == NULL && getarg(args, 'H') == NULL &&
+                   getarg(args, 'N') == NULL) {
+                       if (isatty(STDOUT_FILENO))
                                printf("Password for '%s' is: ", user);
                        printf("%s\n", pwbuf);
                        fflush(stdout);
@@ -1085,8 +1077,7 @@ pw_password(struct userconf * cnf, struct cargs * args, char const * user)
                return "*";
 
        case 1:         /* user's name */
-               strncpy(pwbuf, user, sizeof pwbuf);
-               pwbuf[sizeof pwbuf - 1] = '\0';
+               strlcpy(pwbuf, user, sizeof(pwbuf));
                break;
        }
        return pw_pwcrypt(pwbuf);
@@ -1111,17 +1102,14 @@ print_user(struct passwd * pwd, int pretty, int v7)
                struct tm *    tptr;
 
                if ((p = strtok(pwd->pw_gecos, ",")) != NULL) {
-                       strncpy(uname, p, sizeof uname);
-                       uname[sizeof uname - 1] = '\0';
+                       strlcpy(uname, p, sizeof(uname));
                        if ((p = strtok(NULL, ",")) != NULL) {
-                               strncpy(office, p, sizeof office);
-                               office[sizeof office - 1] = '\0';
+                               strlcpy(office, p, sizeof(office));
                                if ((p = strtok(NULL, ",")) != NULL) {
-                                       strncpy(wphone, p, sizeof wphone);
-                                       wphone[sizeof wphone - 1] = '\0';
+                                       strlcpy(wphone, p, sizeof(wphone));
                                        if ((p = strtok(NULL, "")) != NULL) {
-                                               strncpy(hphone, p, sizeof hphone);
-                                               hphone[sizeof hphone - 1] = '\0';
+                                               strlcpy(hphone, p,
+                                                   sizeof(hphone));
                                        }
                                }
                        }
@@ -1135,12 +1123,12 @@ print_user(struct passwd * pwd, int pretty, int v7)
 
                        memmove(p + l, p + 1, m);
                        memmove(p, pwd->pw_name, l);
-                       *p = (char) toupper(*p);
+                       *p = (char) toupper((unsigned char)*p);
                }
                if (pwd->pw_expire > (time_t)0 && (tptr = localtime(&pwd->pw_expire)) != NULL)
-                 strftime(acexpire, sizeof acexpire, "%e-%b-%Y %T", tptr);
-               if (pwd->pw_change > (time_t)9 && (tptr = localtime(&pwd->pw_change)) != NULL)
-                 strftime(pwexpire, sizeof pwexpire, "%e-%b-%Y %T", tptr);
+                       strftime(acexpire, sizeof acexpire, "%c", tptr);
+               if (pwd->pw_change > (time_t)0 && (tptr = localtime(&pwd->pw_change)) != NULL)
+                       strftime(pwexpire, sizeof pwexpire, "%c", tptr);
                printf("Login Name: %-15s   #%-12ld Group: %-15s   #%ld\n"
                       " Full Name: %s\n"
                       "      Home: %-26.26s      Class: %s\n"
@@ -1168,7 +1156,7 @@ print_user(struct passwd * pwd, int pretty, int v7)
                        }
                }
                ENDGRENT();
-               printf("%s\n", j ? "\n" : "");
+               printf("%s", j ? "\n" : "");
        }
        return EXIT_SUCCESS;
 }
@@ -1176,21 +1164,58 @@ print_user(struct passwd * pwd, int pretty, int v7)
 char    *
 pw_checkname(u_char *name, int gecos)
 {
-       int             l = 0;
-       char const     *notch = gecos ? ":!@" : " ,\t:+&#%$^()!@~*?<>=|\\/\"";
-
-       while (name[l]) {
-               if (strchr(notch, name[l]) != NULL || name[l] < ' ' || name[l] == 127 ||
-                       (!gecos && l==0 && name[l] == '-') ||   /* leading '-' */
-                       (!gecos && name[l] & 0x80))     /* 8-bit */
-                       errx(EX_DATAERR, (name[l] >= ' ' && name[l] < 127)
-                                           ? "invalid character `%c' in field"
-                                           : "invalid character 0x%02x in field",
-                                           name[l]);
-               ++l;
+       char showch[8];
+       u_char const *badchars, *ch, *showtype;
+       int reject;
+
+       ch = name;
+       reject = 0;
+       if (gecos) {
+               /* See if the name is valid as a gecos (comment) field. */
+               badchars = ":!@";
+               showtype = "gecos field";
+       } else {
+               /* See if the name is valid as a userid or group. */
+               badchars = " ,\t:+&#%$^()!@~*?<>=|\\/\"";
+               showtype = "userid/group name";
+               /* Userids and groups can not have a leading '-'. */
+               if (*ch == '-')
+                       reject = 1;
+       }
+       if (!reject) {
+               while (*ch) {
+                       if (strchr(badchars, *ch) != NULL || *ch < ' ' ||
+                           *ch == 127) {
+                               reject = 1;
+                               break;
+                       }
+                       /* 8-bit characters are only allowed in GECOS fields */
+                       if (!gecos && (*ch & 0x80)) {
+                               reject = 1;
+                               break;
+                       }
+                       ch++;
+               }
+       }
+       /*
+        * A `$' is allowed as the final character for userids and groups,
+        * mainly for the benefit of samba.
+        */
+       if (reject && !gecos) {
+               if (*ch == '$' && *(ch + 1) == '\0') {
+                       reject = 0;
+                       ch++;
+               }
+       }
+       if (reject) {
+               snprintf(showch, sizeof(showch), (*ch >= ' ' && *ch < 127)
+                   ? "`%c'" : "0x%02x", *ch);
+               errx(EX_DATAERR, "invalid character %s at position %d in %s",
+                   showch, (ch - name), showtype);
        }
-       if (!gecos && l > LOGNAMESIZE)
-               errx(EX_DATAERR, "name too long `%s'", name);
+       if (!gecos && (ch - name) > LOGNAMESIZE)
+               errx(EX_DATAERR, "name too long `%s' (max is %d)", name,
+                   LOGNAMESIZE);
        return (char *)name;
 }
 
@@ -1221,10 +1246,10 @@ rmat(uid_t uid)
 }
 
 static void
-rmskey(char const * name)
+rmopie(char const * name)
 {
-       static const char etcskey[] = "/etc/skeykeys";
-       FILE   *fp = fopen(etcskey, "r+");
+       static const char etcopie[] = "/etc/opiekeys";
+       FILE   *fp = fopen(etcopie, "r+");
 
        if (fp != NULL) {
                char    tmp[1024];