]> git.cameronkatri.com Git - pw-darwin.git/blobdiff - pw/pw_user.c
Refactor input validation
[pw-darwin.git] / pw / pw_user.c
index 9d00bfa0c354b9f99776fa9e88acf0c97547f50e..c9093bb9e73aea90a6e1d751f60b37e4aa31b98f 100644 (file)
@@ -40,26 +40,22 @@ static const char rcsid[] =
 #include <sys/types.h>
 #include <sys/time.h>
 #include <sys/resource.h>
-#include <unistd.h>
-#include <utmp.h>
 #include <login_cap.h>
-#if defined(USE_MD5RAND)
-#include <md5.h>
-#endif
+#include <pwd.h>
+#include <grp.h>
+#include <libutil.h>
 #include "pw.h"
 #include "bitmap.h"
 
-#if (MAXLOGNAME-1) > UT_NAMESIZE
-#define LOGNAMESIZE UT_NAMESIZE
-#else
 #define LOGNAMESIZE (MAXLOGNAME-1)
-#endif
 
 static         char locked_str[] = "*LOCKED*";
 
-static int      print_user(struct passwd * pwd, int pretty, int v7);
+static int     delete_user(struct userconf *cnf, struct passwd *pwd,
+                   char *name, int delete, int mode);
+static int     print_user(struct passwd * pwd);
 static uid_t    pw_uidpolicy(struct userconf * cnf, struct cargs * args);
-static uid_t    pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer);
+static uid_t    pw_gidpolicy(struct cargs * args, char *nam, gid_t prefer);
 static time_t   pw_pwdpolicy(struct userconf * cnf, struct cargs * args);
 static time_t   pw_exppolicy(struct userconf * cnf, struct cargs * args);
 static char    *pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user);
@@ -67,7 +63,28 @@ static char    *pw_shellpolicy(struct userconf * cnf, struct cargs * args, char
 static char    *pw_password(struct userconf * cnf, struct cargs * args, char const * user);
 static char    *shell_path(char const * path, char *shells[], char *sh);
 static void     rmat(uid_t uid);
-static void    rmskey(char const * name);
+static void     rmopie(char const * name);
+
+static void
+create_and_populate_homedir(int mode, struct passwd *pwd)
+{
+       char *homedir, *dotdir;
+       struct userconf *cnf = conf.userconf;
+
+       homedir = dotdir = NULL;
+
+       if (conf.rootdir[0] != '\0') {
+               asprintf(&homedir, "%s/%s", conf.rootdir, pwd->pw_dir);
+               if (homedir == NULL)
+                       errx(EX_OSERR, "out of memory");
+               asprintf(&dotdir, "%s/%s", conf.rootdir, cnf->dotdir);
+       }
+
+       copymkdir(homedir ? homedir : pwd->pw_dir, dotdir ? dotdir: cnf->dotdir,
+           cnf->homemode, pwd->pw_uid, pwd->pw_gid);
+       pw_log(cnf, mode, W_USER, "%s(%u) home %s made", pwd->pw_name,
+           pwd->pw_uid, pwd->pw_dir);
+}
 
 /*-
  * -C config      configuration file
@@ -86,6 +103,7 @@ static void  rmskey(char const * name);
  * -L class       user class
  * -l name        new login name
  * -h fd          password filehandle
+ * -H fd          encrypted password filehandle
  * -F             force print or add
  *   Setting defaults:
  * -D             set user defaults
@@ -101,18 +119,21 @@ static void       rmskey(char const * name);
  */
 
 int
-pw_user(struct userconf * cnf, int mode, struct cargs * args)
+pw_user(int mode, char *name, long id, struct cargs * args)
 {
        int             rc, edited = 0;
        char           *p = NULL;
        char                                     *passtmp;
-       struct carg    *a_name;
-       struct carg    *a_uid;
        struct carg    *arg;
        struct passwd  *pwd = NULL;
        struct group   *grp;
        struct stat     st;
+       struct userconf *cnf;
        char            line[_PASSWORD_LEN+1];
+       char            path[MAXPATHLEN];
+       FILE           *fp;
+       char *dmode_c;
+       void *set = NULL;
 
        static struct passwd fakeuser =
        {
@@ -131,6 +152,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
 #endif
        };
 
+       cnf = conf.userconf;
 
        /*
         * With M_NEXT, we only need to return the
@@ -141,8 +163,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                uid_t next = pw_uidpolicy(cnf, args);
                if (getarg(args, 'q'))
                        return next;
-               printf("%ld:", (long)next);
-               pw_group(cnf, mode, args);
+               printf("%u:", next);
+               pw_group(mode, name, -1, args);
                return EXIT_SUCCESS;
        }
 
@@ -154,6 +176,15 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                cnf->home = arg->val;
        }
 
+       if ((arg = getarg(args, 'M')) != NULL) {
+               dmode_c = arg->val;
+               if ((set = setmode(dmode_c)) == NULL)
+                       errx(EX_DATAERR, "invalid directory creation mode '%s'",
+                           dmode_c);
+               cnf->homemode = getmode(set, _DEF_DIRMODE);
+               free(set);
+       }
+
        /*
         * If we'll need to use it or we're updating it,
         * then create the base home directory if necessary
@@ -177,21 +208,24 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                         * But we create a symlink from cnf->home -> "/usr" -> cnf->home
                         */
                        if (strchr(cnf->home+1, '/') == NULL) {
-                               strcpy(dbuf, "/usr");
-                               strncat(dbuf, cnf->home, MAXPATHLEN-5);
-                               if (mkdir(dbuf, 0755) != -1 || errno == EEXIST) {
+                               snprintf(dbuf, MAXPATHLEN, "/usr%s", cnf->home);
+                               if (mkdir(dbuf, _DEF_DIRMODE) != -1 || errno == EEXIST) {
                                        chown(dbuf, 0, 0);
-                                       symlink(dbuf, cnf->home);
+                                       /*
+                                        * Skip first "/" and create symlink:
+                                        * /home -> usr/home
+                                        */
+                                       symlink(dbuf+1, cnf->home);
                                }
                                /* If this falls, fall back to old method */
                        }
-                       p = strncpy(dbuf, cnf->home, sizeof dbuf);
-                       dbuf[MAXPATHLEN-1] = '\0';
+                       strlcpy(dbuf, cnf->home, sizeof(dbuf));
+                       p = dbuf;
                        if (stat(dbuf, &st) == -1) {
-                               while ((p = strchr(++p, '/')) != NULL) {
+                               while ((p = strchr(p + 1, '/')) != NULL) {
                                        *p = '\0';
                                        if (stat(dbuf, &st) == -1) {
-                                               if (mkdir(dbuf, 0755) == -1)
+                                               if (mkdir(dbuf, _DEF_DIRMODE) == -1)
                                                        goto direrr;
                                                chown(dbuf, 0, 0);
                                        } else if (!S_ISDIR(st.st_mode))
@@ -200,7 +234,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                }
                        }
                        if (stat(dbuf, &st) == -1) {
-                               if (mkdir(dbuf, 0755) == -1) {
+                               if (mkdir(dbuf, _DEF_DIRMODE) == -1) {
                                direrr: err(EX_OSFILE, "mkdir '%s'", dbuf);
                                }
                                chown(dbuf, 0, 0);
@@ -230,7 +264,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                }
        }
        if ((arg = getarg(args, 'L')) != NULL)
-               cnf->default_class = pw_checkname((u_char *)arg->val, 0);
+               cnf->default_class = pw_checkname(arg->val, 0);
 
        if ((arg = getarg(args, 'G')) != NULL && arg->val) {
                int i = 0;
@@ -276,41 +310,22 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                arg = getarg(args, 'C');
                if (write_userconfig(arg ? arg->val : NULL))
                        return EXIT_SUCCESS;
-               warn("config update");
-               return EX_IOERR;
+               err(EX_IOERR, "config udpate");
        }
 
        if (mode == M_PRINT && getarg(args, 'a')) {
-               int             pretty = getarg(args, 'P') != NULL;
-               int             v7 = getarg(args, '7') != NULL;
-
                SETPWENT();
                while ((pwd = GETPWENT()) != NULL)
-                       print_user(pwd, pretty, v7);
+                       print_user(pwd);
                ENDPWENT();
                return EXIT_SUCCESS;
        }
 
-       if ((a_name = getarg(args, 'n')) != NULL)
-               pwd = GETPWNAM(pw_checkname((u_char *)a_name->val, 0));
-       a_uid = getarg(args, 'u');
+       if (name != NULL)
+               pwd = GETPWNAM(pw_checkname(name, 0));
 
-       if (a_uid == NULL) {
-               if (a_name == NULL)
-                       errx(EX_DATAERR, "user name or id required");
-
-               /*
-                * Determine whether 'n' switch is name or uid - we don't
-                * really don't really care which we have, but we need to
-                * know.
-                */
-               if (mode != M_ADD && pwd == NULL
-                   && strspn(a_name->val, "0123456789") == strlen(a_name->val)
-                   && atoi(a_name->val) > 0) { /* Assume uid */
-                       (a_uid = a_name)->ch = 'u';
-                       a_name = NULL;
-               }
-       }
+       if (id < 0 && name == NULL)
+               errx(EX_DATAERR, "user name or id required");
 
        /*
         * Update, delete & print require that the user exists
@@ -318,24 +333,22 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        if (mode == M_UPDATE || mode == M_DELETE ||
            mode == M_PRINT  || mode == M_LOCK   || mode == M_UNLOCK) {
 
-               if (a_name == NULL && pwd == NULL)      /* Try harder */
-                       pwd = GETPWUID(atoi(a_uid->val));
+               if (name == NULL && pwd == NULL)        /* Try harder */
+                       pwd = GETPWUID(id);
 
                if (pwd == NULL) {
                        if (mode == M_PRINT && getarg(args, 'F')) {
-                               fakeuser.pw_name = a_name ? a_name->val : "nouser";
-                               fakeuser.pw_uid = a_uid ? (uid_t) atol(a_uid->val) : -1;
-                               return print_user(&fakeuser,
-                                                 getarg(args, 'P') != NULL,
-                                                 getarg(args, '7') != NULL);
+                               fakeuser.pw_name = name ? name : "nouser";
+                               fakeuser.pw_uid = (uid_t) id;
+                               return print_user(&fakeuser);
                        }
-                       if (a_name == NULL)
-                               errx(EX_NOUSER, "no such uid `%s'", a_uid->val);
-                       errx(EX_NOUSER, "no such user `%s'", a_name->val);
+                       if (name == NULL)
+                               errx(EX_NOUSER, "no such uid `%ld'", id);
+                       errx(EX_NOUSER, "no such user `%s'", name);
                }
 
-               if (a_name == NULL)     /* May be needed later */
-                       a_name = addarg(args, 'n', newstr(pwd->pw_name));
+               if (name == NULL)
+                       name = pwd->pw_name;
 
                /*
                 * The M_LOCK and M_UNLOCK functions simply add or remove
@@ -350,11 +363,9 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                if (mode == M_LOCK) {
                        if (strncmp(pwd->pw_passwd, locked_str, sizeof(locked_str)-1) == 0)
                                errx(EX_DATAERR, "user '%s' is already locked", pwd->pw_name);
-                       passtmp = malloc(strlen(pwd->pw_passwd) + sizeof(locked_str));
+                       asprintf(&passtmp, "%s%s", locked_str, pwd->pw_passwd);
                        if (passtmp == NULL)    /* disaster */
                                errx(EX_UNAVAILABLE, "out of memory");
-                       strcpy(passtmp, locked_str);
-                       strcat(passtmp, pwd->pw_passwd);
                        pwd->pw_passwd = passtmp;
                        edited = 1;
                } else if (mode == M_UNLOCK) {
@@ -362,91 +373,11 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                errx(EX_DATAERR, "user '%s' is not locked", pwd->pw_name);
                        pwd->pw_passwd += sizeof(locked_str)-1;
                        edited = 1;
-               } else if (mode == M_DELETE) {
-                       /*
-                        * Handle deletions now
-                        */
-                       char            file[MAXPATHLEN];
-                       char            home[MAXPATHLEN];
-                       uid_t           uid = pwd->pw_uid;
-
-                       if (strcmp(pwd->pw_name, "root") == 0)
-                               errx(EX_DATAERR, "cannot remove user 'root'");
-
-                       if (!PWALTDIR()) {
-                               /*
-                                * Remove skey record from /etc/skeykeys
-                                */
-
-                               rmskey(pwd->pw_name);
-
-                               /*
-                                * Remove crontabs
-                                */
-                               sprintf(file, "/var/cron/tabs/%s", pwd->pw_name);
-                               if (access(file, F_OK) == 0) {
-                                       sprintf(file, "crontab -u %s -r", pwd->pw_name);
-                                       system(file);
-                               }
-                       }
-                       /*
-                        * Save these for later, since contents of pwd may be
-                        * invalidated by deletion
-                        */
-                       sprintf(file, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
-                       strncpy(home, pwd->pw_dir, sizeof home);
-                       home[sizeof home - 1] = '\0';
-
-                       rc = delpwent(pwd);
-                       if (rc == -1)
-                               err(EX_IOERR, "user '%s' does not exist", pwd->pw_name);
-                       else if (rc != 0) {
-                               warn("passwd update");
-                               return EX_IOERR;
-                       }
-
-                       if (cnf->nispasswd && *cnf->nispasswd=='/') {
-                               rc = delnispwent(cnf->nispasswd, a_name->val);
-                               if (rc == -1)
-                                       warnx("WARNING: user '%s' does not exist in NIS passwd", pwd->pw_name);
-                               else if (rc != 0)
-                                       warn("WARNING: NIS passwd update");
-                               /* non-fatal */
-                       }
-
-                       editgroups(a_name->val, NULL);
-
-                       pw_log(cnf, mode, W_USER, "%s(%ld) account removed", a_name->val, (long) uid);
-
-                       if (!PWALTDIR()) {
-                               /*
-                                * Remove mail file
-                                */
-                               remove(file);
-
-                               /*
-                                * Remove at jobs
-                                */
-                               if (getpwuid(uid) == NULL)
-                                       rmat(uid);
-
-                               /*
-                                * Remove home directory and contents
-                                */
-                               if (getarg(args, 'r') != NULL && *home == '/' && getpwuid(uid) == NULL) {
-                                       if (stat(home, &st) != -1) {
-                                               rm_r(home, uid);
-                                               pw_log(cnf, mode, W_USER, "%s(%ld) home '%s' %sremoved",
-                                                      a_name->val, (long) uid, home,
-                                                      stat(home, &st) == -1 ? "" : "not completely ");
-                                       }
-                               }
-                       }
-                       return EXIT_SUCCESS;
-               } else if (mode == M_PRINT)
-                       return print_user(pwd,
-                                         getarg(args, 'P') != NULL,
-                                         getarg(args, '7') != NULL);
+               } else if (mode == M_DELETE)
+                       return (delete_user(cnf, pwd, name,
+                                   getarg(args, 'r') != NULL, mode));
+               else if (mode == M_PRINT)
+                       return print_user(pwd);
 
                /*
                 * The rest is edit code
@@ -454,7 +385,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                if ((arg = getarg(args, 'l')) != NULL) {
                        if (strcmp(pwd->pw_name, "root") == 0)
                                errx(EX_DATAERR, "can't rename `root' account");
-                       pwd->pw_name = pw_checkname((u_char *)arg->val, 0);
+                       pwd->pw_name = pw_checkname(arg->val, 0);
                        edited = 1;
                }
 
@@ -486,8 +417,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
-                               if (now == expire)
-                                       errx(EX_DATAERR, "invalid password change date `%s'", arg->val);
                                if (pwd->pw_change != expire) {
                                        pwd->pw_change = expire;
                                        edited = 1;
@@ -506,8 +435,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
-                               if (now == expire)
-                                       errx(EX_DATAERR, "invalid account expiry date `%s'", arg->val);
                                if (pwd->pw_expire != expire) {
                                        pwd->pw_expire = expire;
                                        edited = 1;
@@ -535,7 +462,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                }
 
                if ((arg  = getarg(args, 'd')) != NULL) {
-                       edited = strcmp(pwd->pw_dir, arg->val) != 0;
+                       if (strcmp(pwd->pw_dir, arg->val))
+                               edited = 1;
                        if (stat(pwd->pw_dir = arg->val, &st) == -1) {
                                if (getarg(args, 'm') == NULL && strcmp(pwd->pw_dir, "/nonexistent") != 0)
                                  warnx("WARNING: home `%s' does not exist", pwd->pw_dir);
@@ -543,12 +471,13 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                warnx("WARNING: home `%s' is not a directory", pwd->pw_dir);
                }
 
-               if ((arg = getarg(args, 'w')) != NULL && getarg(args, 'h') == NULL) {
+               if ((arg = getarg(args, 'w')) != NULL &&
+                   getarg(args, 'h') == NULL && getarg(args, 'H') == NULL) {
                        login_cap_t *lc;
 
                        lc = login_getpwclass(pwd);
                        if (lc == NULL ||
-                           login_setcryptfmt(lc, "md5", NULL) == NULL)
+                           login_setcryptfmt(lc, "sha512", NULL) == NULL)
                                warn("setting crypt(3) format");
                        login_close(lc);
                        pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
@@ -562,25 +491,25 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                 * Add code
                 */
 
-               if (a_name == NULL)     /* Required */
+               if (name == NULL)       /* Required */
                        errx(EX_DATAERR, "login name required");
-               else if ((pwd = GETPWNAM(a_name->val)) != NULL) /* Exists */
-                       errx(EX_DATAERR, "login name `%s' already exists", a_name->val);
+               else if ((pwd = GETPWNAM(name)) != NULL)        /* Exists */
+                       errx(EX_DATAERR, "login name `%s' already exists", name);
 
                /*
                 * Now, set up defaults for a new user
                 */
                pwd = &fakeuser;
-               pwd->pw_name = a_name->val;
+               pwd->pw_name = name;
                pwd->pw_class = cnf->default_class ? cnf->default_class : "";
                pwd->pw_uid = pw_uidpolicy(cnf, args);
-               pwd->pw_gid = pw_gidpolicy(cnf, args, pwd->pw_name, (gid_t) pwd->pw_uid);
+               pwd->pw_gid = pw_gidpolicy(args, pwd->pw_name, (gid_t) pwd->pw_uid);
                pwd->pw_change = pw_pwdpolicy(cnf, args);
                pwd->pw_expire = pw_exppolicy(cnf, args);
                pwd->pw_dir = pw_homepolicy(cnf, args, pwd->pw_name);
                pwd->pw_shell = pw_shellpolicy(cnf, args, NULL);
                lc = login_getpwclass(pwd);
-               if (lc == NULL || login_setcryptfmt(lc, "md5", NULL) == NULL)
+               if (lc == NULL || login_setcryptfmt(lc, "sha512", NULL) == NULL)
                        warn("setting crypt(3) format");
                login_close(lc);
                pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
@@ -594,14 +523,15 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * Shared add/edit code
         */
        if ((arg = getarg(args, 'c')) != NULL) {
-               char    *gecos = pw_checkname((u_char *)arg->val, 1);
+               char    *gecos = pw_checkname(arg->val, 1);
                if (strcmp(pwd->pw_gecos, gecos) != 0) {
                        pwd->pw_gecos = gecos;
                        edited = 1;
                }
        }
 
-       if ((arg = getarg(args, 'h')) != NULL) {
+       if ((arg = getarg(args, 'h')) != NULL ||
+           (arg = getarg(args, 'H')) != NULL) {
                if (strcmp(arg->val, "-") == 0) {
                        if (!pwd->pw_passwd || *pwd->pw_passwd != '*') {
                                pwd->pw_passwd = "*";   /* No access */
@@ -609,6 +539,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        }
                } else {
                        int             fd = atoi(arg->val);
+                       int             precrypt = (arg->ch == 'H');
                        int             b;
                        int             istty = isatty(fd);
                        struct termios  t;
@@ -623,7 +554,10 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                        /* Disable echo */
                                        n.c_lflag &= ~(ECHO);
                                        tcsetattr(fd, TCSANOW, &n);
-                                       printf("%sassword for user %s:", (mode == M_UPDATE) ? "New p" : "P", pwd->pw_name);
+                                       printf("%s%spassword for user %s:",
+                                            (mode == M_UPDATE) ? "new " : "",
+                                            precrypt ? "encrypted " : "",
+                                            pwd->pw_name);
                                        fflush(stdout);
                                }
                        }
@@ -633,21 +567,26 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                fputc('\n', stdout);
                                fflush(stdout);
                        }
-                       if (b < 0) {
-                               warn("-h file descriptor");
-                               return EX_IOERR;
-                       }
+                       if (b < 0)
+                               err(EX_IOERR, "-%c file descriptor",
+                                   precrypt ? 'H' : 'h');
                        line[b] = '\0';
-                       if ((p = strpbrk(line, " \t\r\n")) != NULL)
+                       if ((p = strpbrk(line, "\r\n")) != NULL)
                                *p = '\0';
                        if (!*line)
                                errx(EX_DATAERR, "empty password read on file descriptor %d", fd);
-                       lc = login_getpwclass(pwd);
-                       if (lc == NULL ||
-                           login_setcryptfmt(lc, "md5", NULL) == NULL)
-                               warn("setting crypt(3) format");
-                       login_close(lc);
-                       pwd->pw_passwd = pw_pwcrypt(line);
+                       if (precrypt) {
+                               if (strchr(line, ':') != NULL)
+                                       return EX_DATAERR;
+                               pwd->pw_passwd = line;
+                       } else {
+                               lc = login_getpwclass(pwd);
+                               if (lc == NULL ||
+                                   login_setcryptfmt(lc, "sha512", NULL) == NULL)
+                                       warn("setting crypt(3) format");
+                               login_close(lc);
+                               pwd->pw_passwd = pw_pwcrypt(line);
+                       }
                        edited = 1;
                }
        }
@@ -655,21 +594,17 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        /*
         * Special case: -N only displays & exits
         */
-       if (getarg(args, 'N') != NULL)
-               return print_user(pwd,
-                                 getarg(args, 'P') != NULL,
-                                 getarg(args, '7') != NULL);
+       if (conf.dryrun)
+               return print_user(pwd);
 
        if (mode == M_ADD) {
                edited = 1;     /* Always */
                rc = addpwent(pwd);
-               if (rc == -1) {
-                       warnx("user '%s' already exists", pwd->pw_name);
-                       return EX_IOERR;
-               } else if (rc != 0) {
-                       warn("passwd file update");
-                       return EX_IOERR;
-               }
+               if (rc == -1)
+                       errx(EX_IOERR, "user '%s' already exists",
+                           pwd->pw_name);
+               else if (rc != 0)
+                       err(EX_IOERR, "passwd file update");
                if (cnf->nispasswd && *cnf->nispasswd=='/') {
                        rc = addnispwent(cnf->nispasswd, pwd);
                        if (rc == -1)
@@ -680,16 +615,13 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                }
        } else if (mode == M_UPDATE || mode == M_LOCK || mode == M_UNLOCK) {
                if (edited) {   /* Only updated this if required */
-                       rc = chgpwent(a_name->val, pwd);
-                       if (rc == -1) {
-                               warnx("user '%s' does not exist (NIS?)", pwd->pw_name);
-                               return EX_IOERR;
-                       } else if (rc != 0) {
-                               warn("passwd file update");
-                               return EX_IOERR;
-                       }
+                       rc = chgpwent(name, pwd);
+                       if (rc == -1)
+                               errx(EX_IOERR, "user '%s' does not exist (NIS?)", pwd->pw_name);
+                       else if (rc != 0)
+                               err(EX_IOERR, "passwd file update");
                        if ( cnf->nispasswd && *cnf->nispasswd=='/') {
-                               rc = chgnispwent(cnf->nispasswd, a_name->val, pwd);
+                               rc = chgnispwent(cnf->nispasswd, name, pwd);
                                if (rc == -1)
                                        warn("User '%s' not found in NIS passwd", pwd->pw_name);
                                else
@@ -703,25 +635,59 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * Ok, user is created or changed - now edit group file
         */
 
-       if (mode == M_ADD || getarg(args, 'G') != NULL)
-               editgroups(pwd->pw_name, cnf->groups);
+       if (mode == M_ADD || getarg(args, 'G') != NULL) {
+               int i, j;
+               /* First remove the user from all group */
+               SETGRENT();
+               while ((grp = GETGRENT()) != NULL) {
+                       char group[MAXLOGNAME];
+                       if (grp->gr_mem == NULL)
+                               continue;
+                       for (i = 0; grp->gr_mem[i] != NULL; i++) {
+                               if (strcmp(grp->gr_mem[i] , pwd->pw_name) != 0)
+                                       continue;
+                               for (j = i; grp->gr_mem[j] != NULL ; j++)
+                                       grp->gr_mem[j] = grp->gr_mem[j+1];
+                               strlcpy(group, grp->gr_name, MAXLOGNAME);
+                               chggrent(group, grp);
+                       }
+               }
+               ENDGRENT();
+
+               /* now add to group where needed */
+               for (i = 0; cnf->groups[i] != NULL; i++) {
+                       grp = GETGRNAM(cnf->groups[i]);
+                       grp = gr_add(grp, pwd->pw_name);
+                       /*
+                        * grp can only be NULL in 2 cases:
+                        * - the new member is already a member
+                        * - a problem with memory occurs
+                        * in both cases we want to skip now.
+                        */
+                       if (grp == NULL)
+                               continue;
+                       chggrent(cnf->groups[i], grp);
+                       free(grp);
+               }
+       }
+
 
        /* go get a current version of pwd */
-       pwd = GETPWNAM(a_name->val);
+       pwd = GETPWNAM(name);
        if (pwd == NULL) {
                /* This will fail when we rename, so special case that */
                if (mode == M_UPDATE && (arg = getarg(args, 'l')) != NULL) {
-                       a_name->val = arg->val;         /* update new name */
-                       pwd = GETPWNAM(a_name->val);    /* refetch renamed rec */
+                       name = arg->val;                /* update new name */
+                       pwd = GETPWNAM(name);   /* refetch renamed rec */
                }
        }
        if (pwd == NULL)        /* can't go on without this */
-               errx(EX_NOUSER, "user '%s' disappeared during update", a_name->val);
+               errx(EX_NOUSER, "user '%s' disappeared during update", name);
 
        grp = GETGRGID(pwd->pw_gid);
-       pw_log(cnf, mode, W_USER, "%s(%ld):%s(%d):%s:%s:%s",
-              pwd->pw_name, (long) pwd->pw_uid,
-           grp ? grp->gr_name : "unknown", (long) (grp ? grp->gr_gid : -1),
+       pw_log(cnf, mode, W_USER, "%s(%u):%s(%u):%s:%s:%s",
+              pwd->pw_name, pwd->pw_uid,
+           grp ? grp->gr_name : "unknown", (grp ? grp->gr_gid : (uid_t)-1),
               pwd->pw_gecos, pwd->pw_dir, pwd->pw_shell);
 
        /*
@@ -730,46 +696,44 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * doesn't hurt anything to create the empty mailfile
         */
        if (mode == M_ADD) {
-               FILE           *fp;
-
-               if (!PWALTDIR()) {
-                       sprintf(line, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
-                       close(open(line, O_RDWR | O_CREAT, 0600));      /* Preserve contents &
+               if (PWALTDIR() != PWF_ALT) {
+                       arg = getarg(args, 'R');
+                       snprintf(path, sizeof(path), "%s%s/%s",
+                           arg ? arg->val : "", _PATH_MAILDIR, pwd->pw_name);
+                       close(open(path, O_RDWR | O_CREAT, 0600));      /* Preserve contents &
                                                                         * mtime */
-                       chown(line, pwd->pw_uid, pwd->pw_gid);
-
-                       /*
-                        * Send mail to the new user as well, if we are asked to
-                        */
-                       if (cnf->newmail && *cnf->newmail && (fp = fopen(cnf->newmail, "r")) != NULL) {
-                               FILE           *pfp = popen(_PATH_SENDMAIL " -t", "w");
-
-                               if (pfp == NULL)
-                                       warn("sendmail");
-                               else {
-                                       fprintf(pfp, "From: root\n" "To: %s\n" "Subject: Welcome!\n\n", pwd->pw_name);
-                                       while (fgets(line, sizeof(line), fp) != NULL) {
-                                               /* Do substitutions? */
-                                               fputs(line, pfp);
-                                       }
-                                       pclose(pfp);
-                                       pw_log(cnf, mode, W_USER, "%s(%ld) new user mail sent",
-                                              pwd->pw_name, (long) pwd->pw_uid);
-                               }
-                               fclose(fp);
-                       }
+                       chown(path, pwd->pw_uid, pwd->pw_gid);
                }
        }
 
        /*
-        * Finally, let's create and populate the user's home directory. Note
+        * Let's create and populate the user's home directory. Note
         * that this also `works' for editing users if -m is used, but
         * existing files will *not* be overwritten.
         */
-       if (!PWALTDIR() && getarg(args, 'm') != NULL && pwd->pw_dir && *pwd->pw_dir == '/' && pwd->pw_dir[1]) {
-               copymkdir(pwd->pw_dir, cnf->dotdir, 0755, pwd->pw_uid, pwd->pw_gid);
-               pw_log(cnf, mode, W_USER, "%s(%ld) home %s made",
-                      pwd->pw_name, (long) pwd->pw_uid, pwd->pw_dir);
+       if (PWALTDIR() != PWF_ALT && getarg(args, 'm') != NULL && pwd->pw_dir &&
+           *pwd->pw_dir == '/' && pwd->pw_dir[1])
+               create_and_populate_homedir(mode, pwd);
+
+       /*
+        * Finally, send mail to the new user as well, if we are asked to
+        */
+       if (mode == M_ADD && !PWALTDIR() && cnf->newmail && *cnf->newmail && (fp = fopen(cnf->newmail, "r")) != NULL) {
+               FILE           *pfp = popen(_PATH_SENDMAIL " -t", "w");
+               
+               if (pfp == NULL)
+                       warn("sendmail");
+               else {
+                       fprintf(pfp, "From: root\n" "To: %s\n" "Subject: Welcome!\n\n", pwd->pw_name);
+                       while (fgets(line, sizeof(line), fp) != NULL) {
+                               /* Do substitutions? */
+                               fputs(line, pfp);
+                       }
+                       pclose(pfp);
+                       pw_log(cnf, mode, W_USER, "%s(%u) new user mail sent",
+                           pwd->pw_name, pwd->pw_uid);
+               }
+               fclose(fp);
        }
 
        return EXIT_SUCCESS;
@@ -790,7 +754,7 @@ pw_uidpolicy(struct userconf * cnf, struct cargs * args)
                uid = (uid_t) atol(a_uid->val);
 
                if ((pwd = GETPWUID(uid)) != NULL && getarg(args, 'o') == NULL)
-                       errx(EX_DATAERR, "uid `%ld' has already been allocated", (long) pwd->pw_uid);
+                       errx(EX_DATAERR, "uid `%u' has already been allocated", pwd->pw_uid);
        } else {
                struct bitmap   bm;
 
@@ -833,11 +797,12 @@ pw_uidpolicy(struct userconf * cnf, struct cargs * args)
 
 
 static          uid_t
-pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer)
+pw_gidpolicy(struct cargs * args, char *nam, gid_t prefer)
 {
        struct group   *grp;
        gid_t           gid = (uid_t) - 1;
        struct carg    *a_gid = getarg(args, 'g');
+       struct userconf *cnf = conf.userconf;
 
        /*
         * If no arg given, see if default can help out
@@ -856,14 +821,14 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                                errx(EX_NOUSER, "group `%s' is not defined", a_gid->val);
                }
                gid = grp->gr_gid;
-       } else if ((grp = GETGRNAM(nam)) != NULL && grp->gr_mem[0] == NULL) {
+       } else if ((grp = GETGRNAM(nam)) != NULL &&
+           (grp->gr_mem == NULL || grp->gr_mem[0] == NULL)) {
                gid = grp->gr_gid;  /* Already created? Use it anyway... */
        } else {
                struct cargs    grpargs;
                char            tmp[32];
 
                LIST_INIT(&grpargs);
-               addarg(&grpargs, 'n', nam);
 
                /*
                 * We need to auto-create a group with the user's name. We
@@ -875,18 +840,16 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                 * function will happily handle that case for us and exit.
                 */
                if (GETGRGID(prefer) == NULL) {
-                       sprintf(tmp, "%lu", (unsigned long) prefer);
+                       snprintf(tmp, sizeof(tmp), "%u", prefer);
                        addarg(&grpargs, 'g', tmp);
                }
-               if (getarg(args, 'N'))
-               {
-                       addarg(&grpargs, 'N', NULL);
+               if (conf.dryrun) {
                        addarg(&grpargs, 'q', NULL);
-                       gid = pw_group(cnf, M_NEXT, &grpargs);
+                       gid = pw_group(M_NEXT, nam, -1, &grpargs);
                }
                else
                {
-                       pw_group(cnf, M_ADD, &grpargs);
+                       pw_group(M_ADD, nam, -1, &grpargs);
                        if ((grp = GETGRNAM(nam)) != NULL)
                                gid = grp->gr_gid;
                }
@@ -938,17 +901,16 @@ static char    *
 pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user)
 {
        struct carg    *arg = getarg(args, 'd');
+       static char     home[128];
 
        if (arg)
-               return arg->val;
-       else {
-               static char     home[128];
+               return (arg->val);
 
-               if (cnf->home == NULL || *cnf->home == '\0')
-                       errx(EX_CONFIG, "no base home directory set");
-               sprintf(home, "%s/%s", cnf->home, user);
-               return home;
-       }
+       if (cnf->home == NULL || *cnf->home == '\0')
+               errx(EX_CONFIG, "no base home directory set");
+       snprintf(home, sizeof(home), "%s/%s", cnf->home, user);
+
+       return (home);
 }
 
 static char    *
@@ -963,19 +925,18 @@ shell_path(char const * path, char *shells[], char *sh)
                /*
                 * We need to search paths
                 */
-               strncpy(paths, path, sizeof paths);
-               paths[sizeof paths - 1] = '\0';
+               strlcpy(paths, path, sizeof(paths));
                for (p = strtok(paths, ": \t\r\n"); p != NULL; p = strtok(NULL, ": \t\r\n")) {
                        int             i;
                        static char     shellpath[256];
 
                        if (sh != NULL) {
-                               sprintf(shellpath, "%s/%s", p, sh);
+                               snprintf(shellpath, sizeof(shellpath), "%s/%s", p, sh);
                                if (access(shellpath, X_OK) == 0)
                                        return shellpath;
                        } else
                                for (i = 0; i < _UC_MAXSHELLS && shells[i] != NULL; i++) {
-                                       sprintf(shellpath, "%s/%s", p, shells[i]);
+                                       snprintf(shellpath, sizeof(shellpath), "%s/%s", p, shells[i]);
                                        if (access(shellpath, X_OK) == 0)
                                                return shellpath;
                                }
@@ -999,94 +960,51 @@ pw_shellpolicy(struct userconf * cnf, struct cargs * args, char *newshell)
        return shell_path(cnf->shelldir, cnf->shells, sh ? sh : cnf->shell_default);
 }
 
-static char const chars[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ.";
+#define        SALTSIZE        32
+
+static char const chars[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ./";
 
 char           *
 pw_pwcrypt(char *password)
 {
        int             i;
-       char            salt[12];
+       char            salt[SALTSIZE + 1];
+       char            *cryptpw;
 
        static char     buf[256];
 
        /*
         * Calculate a salt value
         */
-       for (i = 0; i < 8; i++)
-               salt[i] = chars[arc4random() % 63];
-       salt[i] = '\0';
-
-       return strcpy(buf, crypt(password, salt));
-}
-
-#if defined(USE_MD5RAND)
-u_char *
-pw_getrand(u_char *buf, int len)       /* cryptographically secure rng */
-{
-       int i;
-       for (i=0;i<len;i+=16) {
-               u_char ubuf[16];
-
-               MD5_CTX md5_ctx;
-               struct timeval tv, tvo;
-               struct rusage ru;
-               int n=0;
-               int t;
-
-               MD5Init (&md5_ctx);
-               t=getpid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               t=getppid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               gettimeofday (&tvo, NULL);
-               do {
-                       getrusage (RUSAGE_SELF, &ru);
-                       MD5Update (&md5_ctx, (u_char*)&ru, sizeof ru);
-                       gettimeofday (&tv, NULL);
-                       MD5Update (&md5_ctx, (u_char*)&tv, sizeof tv);
-               } while (n++<20 || tv.tv_usec-tvo.tv_usec<100*1000);
-               MD5Final (ubuf, &md5_ctx);
-               memcpy(buf+i, ubuf, MIN(16, len-i));
-       }
-       return buf;
-}
-
-#else  /* Portable version */
-
-static u_char *
-pw_getrand(u_char *buf, int len)
-{
-       int i;
-
-       for (i = 0; i < len; i++) {
-               unsigned long val = random();
-               /* Use all bits in the random value */
-               buf[i]=(u_char)((val >> 24) ^ (val >> 16) ^ (val >> 8) ^ val);
-       }
-       return buf;
+       for (i = 0; i < SALTSIZE; i++)
+               salt[i] = chars[arc4random_uniform(sizeof(chars) - 1)];
+       salt[SALTSIZE] = '\0';
+
+       cryptpw = crypt(password, salt);
+       if (cryptpw == NULL)
+               errx(EX_CONFIG, "crypt(3) failure");
+       return strcpy(buf, cryptpw);
 }
 
-#endif
 
 static char    *
 pw_password(struct userconf * cnf, struct cargs * args, char const * user)
 {
        int             i, l;
        char            pwbuf[32];
-       u_char          rndbuf[sizeof pwbuf];
 
        switch (cnf->default_password) {
        case -1:                /* Random password */
                l = (arc4random() % 8 + 8);     /* 8 - 16 chars */
-               pw_getrand(rndbuf, l);
                for (i = 0; i < l; i++)
-                       pwbuf[i] = chars[rndbuf[i] % (sizeof(chars)-1)];
+                       pwbuf[i] = chars[arc4random_uniform(sizeof(chars)-1)];
                pwbuf[i] = '\0';
 
                /*
                 * We give this information back to the user
                 */
-               if (getarg(args, 'h') == NULL && getarg(args, 'N') == NULL) {
+               if (getarg(args, 'h') == NULL && getarg(args, 'H') == NULL &&
+                   !conf.dryrun) {
                        if (isatty(STDOUT_FILENO))
                                printf("Password for '%s' is: ", user);
                        printf("%s\n", pwbuf);
@@ -1102,22 +1020,135 @@ pw_password(struct userconf * cnf, struct cargs * args, char const * user)
                return "*";
 
        case 1:         /* user's name */
-               strncpy(pwbuf, user, sizeof pwbuf);
-               pwbuf[sizeof pwbuf - 1] = '\0';
+               strlcpy(pwbuf, user, sizeof(pwbuf));
                break;
        }
        return pw_pwcrypt(pwbuf);
 }
 
+static int
+delete_user(struct userconf *cnf, struct passwd *pwd, char *name,
+    int delete, int mode)
+{
+       char             file[MAXPATHLEN];
+       char             home[MAXPATHLEN];
+       uid_t            uid = pwd->pw_uid;
+       struct group    *gr, *grp;
+       char             grname[LOGNAMESIZE];
+       int              rc;
+       struct stat      st;
+
+       if (strcmp(pwd->pw_name, "root") == 0)
+               errx(EX_DATAERR, "cannot remove user 'root'");
+
+       if (!PWALTDIR()) {
+               /*
+                * Remove opie record from /etc/opiekeys
+               */
+
+               rmopie(pwd->pw_name);
+
+               /*
+                * Remove crontabs
+                */
+               snprintf(file, sizeof(file), "/var/cron/tabs/%s", pwd->pw_name);
+               if (access(file, F_OK) == 0) {
+                       snprintf(file, sizeof(file), "crontab -u %s -r", pwd->pw_name);
+                       system(file);
+               }
+       }
+       /*
+        * Save these for later, since contents of pwd may be
+        * invalidated by deletion
+        */
+       snprintf(file, sizeof(file), "%s/%s", _PATH_MAILDIR, pwd->pw_name);
+       strlcpy(home, pwd->pw_dir, sizeof(home));
+       gr = GETGRGID(pwd->pw_gid);
+       if (gr != NULL)
+               strlcpy(grname, gr->gr_name, LOGNAMESIZE);
+       else
+               grname[0] = '\0';
+
+       rc = delpwent(pwd);
+       if (rc == -1)
+               err(EX_IOERR, "user '%s' does not exist", pwd->pw_name);
+       else if (rc != 0)
+               err(EX_IOERR, "passwd update");
+
+       if (cnf->nispasswd && *cnf->nispasswd=='/') {
+               rc = delnispwent(cnf->nispasswd, name);
+               if (rc == -1)
+                       warnx("WARNING: user '%s' does not exist in NIS passwd", pwd->pw_name);
+               else if (rc != 0)
+                       warn("WARNING: NIS passwd update");
+               /* non-fatal */
+       }
+
+       grp = GETGRNAM(name);
+       if (grp != NULL &&
+           (grp->gr_mem == NULL || *grp->gr_mem == NULL) &&
+           strcmp(name, grname) == 0)
+               delgrent(GETGRNAM(name));
+       SETGRENT();
+       while ((grp = GETGRENT()) != NULL) {
+               int i, j;
+               char group[MAXLOGNAME];
+               if (grp->gr_mem == NULL)
+                       continue;
+
+               for (i = 0; grp->gr_mem[i] != NULL; i++) {
+                       if (strcmp(grp->gr_mem[i], name) != 0)
+                               continue;
+
+                       for (j = i; grp->gr_mem[j] != NULL; j++)
+                               grp->gr_mem[j] = grp->gr_mem[j+1];
+                       strlcpy(group, grp->gr_name, MAXLOGNAME);
+                       chggrent(group, grp);
+               }
+       }
+       ENDGRENT();
+
+       pw_log(cnf, mode, W_USER, "%s(%u) account removed", name, uid);
+
+       if (!PWALTDIR()) {
+               /*
+                * Remove mail file
+                */
+               remove(file);
+
+               /*
+                * Remove at jobs
+                */
+               if (getpwuid(uid) == NULL)
+                       rmat(uid);
+
+               /*
+                * Remove home directory and contents
+                */
+               if (delete && *home == '/' && getpwuid(uid) == NULL &&
+                   stat(home, &st) != -1) {
+                       rm_r(home, uid);
+                       pw_log(cnf, mode, W_USER, "%s(%u) home '%s' %sremoved",
+                              name, uid, home,
+                              stat(home, &st) == -1 ? "" : "not completely ");
+               }
+       }
+
+       return (EXIT_SUCCESS);
+}
 
 static int
-print_user(struct passwd * pwd, int pretty, int v7)
+print_user(struct passwd * pwd)
 {
-       if (!pretty) {
-               char            buf[_UC_MAXLINE];
+       if (!conf.pretty) {
+               char            *buf;
+
+               if (!conf.v7)
+                       pwd->pw_passwd = (pwd->pw_passwd == NULL) ? "" : "*";
 
-               fmtpwentry(buf, pwd, v7 ? PWF_PASSWD : PWF_STANDARD);
-               fputs(buf, stdout);
+               buf = conf.v7 ? pw_make_v7(pwd) : pw_make(pwd);
+               printf("%s\n", buf);
+               free(buf);
        } else {
                int             j;
                char           *p;
@@ -1128,17 +1159,14 @@ print_user(struct passwd * pwd, int pretty, int v7)
                struct tm *    tptr;
 
                if ((p = strtok(pwd->pw_gecos, ",")) != NULL) {
-                       strncpy(uname, p, sizeof uname);
-                       uname[sizeof uname - 1] = '\0';
+                       strlcpy(uname, p, sizeof(uname));
                        if ((p = strtok(NULL, ",")) != NULL) {
-                               strncpy(office, p, sizeof office);
-                               office[sizeof office - 1] = '\0';
+                               strlcpy(office, p, sizeof(office));
                                if ((p = strtok(NULL, ",")) != NULL) {
-                                       strncpy(wphone, p, sizeof wphone);
-                                       wphone[sizeof wphone - 1] = '\0';
+                                       strlcpy(wphone, p, sizeof(wphone));
                                        if ((p = strtok(NULL, "")) != NULL) {
-                                               strncpy(hphone, p, sizeof hphone);
-                                               hphone[sizeof hphone - 1] = '\0';
+                                               strlcpy(hphone, p,
+                                                   sizeof(hphone));
                                        }
                                }
                        }
@@ -1158,14 +1186,14 @@ print_user(struct passwd * pwd, int pretty, int v7)
                        strftime(acexpire, sizeof acexpire, "%c", tptr);
                if (pwd->pw_change > (time_t)0 && (tptr = localtime(&pwd->pw_change)) != NULL)
                        strftime(pwexpire, sizeof pwexpire, "%c", tptr);
-               printf("Login Name: %-15s   #%-12ld Group: %-15s   #%ld\n"
+               printf("Login Name: %-15s   #%-12u Group: %-15s   #%u\n"
                       " Full Name: %s\n"
                       "      Home: %-26.26s      Class: %s\n"
                       "     Shell: %-26.26s     Office: %s\n"
                       "Work Phone: %-26.26s Home Phone: %s\n"
                       "Acc Expire: %-26.26s Pwd Expire: %s\n",
-                      pwd->pw_name, (long) pwd->pw_uid,
-                      grp ? grp->gr_name : "(invalid)", (long) pwd->pw_gid,
+                      pwd->pw_name, pwd->pw_uid,
+                      grp ? grp->gr_name : "(invalid)", pwd->pw_gid,
                       uname, pwd->pw_dir, pwd->pw_class,
                       pwd->pw_shell, office, wphone, hphone,
                       acexpire, pwexpire);
@@ -1174,14 +1202,16 @@ print_user(struct passwd * pwd, int pretty, int v7)
                while ((grp=GETGRENT()) != NULL)
                {
                        int     i = 0;
-                       while (grp->gr_mem[i] != NULL)
-                       {
-                               if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
+                       if (grp->gr_mem != NULL) {
+                               while (grp->gr_mem[i] != NULL)
                                {
-                                       printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
-                                       break;
+                                       if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
+                                       {
+                                               printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
+                                               break;
+                                       }
+                                       ++i;
                                }
-                               ++i;
                        }
                }
                ENDGRENT();
@@ -1190,25 +1220,63 @@ print_user(struct passwd * pwd, int pretty, int v7)
        return EXIT_SUCCESS;
 }
 
-char    *
-pw_checkname(u_char *name, int gecos)
+char *
+pw_checkname(char *name, int gecos)
 {
-       int             l = 0;
-       char const     *notch = gecos ? ":!@" : " ,\t:+&#%$^()!@~*?<>=|\\/\"";
-
-       while (name[l]) {
-               if (strchr(notch, name[l]) != NULL || name[l] < ' ' || name[l] == 127 ||
-                       (!gecos && l==0 && name[l] == '-') ||   /* leading '-' */
-                       (!gecos && name[l] & 0x80))     /* 8-bit */
-                       errx(EX_DATAERR, (name[l] >= ' ' && name[l] < 127)
-                                           ? "invalid character `%c' in field"
-                                           : "invalid character 0x%02x in field",
-                                           name[l]);
-               ++l;
+       char showch[8];
+       const char *badchars, *ch, *showtype;
+       int reject;
+
+       ch = name;
+       reject = 0;
+       if (gecos) {
+               /* See if the name is valid as a gecos (comment) field. */
+               badchars = ":!@";
+               showtype = "gecos field";
+       } else {
+               /* See if the name is valid as a userid or group. */
+               badchars = " ,\t:+&#%$^()!@~*?<>=|\\/\"";
+               showtype = "userid/group name";
+               /* Userids and groups can not have a leading '-'. */
+               if (*ch == '-')
+                       reject = 1;
+       }
+       if (!reject) {
+               while (*ch) {
+                       if (strchr(badchars, *ch) != NULL || *ch < ' ' ||
+                           *ch == 127) {
+                               reject = 1;
+                               break;
+                       }
+                       /* 8-bit characters are only allowed in GECOS fields */
+                       if (!gecos && (*ch & 0x80)) {
+                               reject = 1;
+                               break;
+                       }
+                       ch++;
+               }
+       }
+       /*
+        * A `$' is allowed as the final character for userids and groups,
+        * mainly for the benefit of samba.
+        */
+       if (reject && !gecos) {
+               if (*ch == '$' && *(ch + 1) == '\0') {
+                       reject = 0;
+                       ch++;
+               }
        }
-       if (!gecos && l > LOGNAMESIZE)
-               errx(EX_DATAERR, "name too long `%s'", name);
-       return (char *)name;
+       if (reject) {
+               snprintf(showch, sizeof(showch), (*ch >= ' ' && *ch < 127)
+                   ? "`%c'" : "0x%02x", *ch);
+               errx(EX_DATAERR, "invalid character %s at position %td in %s",
+                   showch, (ch - name), showtype);
+       }
+       if (!gecos && (ch - name) > LOGNAMESIZE)
+               errx(EX_DATAERR, "name too long `%s' (max is %d)", name,
+                   LOGNAMESIZE);
+
+       return (name);
 }
 
 
@@ -1229,7 +1297,7 @@ rmat(uid_t uid)
                            st.st_uid == uid) {
                                char            tmp[MAXPATHLEN];
 
-                               sprintf(tmp, "/usr/bin/atrm %s", e->d_name);
+                               snprintf(tmp, sizeof(tmp), "/usr/bin/atrm %s", e->d_name);
                                system(tmp);
                        }
                }
@@ -1238,10 +1306,10 @@ rmat(uid_t uid)
 }
 
 static void
-rmskey(char const * name)
+rmopie(char const * name)
 {
-       static const char etcskey[] = "/etc/skeykeys";
-       FILE   *fp = fopen(etcskey, "r+");
+       static const char etcopie[] = "/etc/opiekeys";
+       FILE   *fp = fopen(etcopie, "r+");
 
        if (fp != NULL) {
                char    tmp[1024];