]> git.cameronkatri.com Git - pw-darwin.git/blobdiff - pw/pw_user.c
Revert the libcrypt/libmd stuff back to how it was. This should not have
[pw-darwin.git] / pw / pw_user.c
index d8a2c2481796544820b35d06e916a908e22b2ba9..cf9a267bea35e11edf7f4228edb8d31023a71b76 100644 (file)
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
- *
- *     $Id: pw_user.c,v 1.1.1.2 1996/12/09 23:55:10 joerg Exp $
+ * 
  */
 
-#include <unistd.h>
-#include <fcntl.h>
+#ifndef lint
+static const char rcsid[] =
+  "$FreeBSD$";
+#endif /* not lint */
+
 #include <ctype.h>
-#include <paths.h>
+#include <err.h>
+#include <fcntl.h>
 #include <sys/param.h>
 #include <dirent.h>
+#include <paths.h>
 #include <termios.h>
+#include <sys/types.h>
+#include <sys/time.h>
+#include <sys/resource.h>
+#include <unistd.h>
+#include <utmp.h>
+#if defined(USE_MD5RAND)
+#include <md5.h>
+#endif
 #include "pw.h"
 #include "bitmap.h"
-#include "pwupd.h"
 
-static int      print_user(struct passwd * pwd, int pretty);
+#if (MAXLOGNAME-1) > UT_NAMESIZE
+#define LOGNAMESIZE UT_NAMESIZE
+#else
+#define LOGNAMESIZE (MAXLOGNAME-1)
+#endif
+
+static          int randinit;
+static         char locked_str[] = "*LOCKED*";
+
+static int      print_user(struct passwd * pwd, int pretty, int v7);
 static uid_t    pw_uidpolicy(struct userconf * cnf, struct cargs * args);
 static uid_t    pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer);
 static time_t   pw_pwdpolicy(struct userconf * cnf, struct cargs * args);
@@ -45,9 +65,9 @@ static time_t   pw_exppolicy(struct userconf * cnf, struct cargs * args);
 static char    *pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user);
 static char    *pw_shellpolicy(struct userconf * cnf, struct cargs * args, char *newshell);
 static char    *pw_password(struct userconf * cnf, struct cargs * args, char const * user);
-static char    *pw_checkname(char *name, int gecos);
 static char    *shell_path(char const * path, char *shells[], char *sh);
 static void     rmat(uid_t uid);
+static void    rmskey(char const * name);
 
 /*-
  * -C config      configuration file
@@ -83,14 +103,16 @@ static void     rmat(uid_t uid);
 int
 pw_user(struct userconf * cnf, int mode, struct cargs * args)
 {
+       int             rc, edited = 0;
        char           *p = NULL;
+       char                                     *passtmp;
        struct carg    *a_name;
        struct carg    *a_uid;
        struct carg    *arg;
        struct passwd  *pwd = NULL;
        struct group   *grp;
        struct stat     st;
-       char            line[MAXPWLINE];
+       char            line[_PASSWORD_LEN+1];
 
        static struct passwd fakeuser =
        {
@@ -103,9 +125,11 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                "User &",
                "/bin/sh",
                0,
+               0,
                0
        };
 
+
        /*
         * With M_NEXT, we only need to return the
         * next uid to stdout
@@ -126,49 +150,109 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
 
        if ((arg = getarg(args, 'b')) != NULL) {
                cnf->home = arg->val;
-               if (stat(cnf->home, &st) == -1 || !S_ISDIR(st.st_mode))
-                       cmderr(EX_OSFILE, "root home `%s' is not a directory or does not exist\n", cnf->home);
        }
+
+       /*
+        * If we'll need to use it or we're updating it,
+        * then create the base home directory if necessary
+        */
+       if (arg != NULL || getarg(args, 'm') != NULL) {
+               int     l = strlen(cnf->home);
+
+               if (l > 1 && cnf->home[l-1] == '/')     /* Shave off any trailing path delimiter */
+                       cnf->home[--l] = '\0';
+
+               if (l < 2 || *cnf->home != '/')         /* Check for absolute path name */
+                       errx(EX_DATAERR, "invalid base directory for home '%s'", cnf->home);
+
+               if (stat(cnf->home, &st) == -1) {
+                       char    dbuf[MAXPATHLEN];
+
+                       /*
+                        * This is a kludge especially for Joerg :)
+                        * If the home directory would be created in the root partition, then
+                        * we really create it under /usr which is likely to have more space.
+                        * But we create a symlink from cnf->home -> "/usr" -> cnf->home
+                        */
+                       if (strchr(cnf->home+1, '/') == NULL) {
+                               strcpy(dbuf, "/usr");
+                               strncat(dbuf, cnf->home, MAXPATHLEN-5);
+                               if (mkdir(dbuf, 0755) != -1 || errno == EEXIST) {
+                                       chown(dbuf, 0, 0);
+                                       symlink(dbuf, cnf->home);
+                               }
+                               /* If this falls, fall back to old method */
+                       }
+                       p = strncpy(dbuf, cnf->home, sizeof dbuf);
+                       dbuf[MAXPATHLEN-1] = '\0';
+                       if (stat(dbuf, &st) == -1) {
+                               while ((p = strchr(++p, '/')) != NULL) {
+                                       *p = '\0';
+                                       if (stat(dbuf, &st) == -1) {
+                                               if (mkdir(dbuf, 0755) == -1)
+                                                       goto direrr;
+                                               chown(dbuf, 0, 0);
+                                       } else if (!S_ISDIR(st.st_mode))
+                                               errx(EX_OSFILE, "'%s' (root home parent) is not a directory", dbuf);
+                                       *p = '/';
+                               }
+                       }
+                       if (stat(dbuf, &st) == -1) {
+                               if (mkdir(dbuf, 0755) == -1) {
+                               direrr: err(EX_OSFILE, "mkdir '%s'", dbuf);
+                               }
+                               chown(dbuf, 0, 0);
+                       }
+               } else if (!S_ISDIR(st.st_mode))
+                       errx(EX_OSFILE, "root home `%s' is not a directory", cnf->home);
+       }
+
        if ((arg = getarg(args, 'e')) != NULL)
                cnf->expire_days = atoi(arg->val);
 
+       if ((arg = getarg(args, 'y')) != NULL)
+               cnf->nispasswd = arg->val;
+
        if ((arg = getarg(args, 'p')) != NULL && arg->val)
                cnf->password_days = atoi(arg->val);
 
        if ((arg = getarg(args, 'g')) != NULL) {
                p = arg->val;
-               if ((grp = getgrnam(p)) == NULL) {
-                       if (!isdigit(*p) || (grp = getgrgid((gid_t) atoi(p))) == NULL)
-                               cmderr(EX_NOUSER, "group `%s' does not exist\n", p);
+               if ((grp = GETGRNAM(p)) == NULL) {
+                       if (!isdigit(*p) || (grp = GETGRGID((gid_t) atoi(p))) == NULL)
+                               errx(EX_NOUSER, "group `%s' does not exist", p);
                }
                cnf->default_group = newstr(grp->gr_name);
        }
        if ((arg = getarg(args, 'L')) != NULL)
-               cnf->default_class = pw_checkname(arg->val, 0);
+               cnf->default_class = pw_checkname((u_char *)arg->val, 0);
 
        if ((arg = getarg(args, 'G')) != NULL && arg->val) {
-               int             i = 0;
+               int i = 0;
 
-               for (p = strtok(arg->val, ", \t"); i < _UC_MAXGROUPS && p != NULL; p = strtok(NULL, ", \t")) {
-                       if ((grp = getgrnam(p)) == NULL) {
-                               if (!isdigit(*p) || (grp = getgrgid((gid_t) atoi(p))) == NULL)
-                                       cmderr(EX_NOUSER, "group `%s' does not exist\n", p);
+               for (p = strtok(arg->val, ", \t"); p != NULL; p = strtok(NULL, ", \t")) {
+                       if ((grp = GETGRNAM(p)) == NULL) {
+                               if (!isdigit(*p) || (grp = GETGRGID((gid_t) atoi(p))) == NULL)
+                                       errx(EX_NOUSER, "group `%s' does not exist", p);
                        }
-                       cnf->groups[i++] = newstr(grp->gr_name);
+                       if (extendarray(&cnf->groups, &cnf->numgroups, i + 2) != -1)
+                               cnf->groups[i++] = newstr(grp->gr_name);
                }
-               while (i < _UC_MAXGROUPS)
+               while (i < cnf->numgroups)
                        cnf->groups[i++] = NULL;
        }
+
        if ((arg = getarg(args, 'k')) != NULL) {
-               if (stat(cnf->dotdir = arg->val, &st) == -1 || S_ISDIR(st.st_mode))
-                       cmderr(EX_OSFILE, "skeleton `%s' is not a directory or does not exist\n", cnf->dotdir);
+               if (stat(cnf->dotdir = arg->val, &st) == -1 || !S_ISDIR(st.st_mode))
+                       errx(EX_OSFILE, "skeleton `%s' is not a directory or does not exist", cnf->dotdir);
        }
+
        if ((arg = getarg(args, 's')) != NULL)
                cnf->shell_default = arg->val;
 
        if (mode == M_ADD && getarg(args, 'D')) {
                if (getarg(args, 'n') != NULL)
-                       cmderr(EX_DATAERR, "can't combine `-D' with `-n name'\n");
+                       errx(EX_DATAERR, "can't combine `-D' with `-n name'");
                if ((arg = getarg(args, 'u')) != NULL && (p = strtok(arg->val, ", \t")) != NULL) {
                        if ((cnf->min_uid = (uid_t) atoi(p)) == 0)
                                cnf->min_uid = 1000;
@@ -187,74 +271,118 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                arg = getarg(args, 'C');
                if (write_userconfig(arg ? arg->val : NULL))
                        return EXIT_SUCCESS;
-               perror("config update");
+               warn("config update");
                return EX_IOERR;
        }
+
        if (mode == M_PRINT && getarg(args, 'a')) {
                int             pretty = getarg(args, 'P') != NULL;
+               int             v7 = getarg(args, '7') != NULL;
 
-               setpwent();
-               while ((pwd = getpwent()) != NULL)
-                       print_user(pwd, pretty);
-               endpwent();
+               SETPWENT();
+               while ((pwd = GETPWENT()) != NULL)
+                       print_user(pwd, pretty, v7);
+               ENDPWENT();
                return EXIT_SUCCESS;
        }
+
        if ((a_name = getarg(args, 'n')) != NULL)
-               pwd = getpwnam(pw_checkname(a_name->val, 0));
+               pwd = GETPWNAM(pw_checkname((u_char *)a_name->val, 0));
        a_uid = getarg(args, 'u');
 
        if (a_uid == NULL) {
                if (a_name == NULL)
-                       cmderr(EX_DATAERR, "user name or id required\n");
+                       errx(EX_DATAERR, "user name or id required");
 
                /*
                 * Determine whether 'n' switch is name or uid - we don't
                 * really don't really care which we have, but we need to
                 * know.
                 */
-               if (mode != M_ADD && pwd == NULL && isdigit(*a_name->val) && atoi(a_name->val) > 0) {   /* Assume uid */
+               if (mode != M_ADD && pwd == NULL
+                   && strspn(a_name->val, "0123456789") == strlen(a_name->val)
+                   && atoi(a_name->val) > 0) { /* Assume uid */
                        (a_uid = a_name)->ch = 'u';
                        a_name = NULL;
                }
        }
+
        /*
         * Update, delete & print require that the user exists
         */
-       if (mode == M_UPDATE || mode == M_DELETE || mode == M_PRINT) {
+       if (mode == M_UPDATE || mode == M_DELETE ||
+           mode == M_PRINT  || mode == M_LOCK   || mode == M_UNLOCK) {
+
                if (a_name == NULL && pwd == NULL)      /* Try harder */
-                       pwd = getpwuid(atoi(a_uid->val));
+                       pwd = GETPWUID(atoi(a_uid->val));
 
                if (pwd == NULL) {
                        if (mode == M_PRINT && getarg(args, 'F')) {
                                fakeuser.pw_name = a_name ? a_name->val : "nouser";
                                fakeuser.pw_uid = a_uid ? (uid_t) atol(a_uid->val) : -1;
-                               return print_user(&fakeuser, getarg(args, 'P') != NULL);
+                               return print_user(&fakeuser,
+                                                 getarg(args, 'P') != NULL,
+                                                 getarg(args, '7') != NULL);
                        }
                        if (a_name == NULL)
-                               cmderr(EX_NOUSER, "no such uid `%s'\n", a_uid->val);
-                       cmderr(EX_NOUSER, "no such user `%s'\n", a_name->val);
+                               errx(EX_NOUSER, "no such uid `%s'", a_uid->val);
+                       errx(EX_NOUSER, "no such user `%s'", a_name->val);
                }
+
                if (a_name == NULL)     /* May be needed later */
                        a_name = addarg(args, 'n', newstr(pwd->pw_name));
 
                /*
-                * Handle deletions now
+                * The M_LOCK and M_UNLOCK functions simply add or remove
+                * a "*LOCKED*" prefix from in front of the password to
+                * prevent it decoding correctly, and therefore prevents
+                * access. Of course, this only prevents access via
+                * password authentication (not ssh, kerberos or any
+                * other method that does not use the UNIX password) but
+                * that is a known limitation.
                 */
-               if (mode == M_DELETE) {
+
+               if (mode == M_LOCK) {
+                       if (strncmp(pwd->pw_passwd, locked_str, sizeof(locked_str)-1) == 0)
+                               errx(EX_DATAERR, "user '%s' is already locked", pwd->pw_name);
+                       passtmp = malloc(strlen(pwd->pw_passwd) + sizeof(locked_str));
+                       if (passtmp == NULL)    /* disaster */
+                               errx(EX_UNAVAILABLE, "out of memory");
+                       strcpy(passtmp, locked_str);
+                       strcat(passtmp, pwd->pw_passwd);
+                       pwd->pw_passwd = passtmp;
+                       edited = 1;
+               } else if (mode == M_UNLOCK) {
+                       if (strncmp(pwd->pw_passwd, locked_str, sizeof(locked_str)-1) != 0)
+                               errx(EX_DATAERR, "user '%s' is not locked", pwd->pw_name);
+                       pwd->pw_passwd += sizeof(locked_str)-1;
+                       edited = 1;
+               } else if (mode == M_DELETE) {
+                       /*
+                        * Handle deletions now
+                        */
                        char            file[MAXPATHLEN];
                        char            home[MAXPATHLEN];
                        uid_t           uid = pwd->pw_uid;
 
                        if (strcmp(pwd->pw_name, "root") == 0)
-                               cmderr(EX_DATAERR, "cannot remove user 'root'\n");
-
-                       /*
-                        * Remove crontabs
-                        */
-                       sprintf(file, "/var/cron/tabs/%s", pwd->pw_name);
-                       if (access(file, F_OK) == 0) {
-                               sprintf(file, "crontab -u %s -r", pwd->pw_name);
-                               system(file);
+                               errx(EX_DATAERR, "cannot remove user 'root'");
+
+                       if (!PWALTDIR()) {
+                               /*
+                                * Remove skey record from /etc/skeykeys
+                                */
+
+                               rmskey(pwd->pw_name);
+
+                               /*
+                                * Remove crontabs
+                                */
+                               sprintf(file, "/var/cron/tabs/%s", pwd->pw_name);
+                               if (access(file, F_OK) == 0) {
+                                       sprintf(file, "crontab -u %s -r", pwd->pw_name);
+                                       system(file);
+                               }
                        }
                        /*
                         * Save these for later, since contents of pwd may be
@@ -264,94 +392,166 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        strncpy(home, pwd->pw_dir, sizeof home);
                        home[sizeof home - 1] = '\0';
 
-                       if (!delpwent(pwd))
-                               cmderr(EX_IOERR, "Error updating passwd file: %s\n", strerror(errno));
-                       editgroups(a_name->val, NULL);
+                       rc = delpwent(pwd);
+                       if (rc == -1)
+                               err(EX_IOERR, "user '%s' does not exist", pwd->pw_name);
+                       else if (rc != 0) {
+                               warnc(rc, "passwd update");
+                               return EX_IOERR;
+                       }
 
-                       pw_log(cnf, mode, W_USER, "%s(%ld) account removed", a_name->val, (long) uid);
+                       if (cnf->nispasswd && *cnf->nispasswd=='/') {
+                               rc = delnispwent(cnf->nispasswd, a_name->val);
+                               if (rc == -1)
+                                       warnx("WARNING: user '%s' does not exist in NIS passwd", pwd->pw_name);
+                               else if (rc != 0)
+                                       warnc(rc, "WARNING: NIS passwd update");
+                               /* non-fatal */
+                       }
 
-                       /*
-                        * Remove mail file
-                        */
-                       remove(file);
+                       editgroups(a_name->val, NULL);
 
-                       /*
-                        * Remove at jobs
-                        */
-                       if (getpwuid(uid) == NULL)
-                               rmat(uid);
+                       pw_log(cnf, mode, W_USER, "%s(%ld) account removed", a_name->val, (long) uid);
 
-                       /*
-                        * Remove home directory and contents
-                        */
-                       if (getarg(args, 'r') != NULL && *home == '/' && getpwuid(uid) == NULL) {
-                               if (stat(home, &st) != -1) {
-                                       rm_r(home, uid);
-                                       pw_log(cnf, mode, W_USER, "%s(%ld) home '%s' %sremoved",
-                                              a_name->val, (long) uid, home,
-                                              stat(home, &st) == -1 ? "" : "not completely ");
+                       if (!PWALTDIR()) {
+                               /*
+                                * Remove mail file
+                                */
+                               remove(file);
+
+                               /*
+                                * Remove at jobs
+                                */
+                               if (getpwuid(uid) == NULL)
+                                       rmat(uid);
+
+                               /*
+                                * Remove home directory and contents
+                                */
+                               if (getarg(args, 'r') != NULL && *home == '/' && getpwuid(uid) == NULL) {
+                                       if (stat(home, &st) != -1) {
+                                               rm_r(home, uid);
+                                               pw_log(cnf, mode, W_USER, "%s(%ld) home '%s' %sremoved",
+                                                      a_name->val, (long) uid, home,
+                                                      stat(home, &st) == -1 ? "" : "not completely ");
+                                       }
                                }
                        }
                        return EXIT_SUCCESS;
                } else if (mode == M_PRINT)
-                       return print_user(pwd, getarg(args, 'P') != NULL);
+                       return print_user(pwd,
+                                         getarg(args, 'P') != NULL,
+                                         getarg(args, '7') != NULL);
 
                /*
                 * The rest is edit code
                 */
                if ((arg = getarg(args, 'l')) != NULL) {
                        if (strcmp(pwd->pw_name, "root") == 0)
-                               cmderr(EX_DATAERR, "can't rename `root' account\n");
-                       pwd->pw_name = pw_checkname(arg->val, 0);
+                               errx(EX_DATAERR, "can't rename `root' account");
+                       pwd->pw_name = pw_checkname((u_char *)arg->val, 0);
+                       edited = 1;
                }
+
                if ((arg = getarg(args, 'u')) != NULL && isdigit(*arg->val)) {
                        pwd->pw_uid = (uid_t) atol(arg->val);
+                       edited = 1;
                        if (pwd->pw_uid != 0 && strcmp(pwd->pw_name, "root") == 0)
-                               cmderr(EX_DATAERR, "can't change uid of `root' account\n");
+                               errx(EX_DATAERR, "can't change uid of `root' account");
                        if (pwd->pw_uid == 0 && strcmp(pwd->pw_name, "root") != 0)
-                               fprintf(stderr, "WARNING: account `%s' will have a uid of 0 (superuser access!)\n", pwd->pw_name);
+                               warnx("WARNING: account `%s' will have a uid of 0 (superuser access!)", pwd->pw_name);
+               }
+
+               if ((arg = getarg(args, 'g')) != NULL && pwd->pw_uid != 0) {    /* Already checked this */
+                       gid_t newgid = (gid_t) GETGRNAM(cnf->default_group)->gr_gid;
+                       if (newgid != pwd->pw_gid) {
+                               edited = 1;
+                               pwd->pw_gid = pwd->pw_gid;
+                       }
                }
-               if ((arg = getarg(args, 'g')) != NULL && pwd->pw_uid != 0)      /* Already checked this */
-                       pwd->pw_gid = (gid_t) getgrnam(cnf->default_group)->gr_gid;
 
                if ((arg = getarg(args, 'p')) != NULL) {
-                       if (*arg->val == '\0' || strcmp(arg->val, "0") == 0)
-                               pwd->pw_change = 0;
+                       if (*arg->val == '\0' || strcmp(arg->val, "0") == 0) {
+                               if (pwd->pw_change != 0) {
+                                       pwd->pw_change = 0;
+                                       edited = 1;
+                               }
+                       }
                        else {
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
                                if (now == expire)
-                                       cmderr(EX_DATAERR, "Invalid password change date `%s'\n", arg->val);
-                               pwd->pw_change = expire;
+                                       errx(EX_DATAERR, "invalid password change date `%s'", arg->val);
+                               if (pwd->pw_change != expire) {
+                                       pwd->pw_change = expire;
+                                       edited = 1;
+                               }
                        }
                }
+
                if ((arg = getarg(args, 'e')) != NULL) {
-                       if (*arg->val == '\0' || strcmp(arg->val, "0") == 0)
-                               pwd->pw_expire = 0;
+                       if (*arg->val == '\0' || strcmp(arg->val, "0") == 0) {
+                               if (pwd->pw_expire != 0) {
+                                       pwd->pw_expire = 0;
+                                       edited = 1;
+                               }
+                       }
                        else {
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
                                if (now == expire)
-                                       cmderr(EX_DATAERR, "Invalid account expiry date `%s'\n", arg->val);
-                               pwd->pw_expire = expire;
+                                       errx(EX_DATAERR, "invalid account expiry date `%s'", arg->val);
+                               if (pwd->pw_expire != expire) {
+                                       pwd->pw_expire = expire;
+                                       edited = 1;
+                               }
+                       }
+               }
+
+               if ((arg = getarg(args, 's')) != NULL) {
+                       char *shell = shell_path(cnf->shelldir, cnf->shells, arg->val);
+                       if (shell == NULL)
+                               shell = "";
+                       if (strcmp(shell, pwd->pw_shell) != 0) {
+                               pwd->pw_shell = shell;
+                               edited = 1;
                        }
                }
-               if ((arg = getarg(args, 's')) != NULL)
-                       pwd->pw_shell = shell_path(cnf->shelldir, cnf->shells, arg->val);
 
-               if (getarg(args, 'L'))
-                       pwd->pw_class = cnf->default_class;
+               if (getarg(args, 'L')) {
+                       if (cnf->default_class == NULL)
+                               cnf->default_class = "";
+                       if (strcmp(pwd->pw_class, cnf->default_class) != 0) {
+                               pwd->pw_class = cnf->default_class;
+                               edited = 1;
+                       }
+               }
+
+               if ((arg  = getarg(args, 'd')) != NULL) {
+                       if (stat(pwd->pw_dir = arg->val, &st) == -1) {
+                               if (getarg(args, 'm') == NULL && strcmp(pwd->pw_dir, "/nonexistent") != 0)
+                                 warnx("WARNING: home `%s' does not exist", pwd->pw_dir);
+                       } else if (!S_ISDIR(st.st_mode))
+                               warnx("WARNING: home `%s' is not a directory", pwd->pw_dir);
+               }
 
-               if ((arg = getarg(args, 'w')) != NULL && getarg(args, 'h') == NULL)
+               if ((arg = getarg(args, 'w')) != NULL && getarg(args, 'h') == NULL) {
                        pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
+                       edited = 1;
+               }
 
        } else {
+
+               /*
+                * Add code
+                */
+
                if (a_name == NULL)     /* Required */
-                       cmderr(EX_DATAERR, "login name required\n");
-               else if ((pwd = getpwnam(a_name->val)) != NULL) /* Exists */
-                       cmderr(EX_DATAERR, "login name `%s' already exists\n", a_name->val);
+                       errx(EX_DATAERR, "login name required");
+               else if ((pwd = GETPWNAM(a_name->val)) != NULL) /* Exists */
+                       errx(EX_DATAERR, "login name `%s' already exists", a_name->val);
 
                /*
                 * Now, set up defaults for a new user
@@ -366,16 +566,22 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                pwd->pw_expire = pw_exppolicy(cnf, args);
                pwd->pw_dir = pw_homepolicy(cnf, args, pwd->pw_name);
                pwd->pw_shell = pw_shellpolicy(cnf, args, NULL);
+               edited = 1;
 
                if (pwd->pw_uid == 0 && strcmp(pwd->pw_name, "root") != 0)
-                       fprintf(stderr, "WARNING: new account `%s' has a uid of 0 (superuser access!)\n", pwd->pw_name);
+                       warnx("WARNING: new account `%s' has a uid of 0 (superuser access!)", pwd->pw_name);
        }
 
        /*
         * Shared add/edit code
         */
-       if ((arg = getarg(args, 'c')) != NULL)
-               pwd->pw_gecos = pw_checkname(arg->val, 1);
+       if ((arg = getarg(args, 'c')) != NULL) {
+               char    *gecos = pw_checkname((u_char *)arg->val, 1);
+               if (strcmp(pwd->pw_gecos, gecos) != 0) {
+                       pwd->pw_gecos = gecos;
+                       edited = 1;
+               }
+       }
 
        if ((arg = getarg(args, 'h')) != NULL) {
                if (strcmp(arg->val, "-") == 0)
@@ -406,15 +612,16 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                fflush(stdout);
                        }
                        if (b < 0) {
-                               perror("-h file descriptor");
+                               warn("-h file descriptor");
                                return EX_IOERR;
                        }
                        line[b] = '\0';
                        if ((p = strpbrk(line, " \t\r\n")) != NULL)
                                *p = '\0';
                        if (!*line)
-                               cmderr(EX_DATAERR, "empty password read on file descriptor %d\n", fd);
+                               errx(EX_DATAERR, "empty password read on file descriptor %d", fd);
                        pwd->pw_passwd = pw_pwcrypt(line);
+                       edited = 1;
                }
        }
 
@@ -422,13 +629,49 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * Special case: -N only displays & exits
         */
        if (getarg(args, 'N') != NULL)
-               return print_user(pwd, getarg(args, 'P') != NULL);
+               return print_user(pwd,
+                                 getarg(args, 'P') != NULL,
+                                 getarg(args, '7') != NULL);
 
-       if ((mode == M_ADD && !addpwent(pwd)) ||
-           (mode == M_UPDATE && !chgpwent(a_name->val, pwd))) {
-               perror("password update");
-               return EX_IOERR;
+       if (mode == M_ADD) {
+               edited = 1;     /* Always */
+               rc = addpwent(pwd);
+               if (rc == -1) {
+                       warnx("user '%s' already exists", pwd->pw_name);
+                       return EX_IOERR;
+               } else if (rc != 0) {
+                       warnc(rc, "passwd file update");
+                       return EX_IOERR;
+               }
+               if (cnf->nispasswd && *cnf->nispasswd=='/') {
+                       rc = addnispwent(cnf->nispasswd, pwd);
+                       if (rc == -1)
+                               warnx("User '%s' already exists in NIS passwd", pwd->pw_name);
+                       else
+                               warnc(rc, "NIS passwd update");
+                       /* NOTE: we treat NIS-only update errors as non-fatal */
+               }
+       } else if (mode == M_UPDATE || mode == M_LOCK || mode == M_UNLOCK) {
+               if (edited) {   /* Only updated this if required */
+                       rc = chgpwent(a_name->val, pwd);
+                       if (rc == -1) {
+                               warnx("user '%s' does not exist (NIS?)", pwd->pw_name);
+                               return EX_IOERR;
+                       } else if (rc != 0) {
+                               warnc(rc, "passwd file update");
+                               return EX_IOERR;
+                       }
+                       if ( cnf->nispasswd && *cnf->nispasswd=='/') {
+                               rc = chgnispwent(cnf->nispasswd, a_name->val, pwd);
+                               if (rc == -1)
+                                       warn("User '%s' not found in NIS passwd", pwd->pw_name);
+                               else
+                                       warnc(rc, "NIS passwd update");
+                               /* NOTE: NIS-only update errors are not fatal */
+                       }
+               }
        }
+
        /*
         * Ok, user is created or changed - now edit group file
         */
@@ -437,10 +680,10 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                editgroups(pwd->pw_name, cnf->groups);
 
        /* pwd may have been invalidated */
-       if ((pwd = getpwnam(a_name->val)) == NULL)
-               cmderr(EX_NOUSER, "user '%s' disappeared during update\n", a_name->val);
+       if ((pwd = GETPWNAM(a_name->val)) == NULL)
+               errx(EX_NOUSER, "user '%s' disappeared during update", a_name->val);
 
-       grp = getgrgid(pwd->pw_gid);
+       grp = GETGRGID(pwd->pw_gid);
        pw_log(cnf, mode, W_USER, "%s(%ld):%s(%d):%s:%s:%s",
               pwd->pw_name, (long) pwd->pw_uid,
            grp ? grp->gr_name : "unknown", (long) (grp ? grp->gr_gid : -1),
@@ -454,42 +697,46 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        if (mode == M_ADD) {
                FILE           *fp;
 
-               sprintf(line, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
-               close(open(line, O_RDWR | O_CREAT, 0600));      /* Preserve contents &
-                                                                * mtime */
-               chown(line, pwd->pw_uid, pwd->pw_gid);
+               if (!PWALTDIR()) {
+                       sprintf(line, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
+                       close(open(line, O_RDWR | O_CREAT, 0600));      /* Preserve contents &
+                                                                        * mtime */
+                       chown(line, pwd->pw_uid, pwd->pw_gid);
 
-               /*
-                * Send mail to the new user as well, if we are asked to
-                */
-               if (cnf->newmail && *cnf->newmail && (fp = fopen(cnf->newmail, "r")) != NULL) {
-                       FILE           *pfp = popen(_PATH_SENDMAIL " -t", "w");
+                       /*
+                        * Send mail to the new user as well, if we are asked to
+                        */
+                       if (cnf->newmail && *cnf->newmail && (fp = fopen(cnf->newmail, "r")) != NULL) {
+                               FILE           *pfp = popen(_PATH_SENDMAIL " -t", "w");
 
-                       if (pfp == NULL)
-                               perror("sendmail");
-                       else {
-                               fprintf(pfp, "From: root\n" "To: %s\n" "Subject: Welcome!\n\n", pwd->pw_name);
-                               while (fgets(line, sizeof(line), fp) != NULL) {
-                                       /* Do substitutions? */
-                                       fputs(line, pfp);
+                               if (pfp == NULL)
+                                       warn("sendmail");
+                               else {
+                                       fprintf(pfp, "From: root\n" "To: %s\n" "Subject: Welcome!\n\n", pwd->pw_name);
+                                       while (fgets(line, sizeof(line), fp) != NULL) {
+                                               /* Do substitutions? */
+                                               fputs(line, pfp);
+                                       }
+                                       pclose(pfp);
+                                       pw_log(cnf, mode, W_USER, "%s(%ld) new user mail sent",
+                                              pwd->pw_name, (long) pwd->pw_uid);
                                }
-                               pclose(pfp);
-                               pw_log(cnf, mode, W_USER, "%s(%ld) new user mail sent",
-                                      pwd->pw_name, (long) pwd->pw_uid);
+                               fclose(fp);
                        }
-                       fclose(fp);
                }
        }
+
        /*
         * Finally, let's create and populate the user's home directory. Note
         * that this also `works' for editing users if -m is used, but
         * existing files will *not* be overwritten.
         */
-       if (getarg(args, 'm') != NULL && pwd->pw_dir && *pwd->pw_dir == '/' && pwd->pw_dir[1]) {
+       if (!PWALTDIR() && getarg(args, 'm') != NULL && pwd->pw_dir && *pwd->pw_dir == '/' && pwd->pw_dir[1]) {
                copymkdir(pwd->pw_dir, cnf->dotdir, 0755, pwd->pw_uid, pwd->pw_gid);
                pw_log(cnf, mode, W_USER, "%s(%ld) home %s made",
                       pwd->pw_name, (long) pwd->pw_uid, pwd->pw_dir);
        }
+
        return EXIT_SUCCESS;
 }
 
@@ -507,8 +754,8 @@ pw_uidpolicy(struct userconf * cnf, struct cargs * args)
        if (a_uid != NULL) {
                uid = (uid_t) atol(a_uid->val);
 
-               if ((pwd = getpwuid(uid)) != NULL && getarg(args, 'o') == NULL)
-                       cmderr(EX_DATAERR, "uid `%ld' has already been allocated\n", (long) pwd->pw_uid);
+               if ((pwd = GETPWUID(uid)) != NULL && getarg(args, 'o') == NULL)
+                       errx(EX_DATAERR, "uid `%ld' has already been allocated", (long) pwd->pw_uid);
        } else {
                struct bitmap   bm;
 
@@ -527,11 +774,11 @@ pw_uidpolicy(struct userconf * cnf, struct cargs * args)
                /*
                 * Now, let's fill the bitmap from the password file
                 */
-               setpwent();
-               while ((pwd = getpwent()) != NULL)
-                       if (pwd->pw_uid >= (int) cnf->min_uid && pwd->pw_uid <= (int) cnf->max_uid)
+               SETPWENT();
+               while ((pwd = GETPWENT()) != NULL)
+                       if (pwd->pw_uid >= (uid_t) cnf->min_uid && pwd->pw_uid <= (uid_t) cnf->max_uid)
                                bm_setbit(&bm, pwd->pw_uid - cnf->min_uid);
-               endpwent();
+               ENDPWENT();
 
                /*
                 * Then apply the policy, with fallback to reuse if necessary
@@ -543,7 +790,7 @@ pw_uidpolicy(struct userconf * cnf, struct cargs * args)
                 * Another sanity check
                 */
                if (uid < cnf->min_uid || uid > cnf->max_uid)
-                       cmderr(EX_SOFTWARE, "unable to allocate a new uid - range fully used\n");
+                       errx(EX_SOFTWARE, "unable to allocate a new uid - range fully used");
                bm_dealloc(&bm);
        }
        return uid;
@@ -566,15 +813,15 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
        /*
         * Check the given gid, if any
         */
-       setgrent();
+       SETGRENT();
        if (a_gid != NULL) {
-               if ((grp = getgrnam(a_gid->val)) == NULL) {
+               if ((grp = GETGRNAM(a_gid->val)) == NULL) {
                        gid = (gid_t) atol(a_gid->val);
-                       if ((gid == 0 && !isdigit(*a_gid->val)) || (grp = getgrgid(gid)) == NULL)
-                               cmderr(EX_NOUSER, "group `%s' is not defined\n", a_gid->val);
+                       if ((gid == 0 && !isdigit(*a_gid->val)) || (grp = GETGRGID(gid)) == NULL)
+                               errx(EX_NOUSER, "group `%s' is not defined", a_gid->val);
                }
                gid = grp->gr_gid;
-       } else if ((grp = getgrnam(nam)) != NULL && grp->gr_mem[0] == NULL) {
+       } else if ((grp = GETGRNAM(nam)) != NULL && grp->gr_mem[0] == NULL) {
                gid = grp->gr_gid;  /* Already created? Use it anyway... */
        } else {
                struct cargs    grpargs;
@@ -592,7 +839,7 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                 * user's name dups an existing group, then the group add
                 * function will happily handle that case for us and exit.
                 */
-               if (getgrgid(prefer) == NULL) {
+               if (GETGRGID(prefer) == NULL) {
                        sprintf(tmp, "%lu", (unsigned long) prefer);
                        addarg(&grpargs, 'g', tmp);
                }
@@ -605,7 +852,7 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                else
                {
                        pw_group(cnf, M_ADD, &grpargs);
-                       if ((grp = getgrnam(nam)) != NULL)
+                       if ((grp = GETGRNAM(nam)) != NULL)
                                gid = grp->gr_gid;
                }
                a_gid = grpargs.lh_first;
@@ -615,7 +862,7 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                        a_gid = t;
                }
        }
-       endgrent();
+       ENDGRENT();
        return gid;
 }
 
@@ -625,11 +872,11 @@ pw_pwdpolicy(struct userconf * cnf, struct cargs * args)
 {
        time_t          result = 0;
        time_t          now = time(NULL);
-       struct carg    *arg = getarg(args, 'e');
+       struct carg    *arg = getarg(args, 'p');
 
        if (arg != NULL) {
                if ((result = parse_date(now, arg->val)) == now)
-                       cmderr(EX_DATAERR, "invalid date/time `%s'\n", arg->val);
+                       errx(EX_DATAERR, "invalid date/time `%s'", arg->val);
        } else if (cnf->password_days > 0)
                result = now + ((long) cnf->password_days * 86400L);
        return result;
@@ -645,7 +892,7 @@ pw_exppolicy(struct userconf * cnf, struct cargs * args)
 
        if (arg != NULL) {
                if ((result = parse_date(now, arg->val)) == now)
-                       cmderr(EX_DATAERR, "invalid date/time `%s'\n", arg->val);
+                       errx(EX_DATAERR, "invalid date/time `%s'", arg->val);
        } else if (cnf->expire_days > 0)
                result = now + ((long) cnf->expire_days * 86400L);
        return result;
@@ -663,7 +910,7 @@ pw_homepolicy(struct userconf * cnf, struct cargs * args, char const * user)
                static char     home[128];
 
                if (cnf->home == NULL || *cnf->home == '\0')
-                       cmderr(EX_CONFIG, "no base home directory set\n");
+                       errx(EX_CONFIG, "no base home directory set");
                sprintf(home, "%s/%s", cnf->home, user);
                return home;
        }
@@ -699,8 +946,8 @@ shell_path(char const * path, char *shells[], char *sh)
                                }
                }
                if (sh == NULL)
-                       cmderr(EX_OSFILE, "can't find shell `%s' in shell paths\n", sh);
-               cmderr(EX_CONFIG, "no default shell available or defined\n");
+                       errx(EX_OSFILE, "can't find shell `%s' in shell paths", sh);
+               errx(EX_CONFIG, "no default shell available or defined");
                return NULL;
        }
 }
@@ -730,7 +977,14 @@ pw_pwcrypt(char *password)
        /*
         * Calculate a salt value
         */
-       srandom((unsigned) (time(NULL) | getpid()));
+       if (!randinit) {
+               randinit = 1;
+#ifdef __FreeBSD__
+               srandomdev();
+#else
+               srandom((unsigned long) (time(NULL) ^ getpid()));
+#endif
+       }
        for (i = 0; i < 8; i++)
                salt[i] = chars[random() % 63];
        salt[i] = '\0';
@@ -738,27 +992,84 @@ pw_pwcrypt(char *password)
        return strcpy(buf, crypt(password, salt));
 }
 
+#if defined(USE_MD5RAND)
+u_char *
+pw_getrand(u_char *buf, int len)       /* cryptographically secure rng */
+{
+       int i;
+       for (i=0;i<len;i+=16) {
+               u_char ubuf[16];
+
+               MD5_CTX md5_ctx;
+               struct timeval tv, tvo;
+               struct rusage ru;
+               int n=0;
+               int t;
+
+               MD5Init (&md5_ctx);
+               t=getpid();
+               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
+               t=getppid();
+               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
+               gettimeofday (&tvo, NULL);
+               do {
+                       getrusage (RUSAGE_SELF, &ru);
+                       MD5Update (&md5_ctx, (u_char*)&ru, sizeof ru);
+                       gettimeofday (&tv, NULL);
+                       MD5Update (&md5_ctx, (u_char*)&tv, sizeof tv);
+               } while (n++<20 || tv.tv_usec-tvo.tv_usec<100*1000);
+               MD5Final (ubuf, &md5_ctx);
+               memcpy(buf+i, ubuf, MIN(16, len-n));
+       }
+       return buf;
+}
+
+#else  /* Portable version */
+
+static u_char *
+pw_getrand(u_char *buf, int len)
+{
+       int i;
+
+       for (i = 0; i < len; i++) {
+               unsigned long val = random();
+               /* Use all bits in the random value */
+               buf[i]=(u_char)((val >> 24) ^ (val >> 16) ^ (val >> 8) ^ val);
+       }
+       return buf;
+}
+
+#endif
 
 static char    *
 pw_password(struct userconf * cnf, struct cargs * args, char const * user)
 {
        int             i, l;
        char            pwbuf[32];
+       u_char          rndbuf[sizeof pwbuf];
 
        switch (cnf->default_password) {
        case -1:                /* Random password */
-               srandom((unsigned) (time(NULL) | getpid()));
+               if (!randinit) {
+                       randinit = 1;
+#ifdef __FreeBSD__
+                       srandomdev();
+#else
+                       srandom((unsigned long) (time(NULL) ^ getpid()));
+#endif
+               }
                l = (random() % 8 + 8); /* 8 - 16 chars */
+               pw_getrand(rndbuf, l);
                for (i = 0; i < l; i++)
-                       pwbuf[i] = chars[random() % sizeof(chars)];
+                       pwbuf[i] = chars[rndbuf[i] % (sizeof(chars)-1)];
                pwbuf[i] = '\0';
 
                /*
                 * We give this information back to the user
                 */
                if (getarg(args, 'h') == NULL && getarg(args, 'N') == NULL) {
-                       if (isatty(0))
-                               printf("Password is: ");
+                       if (isatty(1))
+                               printf("Password for '%s' is: ", user);
                        printf("%s\n", pwbuf);
                        fflush(stdout);
                }
@@ -781,19 +1092,21 @@ pw_password(struct userconf * cnf, struct cargs * args, char const * user)
 
 
 static int
-print_user(struct passwd * pwd, int pretty)
+print_user(struct passwd * pwd, int pretty, int v7)
 {
        if (!pretty) {
                char            buf[_UC_MAXLINE];
 
-               fmtpwent(buf, pwd);
+               fmtpwentry(buf, pwd, v7 ? PWF_PASSWD : PWF_STANDARD);
                fputs(buf, stdout);
        } else {
                int             j;
                char           *p;
-               struct group   *grp = getgrgid(pwd->pw_gid);
+               struct group   *grp = GETGRGID(pwd->pw_gid);
                char            uname[60] = "User &", office[60] = "[None]",
                                wphone[60] = "[None]", hphone[60] = "[None]";
+               char            acexpire[32] = "[None]", pwexpire[32] = "[None]";
+               struct tm *    tptr;
 
                if ((p = strtok(pwd->pw_gecos, ",")) != NULL) {
                        strncpy(uname, p, sizeof uname);
@@ -822,51 +1135,61 @@ print_user(struct passwd * pwd, int pretty)
                        memmove(p, pwd->pw_name, l);
                        *p = (char) toupper(*p);
                }
-               printf("Login Name : %-10s   #%-22ld  Group : %-10s   #%ld\n"
-                      " Full Name : %s\n"
-                      "      Home : %-32.32s      Class : %s\n"
-                      "     Shell : %-32.32s     Office : %s\n"
-                      "Work Phone : %-32.32s Home Phone : %s\n",
-                      
+               if (pwd->pw_expire > (time_t)0 && (tptr = localtime(&pwd->pw_expire)) != NULL)
+                 strftime(acexpire, sizeof acexpire, "%c", tptr);
+               if (pwd->pw_change > (time_t)9 && (tptr = localtime(&pwd->pw_change)) != NULL)
+                 strftime(pwexpire, sizeof pwexpire, "%c", tptr);
+               printf("Login Name: %-15s   #%-12ld Group: %-15s   #%ld\n"
+                      " Full Name: %s\n"
+                      "      Home: %-26.26s      Class: %s\n"
+                      "     Shell: %-26.26s     Office: %s\n"
+                      "Work Phone: %-26.26s Home Phone: %s\n"
+                      "Acc Expire: %-26.26s Pwd Expire: %s\n",
                       pwd->pw_name, (long) pwd->pw_uid,
                       grp ? grp->gr_name : "(invalid)", (long) pwd->pw_gid,
                       uname, pwd->pw_dir, pwd->pw_class,
-                      pwd->pw_shell, office, wphone, hphone);
-               setgrent();
+                      pwd->pw_shell, office, wphone, hphone,
+                      acexpire, pwexpire);
+               SETGRENT();
                j = 0;
-               while ((grp=getgrent()) != NULL)
+               while ((grp=GETGRENT()) != NULL)
                {
                        int     i = 0;
-                       while (i < _UC_MAXGROUPS && grp->gr_mem[i] != NULL)
+                       while (grp->gr_mem[i] != NULL)
                        {
                                if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
                                {
-                                       printf(j++ == 0 ? "    Groups : %s" : ",%s", grp->gr_name);
+                                       printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
                                        break;
                                }
                                ++i;
                        }
                }
-               endgrent();
+               ENDGRENT();
                printf("%s\n", j ? "\n" : "");
        }
        return EXIT_SUCCESS;
 }
 
-static char    *
-pw_checkname(char *name, int gecos)
+char    *
+pw_checkname(u_char *name, int gecos)
 {
        int             l = 0;
-       char const     *notch = gecos ? ":" : " :+-&#%$^()!@~*?<>=|\\/\"";
+       char const     *notch = gecos ? ":!@" : " ,\t:+&#%$^()!@~*?<>=|\\/\"";
 
        while (name[l]) {
-               if (strchr(notch, name[l]) != NULL || name[l] < ' ')
-                       cmderr(EX_DATAERR, "invalid character `%c' in field\n", name[l]);
+               if (strchr(notch, name[l]) != NULL || name[l] < ' ' || name[l] == 127 ||
+                       (!gecos && l==0 && name[l] == '-') ||   /* leading '-' */
+                       (!gecos && name[l] & 0x80))     /* 8-bit */
+                       errx(EX_DATAERR, (name[l] >= ' ' && name[l] < 127)
+                                           ? "invalid character `%c' in field"
+                                           : "invalid character 0x%02x in field",
+                                           name[l]);
                ++l;
        }
-       if (!gecos && l > 8)
-               cmderr(EX_DATAERR, "name too long `%s'\n", name);
-       return name;
+       if (!gecos && l > LOGNAMESIZE)
+               errx(EX_DATAERR, "name too long `%s'", name);
+       return (char *)name;
 }
 
 
@@ -894,3 +1217,31 @@ rmat(uid_t uid)
                closedir(d);
        }
 }
+
+static void
+rmskey(char const * name)
+{
+       static const char etcskey[] = "/etc/skeykeys";
+       FILE   *fp = fopen(etcskey, "r+");
+
+       if (fp != NULL) {
+               char    tmp[1024];
+               off_t   atofs = 0;
+               int     length = strlen(name);
+
+               while (fgets(tmp, sizeof tmp, fp) != NULL) {
+                       if (strncmp(name, tmp, length) == 0 && tmp[length]==' ') {
+                               if (fseek(fp, atofs, SEEK_SET) == 0) {
+                                       fwrite("#", 1, 1, fp);  /* Comment username out */
+                               }
+                               break;
+                       }
+                       atofs = ftell(fp);
+               }
+               /*
+                * If we got an error of any sort, don't update!
+                */
+               fclose(fp);
+       }
+}
+