]> git.cameronkatri.com Git - pw-darwin.git/commit
pw useradd: Validate the user name before creating the entry
authorEd Maste <emaste@FreeBSD.org>
Sat, 19 Aug 2017 00:32:26 +0000 (00:32 +0000)
committerEd Maste <emaste@FreeBSD.org>
Sat, 19 Aug 2017 00:32:26 +0000 (00:32 +0000)
commitc0bc488b2c50819975f1c59b5b26e3ce8c4f5da4
treea697d3f6b15a67d8b1fbf82ff08a0629b4867598
parentd79c5099603f0afa9e292d79f9595563cd623cf3
pw useradd: Validate the user name before creating the entry

Previouly it was possible to create users with spaces in the name with:
pw useradd -u 1234 -g 1234 -n 'test user'

The "-g 1234" is relevant, without it the name was already rejected
as expected:

[fk@test ~]$ sudo pw useradd -u 1234 -n 'test user'
pw: invalid character ` ' at position 4 in userid/group name

Bug unintentionally found with a salt config without explicit name entry:

test user:
  user.present:
    - uid: 1234
    - gid: 1234
    - fullname: Test user
    - shell: /usr/local/bin/bash
    - home: /home/test
    - groups:
      - wheel
      - salt

"Luckily" salt modules rarely bother with input validation either ...

PR: 221416
Submitted by: Fabian Keil
Obtained from: ElectroBSD
MFC after: 1 week
pw/pw_user.c