]> git.cameronkatri.com Git - pw-darwin.git/commit
pw should sanitize the argument of -w.
authorAlan Somers <asomers@FreeBSD.org>
Wed, 13 Jul 2016 17:09:20 +0000 (17:09 +0000)
committerAlan Somers <asomers@FreeBSD.org>
Wed, 13 Jul 2016 17:09:20 +0000 (17:09 +0000)
commite9e9b3528bf75d192d0a273a1d3f7e11a83103f7
treed952e000c012529909e030bb0233c1df7a85d28e
parent043e0d933a6fa3cedba9a0c0db9d995288aa5f53
pw should sanitize the argument of -w.

Otherwise, it will silently disable the login for the selected account if
the argument is unrecognizable.

usr.sbin/pw/pw.h
usr.sbin/pw/pw_conf.c
usr.sbin/pw/pw_user.c
Use separate rules to validate boolean parameters and passwd
parameters.  Error out if a password parameter cannot be parsed.

usr.sbin/pw/tests/Makefile
usr.sbin/pw/tests/crypt.c
usr.sbin/pw/tests/pw_useradd.sh
usr.sbin/pw/tests/pw_usermod.sh
Add tests for the validation.  Also, enhance existing
password-related tests to actually validate that the correct hash is
written to master.passwd.

Reviewed by: bapt
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D6840
pw/pw.h
pw/pw_conf.c
pw/pw_user.c