summaryrefslogtreecommitdiffstats
path: root/pw/pw_vpw.c
diff options
context:
space:
mode:
authorBaptiste Daroussin <bapt@FreeBSD.org>2015-07-07 21:05:20 +0000
committerBaptiste Daroussin <bapt@FreeBSD.org>2015-07-07 21:05:20 +0000
commit234c04262f119960f79894ca616c3f54905022f5 (patch)
treefeca1e9cbe0d2c9068ecd4a8330c5ecdac68d05c /pw/pw_vpw.c
parent8e992a6723e414140dd80a5ab394be9246bffe37 (diff)
downloadpw-darwin-234c04262f119960f79894ca616c3f54905022f5.tar.gz
pw-darwin-234c04262f119960f79894ca616c3f54905022f5.tar.zst
pw-darwin-234c04262f119960f79894ca616c3f54905022f5.zip
pw: fail if an invalid entry is found while parsing master.passwd and group
PR: 198554 Reported by: diaran <fbsd@centraltech.co.uk> MFC after: 2 days
Diffstat (limited to 'pw/pw_vpw.c')
-rw-r--r--pw/pw_vpw.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/pw/pw_vpw.c b/pw/pw_vpw.c
index 99663be..a23c66e 100644
--- a/pw/pw_vpw.c
+++ b/pw/pw_vpw.c
@@ -38,6 +38,7 @@ static const char rcsid[] =
#include <string.h>
#include <stdlib.h>
#include <sys/param.h>
+#include <err.h>
#include "pwupd.h"
@@ -80,6 +81,9 @@ vnextpwent(char const *nam, uid_t uid, int doclose)
if (line[linelen - 1 ] == '\n')
line[linelen - 1] = '\0';
pw = pw_scan(line, PWSCAN_MASTER);
+ if (pw == NULL)
+ errx(EXIT_FAILURE, "Invalid user entry in '%s':"
+ " '%s'", getpwpath(_MASTERPASSWD), line);
if (uid != (uid_t)-1) {
if (uid == pw->pw_uid)
break;
@@ -160,6 +164,9 @@ vnextgrent(char const *nam, gid_t gid, int doclose)
if (line[linelen - 1 ] == '\n')
line[linelen - 1] = '\0';
gr = gr_scan(line);
+ if (gr == NULL)
+ errx(EXIT_FAILURE, "Invalid group entry in '%s':"
+ " '%s'", getgrpath(_GROUP), line);
if (gid != (gid_t)-1) {
if (gid == gr->gr_gid)
break;