| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Reported by: Mike Selnet via forums.freebsd.org
MFC after: 3 days
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The length of the name returned from the $LOGNAME and $USER can be
very long and it was being concatenated to a fixed length buffer
with no bounds checking. Fix this problem by limiting the length
of the name copied.
Additionally, this name is actually used to create a format string
to be used in adding log file entries so embedded % characters in
the name could confuse *printf(), and embedded whitespace could
confuse a log file parser. Handle the former by escaping each %
with an additional %, and handle the latter by simply stripping it
out.
Clean up the code by moving the variable declarations to the top
of the function, formatting them to conform with style, and moving
intialization elsewhere.
Reduce code indentation by returning early in a couple of places.
Reported by: Coverity
CID: 1006692
Reviewed by: markj (previous version)
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D6490
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after r298107
Summary of changes:
- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that
namespacing is kept with FILES appropriately, and that this shouldn't need
to be repeated if the namespace changes -- only the definition of PACKAGE
needs to be changed
- Allow PACKAGE to be overridden by callers instead of forcing it to always be
`tests`. In the event we get to the point where things can be split up
enough in the base system, it would make more sense to group the tests
with the blocks they're a part of, e.g. byacc with byacc-tests, etc
- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used
previously.
- Remove unnecessary TESTSPACKAGE definitions; this has been elided into
bsd.tests.mk
- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES;
${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.
- Fix installation of files under data/ subdirectories in lib/libc/tests/hash
and lib/libc/tests/net/getaddrinfo
- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)
Document the proposed changes in share/examples/tests/tests/... via examples
so it's clear that ${PACKAGES}FILES is the suggested way forward in terms of
replacing FILES. share/mk/bsd.README didn't seem like the appropriate method
of communicating that info.
MFC after: never probably
X-MFC with: r298107
PR: 209114
Relnotes: yes
Tested with: buildworld, installworld, checkworld; buildworld, packageworld
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
| |
adduser example in the Handbook.
MFC after: 1 week
|
|\
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
| |
| |
| |
| |
| |
| | |
surrounding sentences. From a discussion on -ports.
Reviewed by: David Wolfskill <david@catwhisker.org>
|
| |
| |
| |
| | |
Found by 'include-what-you-use'
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
| |
| |
| |
| | |
Sponsored by: EMC / Isilon Storage Division
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
| |
| |
| |
| |
| | |
MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
| |
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
|\|
| |
| |
| | |
Sponsored by: The FreeBSD Foundation
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
relax it a bit so gecos can be used to store multibytes data.
This was unseen before FreeBSD 10.2 as this validation function was motly unused
since FreeBSD 10.2 the usage of this function has been generalized to improve
validation.
Reported by: des
MFC after: 1 week
|
| |
| |
| |
| |
| |
| |
| | |
Add a regression test about it
PR: 204968
MFC after: 1 week
|
| |
| |
| |
| |
| |
| |
| |
| | |
because it is also used as an indicator of whether a name or an UID is
being used and we may have undefined results as 'name' may contain
uninitialized stack contents.
MFC after: 2 weeks
|
| |
| |
| |
| |
| |
| |
| | |
It is unlikely since the first check in the function is that dir[0] is '/',
but later code changes may make it real.
Coverity CID: 1332104
|
| |\
| | |
| | |
| | | |
Sponsored by: Gandi.net
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
by default
Reported by: Florian Degner <f.degner@gmx.de>
MFC after: 1 week
PR: 203876
Sponsored by: EMC / Isilon Storage Division
|
|\ \ \
| | |/
| |/|
| | | |
Sponsored by: The FreeBSD Foundation
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
netbsd-tests.test.mk (r289151)
- Eliminate explicit OBJTOP/SRCTOP setting
- Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk
- Remove unnecessary TESTSDIR setting
- Use SRCTOP where possible for clarity
MFC after: 2 weeks
Sponsored by: EMC / Isilon Storage Divison
|
|\| | |
|
|\| | |
|