summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* In pw_userlock, set 'name' to NULL when we encounter an all number stringXin LI2015-10-301-2/+3
| | | | | | | | because it is also used as an indicator of whether a name or an UID is being used and we may have undefined results as 'name' may contain uninitialized stack contents. MFC after: 2 weeks
* Fix unlikely memory leak.Bryan Drewery2015-10-291-1/+3
| | | | | | | It is unlikely since the first check in the function is that dir[0] is '/', but later code changes may make it real. Coverity CID: 1332104
* Merge from headBaptiste Daroussin2015-10-2822-1668/+2350
|\ | | | | | | Sponsored by: Gandi.net
| * Initialize `quiet` to false so `pw groupnext` again prints out the next gidEnji Cooper2015-10-191-1/+1
| | | | | | | | | | | | | | | | | | by default Reported by: Florian Degner <f.degner@gmx.de> MFC after: 1 week PR: 203876 Sponsored by: EMC / Isilon Storage Division
| * Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andEnji Cooper2015-10-121-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | netbsd-tests.test.mk (r289151) - Eliminate explicit OBJTOP/SRCTOP setting - Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk - Remove unnecessary TESTSDIR setting - Use SRCTOP where possible for clarity MFC after: 2 weeks Sponsored by: EMC / Isilon Storage Divison
| * Fix a repeated typo: rootir -> rootdir.Warren Block2015-10-091-11/+11
| | | | | | | | | | Approved by: bapt MFC after: 1 week
| * Regression: fix usershow -7Baptiste Daroussin2015-09-141-1/+1
| | | | | | | | | | Submitted by: Dan McGregor (via IRC) MFC after: 2 days
| * Regression: fix pw usermod -dBaptiste Daroussin2015-09-121-0/+1
| | | | | | | | | | | | | | | | | | Mark the user has having been edited if -d option is passed to usermod and so the request change of home directory actually happen PR: 203052 Reported by: lenzi.sergio@gmail.com MFC after: 2 days
| * Fix err pointer not initialized to NULL resultingBaptiste Daroussin2015-08-212-0/+16
| | | | | | | | Reported by: "O. Hartmann" <ohartman@zedat.fu-berlin.de>
| * Fix typo in regression testBaptiste Daroussin2015-08-211-1/+1
| |
| * Fix /home symlink creationBaptiste Daroussin2015-08-212-1/+14
| | | | | | | | Add regression test about it
| * Fix useradd regression:Baptiste Daroussin2015-08-212-2/+67
| | | | | | | | | | | | | | | | Readd the function to create the parents home directory if it does not exists. if it is only a directory at the top level of the hierarchy symlink it into /usr as it used to be done before. Reported by: kevlo, adrian
| * Regression: fix pw usermod -w xxxBaptiste Daroussin2015-08-142-0/+16
| | | | | | | | Reported by: gjb
| * Add regression tests for a bug reported in stable/10Baptiste Daroussin2015-08-051-0/+9
| | | | | | | | | | While pw(8) on head is not affected it is worth adding more regression tests ensuring this bug will not happen unnoticed in the futur
| * Avoid calling strlen() where we can use the strspn() return value.Ed Schouten2015-08-032-9/+9
| |
| * Clarify pw(8) manual w/respect to required arguments. Break long lines atDevin Teske2015-08-031-90/+118
| | | | | | | | | | | | | | | | | | punctuation while here. Differential Revision: https://reviews.freebsd.org/D2700 Reviewed by: wblock, bapt MFC after: 3 days X-MFC-to: stable/10
| * Fix bugs spotted by gccBaptiste Daroussin2015-08-031-3/+4
| | | | | | | | Reported by: adrian
| * Actually set quiet to something.Adrian Chadd2015-08-031-1/+1
| | | | | | | | | | /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect
| * Use intmax_t rather than long longBaptiste Daroussin2015-08-021-2/+2
| |
| * Convert the year used for regression test fro 2043 to 2037Baptiste Daroussin2015-08-021-11/+11
| | | | | | | | This makes the regression tests pass on systems where time_t is 32bits
| * Fix build on 32bitsBaptiste Daroussin2015-08-021-2/+2
| |
| * Split some extra long linesBaptiste Daroussin2015-08-021-2/+4
| |
| * Split some extra long linesBaptiste Daroussin2015-08-021-5/+10
| |
| * Cleanup a bit includesBaptiste Daroussin2015-08-0212-52/+43
| |
| * Add regression tests about adding already existsing groups/usersBaptiste Daroussin2015-08-022-0/+22
| |
| * Fix regression: report if a group already exists when creating itBaptiste Daroussin2015-08-021-0/+2
| |
| * Fix regression: report again if a username already exists when creating itBaptiste Daroussin2015-08-021-0/+3
| |
| * Remove dead codeBaptiste Daroussin2015-08-021-11/+0
| |
| * Rewrite parsing subcommands arguments of pw(8)Baptiste Daroussin2015-08-0214-1490/+2011
|/ | | | | | | | | | | | | Now each subcommands checks its arguments in a dedicated functions. This helps improving input validation, code readability/maintainability While here: - Add a -y option to pw userdel/usermod so it can maintain NIS servers if nispasswd is not defined in pw.conf(5) - Allow pw -r <rootdir> to remove directory with userdel -r - Fix bug when renaming a user which was not renaming the user name it groups it is a member of. - Only parse pw.conf(5) when needed.
* Remove netbsd tests on pw(8)Baptiste Daroussin2015-08-021-11/+0
| | | | | | First they are redundant with the tests we currently have on pw(8) Second they to modify the host database instead of being self contained withing the test directory
* Remove things that crept in after badly checked revertBaptiste Daroussin2015-08-011-2/+0
|
* Partial revert of r286152Baptiste Daroussin2015-08-014-16/+6
| | | | More work needed on the cli validation
* Fix buildBaptiste Daroussin2015-08-011-0/+1
|
* Fix formatting of new codeBaptiste Daroussin2015-08-011-20/+26
| | | | | | | Fix sorting or errstr Remove useless initialisation or errstr Reported by: bde
* Validate expiration days and password days from commmand line and pw.confBaptiste Daroussin2015-08-014-8/+28
|
* Validate the max_uid/max_gid boundaries and entry type in pw.confBaptiste Daroussin2015-08-011-7/+23
|
* Cast uid/git to uintmax_t when using printf-like functions so the size ofBaptiste Daroussin2015-08-013-23/+27
| | | | uid/gid size remains a implementation detail
* Improve strtounumBaptiste Daroussin2015-07-302-24/+21
| | | | | | | | | Fix many style bugs Better variable naming Use C99 'restrict' were apropriate Fix potential errno race Submitted by: bde
* Cleanup includesBaptiste Daroussin2015-07-291-6/+3
|
* Actually set the proper licenseBaptiste Daroussin2015-07-291-12/+13
| | | | Reported by: trasz
* Actually add the new codeBaptiste Daroussin2015-07-291-0/+73
|
* Create a strtounum function using the same API as strtonumBaptiste Daroussin2015-07-293-4/+8
| | | | | This function returns uintmax_t Use this function to convert to gid_t/uid_t
* Reject usermod and userdel if the user concerned is not on the user databaseBaptiste Daroussin2015-07-281-0/+19
| | | | | | | | | | | | | supposed to be manipulated This prevent pw usermod creating a new local user when requesting to usermod on a username is defined in LDAP. This issue only happens when modifying the local user database (not inpacting commands when -V or -R are used). PR: 187653 Submitted by: tmwalaszek@gmail.com
* Check uid/gid used when creating a user/group are not larger than ↵Baptiste Daroussin2015-07-284-2/+26
| | | | | | | UID_MAX/GID_MAX PR: 173977 Reported by: nvass@gmx.com
* Fix wrong warning printed after changing or updating NIS usersBaptiste Daroussin2015-07-281-2/+2
| | | | | PR: 37672 Submitted by: chris+freebsd@chrullrich.de
* when -n is passed to any pw subcommand it is always expected to be considered asBaptiste Daroussin2015-07-282-8/+11
| | | | | | | | a name so do not try to convert it to an id if it is a numeric value PR: 31933 Reported by: ted@impulse.net Sponsored by: gandi.net
* Really fix -oBaptiste Daroussin2015-07-131-1/+1
|
* Add regression tests to ensure we keep allowing creating users with uid0Baptiste Daroussin2015-07-131-0/+11
|
* Regression fix: allow to create users with uid0Baptiste Daroussin2015-07-131-1/+1
| | | | Reported by: Jan Mikkelsen <janm@transactionware.com>
* Fix logic of check duplicates that has been invertedBaptiste Daroussin2015-07-131-1/+2
|