Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | pw_checkname since the beginning if too strict on GECOS field, | Baptiste Daroussin | 2015-12-02 | 1 | -1/+2 |
| | | | | | | | | | | | relax it a bit so gecos can be used to store multibytes data. This was unseen before FreeBSD 10.2 as this validation function was motly unused since FreeBSD 10.2 the usage of this function has been generalized to improve validation. Reported by: des MFC after: 1 week | ||||
* | Fix handling of numeric-only names with pw lock | Baptiste Daroussin | 2015-12-02 | 1 | -9/+12 |
| | | | | | | | Add a regression test about it PR: 204968 MFC after: 1 week | ||||
* | In pw_userlock, set 'name' to NULL when we encounter an all number string | Xin LI | 2015-10-30 | 1 | -2/+3 |
| | | | | | | | | because it is also used as an indicator of whether a name or an UID is being used and we may have undefined results as 'name' may contain uninitialized stack contents. MFC after: 2 weeks | ||||
* | Fix unlikely memory leak. | Bryan Drewery | 2015-10-29 | 1 | -1/+3 |
| | | | | | | | It is unlikely since the first check in the function is that dir[0] is '/', but later code changes may make it real. Coverity CID: 1332104 | ||||
* | Regression: fix usershow -7 | Baptiste Daroussin | 2015-09-14 | 1 | -1/+1 |
| | | | | | Submitted by: Dan McGregor (via IRC) MFC after: 2 days | ||||
* | Regression: fix pw usermod -d | Baptiste Daroussin | 2015-09-12 | 1 | -0/+1 |
| | | | | | | | | | Mark the user has having been edited if -d option is passed to usermod and so the request change of home directory actually happen PR: 203052 Reported by: lenzi.sergio@gmail.com MFC after: 2 days | ||||
* | Fix /home symlink creation | Baptiste Daroussin | 2015-08-21 | 1 | -1/+1 |
| | | | | Add regression test about it | ||||
* | Fix useradd regression: | Baptiste Daroussin | 2015-08-21 | 1 | -0/+66 |
| | | | | | | | | Readd the function to create the parents home directory if it does not exists. if it is only a directory at the top level of the hierarchy symlink it into /usr as it used to be done before. Reported by: kevlo, adrian | ||||
* | Regression: fix pw usermod -w xxx | Baptiste Daroussin | 2015-08-14 | 1 | -0/+2 |
| | | | | Reported by: gjb | ||||
* | Avoid calling strlen() where we can use the strspn() return value. | Ed Schouten | 2015-08-03 | 1 | -5/+5 |
| | |||||
* | Fix bugs spotted by gcc | Baptiste Daroussin | 2015-08-03 | 1 | -3/+4 |
| | | | | Reported by: adrian | ||||
* | Actually set quiet to something. | Adrian Chadd | 2015-08-03 | 1 | -1/+1 |
| | | | | | /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect | ||||
* | Split some extra long lines | Baptiste Daroussin | 2015-08-02 | 1 | -5/+10 |
| | |||||
* | Cleanup a bit includes | Baptiste Daroussin | 2015-08-02 | 1 | -10/+15 |
| | |||||
* | Fix regression: report again if a username already exists when creating it | Baptiste Daroussin | 2015-08-02 | 1 | -0/+3 |
| | |||||
* | Rewrite parsing subcommands arguments of pw(8) | Baptiste Daroussin | 2015-08-02 | 1 | -923/+1248 |
| | | | | | | | | | | | | | Now each subcommands checks its arguments in a dedicated functions. This helps improving input validation, code readability/maintainability While here: - Add a -y option to pw userdel/usermod so it can maintain NIS servers if nispasswd is not defined in pw.conf(5) - Allow pw -r <rootdir> to remove directory with userdel -r - Fix bug when renaming a user which was not renaming the user name it groups it is a member of. - Only parse pw.conf(5) when needed. | ||||
* | Partial revert of r286152 | Baptiste Daroussin | 2015-08-01 | 1 | -4/+4 |
| | | | | More work needed on the cli validation | ||||
* | Validate expiration days and password days from commmand line and pw.conf | Baptiste Daroussin | 2015-08-01 | 1 | -4/+4 |
| | |||||
* | Cast uid/git to uintmax_t when using printf-like functions so the size of | Baptiste Daroussin | 2015-08-01 | 1 | -16/+18 |
| | | | | uid/gid size remains a implementation detail | ||||
* | Reject usermod and userdel if the user concerned is not on the user database | Baptiste Daroussin | 2015-07-28 | 1 | -0/+19 |
| | | | | | | | | | | | | | supposed to be manipulated This prevent pw usermod creating a new local user when requesting to usermod on a username is defined in LDAP. This issue only happens when modifying the local user database (not inpacting commands when -V or -R are used). PR: 187653 Submitted by: tmwalaszek@gmail.com | ||||
* | Fix wrong warning printed after changing or updating NIS users | Baptiste Daroussin | 2015-07-28 | 1 | -2/+2 |
| | | | | | PR: 37672 Submitted by: chris+freebsd@chrullrich.de | ||||
* | Regression fix: allow to create users with uid0 | Baptiste Daroussin | 2015-07-13 | 1 | -1/+1 |
| | | | | Reported by: Jan Mikkelsen <janm@transactionware.com> | ||||
* | Ensure skeldir is abolute path (relatively to the rootdir) | Baptiste Daroussin | 2015-07-12 | 1 | -4/+10 |
| | |||||
* | pw -R <rootdir> userdel can now cleanup installation | Baptiste Daroussin | 2015-07-12 | 1 | -56/+50 |
| | | | | | | | Rewrite rm_r to use *at function, allowing to remove home directories along with users. only crontabs and at(1) installation are not removed Relnotes: yes | ||||
* | Rework the home directory creation and copy or the skel content to use *at | Baptiste Daroussin | 2015-07-12 | 1 | -9/+8 |
| | | | | | | | | | functions This allows to simplify the code a bit for -R by not having to keep modifying path and also prepare the code to improve support -R in userdel While here, add regression tests for the functionality | ||||
* | Make getarg return NULL if args is NULL | Baptiste Daroussin | 2015-07-12 | 1 | -4/+1 |
| | |||||
* | Fix regression: ensure when try to create the group and the user with the same | Baptiste Daroussin | 2015-07-11 | 1 | -12/+4 |
| | | | | id if possible and nothing in particular was specified | ||||
* | Replace custom string array with stringlist(3) | Baptiste Daroussin | 2015-07-11 | 1 | -10/+6 |
| | |||||
* | Remove unused argument from pm_passwd | Baptiste Daroussin | 2015-07-11 | 1 | -4/+4 |
| | |||||
* | check the gecos format early: at the moment the -c option is parsed | Baptiste Daroussin | 2015-07-11 | 1 | -4/+3 |
| | |||||
* | Remove useless use of goto | Baptiste Daroussin | 2015-07-11 | 1 | -4/+3 |
| | |||||
* | Isolate pw lock/unlock into a separate function | Baptiste Daroussin | 2015-07-11 | 1 | -44/+78 |
| | |||||
* | homedir can only be populate during useradd | Baptiste Daroussin | 2015-07-11 | 1 | -3/+3 |
| | |||||
* | Make a separate groupdel/userdel from the main function | Baptiste Daroussin | 2015-07-11 | 1 | -17/+31 |
| | |||||
* | Make separate functions to show users and groups | Baptiste Daroussin | 2015-07-11 | 1 | -17/+35 |
| | |||||
* | Move the quiet flag into the configuration structure | Baptiste Daroussin | 2015-07-11 | 1 | -1/+1 |
| | |||||
* | Separate usernext/groupnext from the main functions | Baptiste Daroussin | 2015-07-11 | 1 | -17/+17 |
| | |||||
* | Fix validation of crypted password | Baptiste Daroussin | 2015-07-04 | 1 | -7/+6 |
| | | | | Small cleanups | ||||
* | Validate input of pw usermod -h and pwusermod -H | Baptiste Daroussin | 2015-07-04 | 1 | -60/+63 |
| | | | | | | | Push the code that set the password into a separate function to improve readability Add regression tests about pw usermod -h and pw usermod -H | ||||
* | backout remove of -q option for pw [user|group] next | Baptiste Daroussin | 2015-06-08 | 1 | -3/+7 |
| | | | | | | While the return code is broken, some corner case usage depends on the functionnality, so backout until we get better regression tests covering those corner case usage. | ||||
* | Remove '-q' support for pw [user|group] next | Baptiste Daroussin | 2015-06-07 | 1 | -7/+3 |
| | | | | | | the intent of -q in this command is to return as exit status the value of the next group/user id, which does not make sense given exit status are limited to values between 0 and 255. | ||||
* | Fix generating configuration file | Baptiste Daroussin | 2015-06-07 | 1 | -4/+3 |
| | |||||
* | Fix duplicate checking | Baptiste Daroussin | 2015-06-07 | 1 | -10/+9 |
| | |||||
* | Remove uneeded code (already done by pw_make_v7) | Baptiste Daroussin | 2015-06-07 | 1 | -3/+0 |
| | |||||
* | In case of rename validate the length of the new name | Baptiste Daroussin | 2015-06-07 | 1 | -4/+4 |
| | | | | Check early that the new name fits MAXLOGNAME and store it in pwconf | ||||
* | Refactor input validation | Baptiste Daroussin | 2015-06-07 | 1 | -58/+37 |
| | | | | | Mutualize code to validate inputs of both 'user' and 'group' command Test that the input name fits into MAXLOGNAME | ||||
* | Finish converting -7 to pwconf | Baptiste Daroussin | 2015-06-07 | 1 | -4/+3 |
| | |||||
* | Handle -7 via gloval pwconf | Baptiste Daroussin | 2015-06-07 | 1 | -6/+5 |
| | |||||
* | Handle pretty print (-P) via global pwconf | Baptiste Daroussin | 2015-06-07 | 1 | -12/+6 |
| | |||||
* | Handle dryrun (-N) via global pwconf | Baptiste Daroussin | 2015-06-07 | 1 | -5/+3 |
| |