| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Reported by: imp
MFC after: 3 weeks
X-MFC-With: 318141, 318143
Sponsored by: Spectra Logic Corp
|
|
|
|
|
|
|
| |
Reported by: Coverity
CID: 1006715
MFC after: 3 weeks
Sponsored by: Spectra Logic Corp
|
|
|
|
|
|
|
|
|
|
| |
Also, respect "defaultgroup" if specified there.
PR: 217934
Reported by: Victor Sudakov <vas@mpeks.tomsk.su>
Reviewed by: bapt
Approved by: bapt, vsevolod (mentor)
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
It again reinstall missing skel files without overwriting changed one
Add a regression test about it
Reported by: ae
MFC after: 3 days
|
|
|
|
|
|
|
|
|
|
| |
pw usermod foo -m
It used to be able to (re)create the home directory if it didn't exists
PR: 216224
Reported by: ae
MFC after: 3 days
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, it will silently disable the login for the selected account if
the argument is unrecognizable.
usr.sbin/pw/pw.h
usr.sbin/pw/pw_conf.c
usr.sbin/pw/pw_user.c
Use separate rules to validate boolean parameters and passwd
parameters. Error out if a password parameter cannot be parsed.
usr.sbin/pw/tests/Makefile
usr.sbin/pw/tests/crypt.c
usr.sbin/pw/tests/pw_useradd.sh
usr.sbin/pw/tests/pw_usermod.sh
Add tests for the validation. Also, enhance existing
password-related tests to actually validate that the correct hash is
written to master.passwd.
Reviewed by: bapt
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D6840
|
|
|
|
|
| |
Reported by: Mike Selnet via forums.freebsd.org
MFC after: 3 days
|
|
|
|
| |
Found by 'include-what-you-use'
|
|
|
|
|
| |
MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
|
|
|
|
|
| |
relax it a bit so gecos can be used to store multibytes data.
This was unseen before FreeBSD 10.2 as this validation function was motly unused
since FreeBSD 10.2 the usage of this function has been generalized to improve
validation.
Reported by: des
MFC after: 1 week
|
|
|
|
|
|
|
| |
Add a regression test about it
PR: 204968
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
because it is also used as an indicator of whether a name or an UID is
being used and we may have undefined results as 'name' may contain
uninitialized stack contents.
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
It is unlikely since the first check in the function is that dir[0] is '/',
but later code changes may make it real.
Coverity CID: 1332104
|
|
|
|
|
| |
Submitted by: Dan McGregor (via IRC)
MFC after: 2 days
|
|
|
|
|
|
|
|
|
| |
Mark the user has having been edited if -d option is passed to usermod and
so the request change of home directory actually happen
PR: 203052
Reported by: lenzi.sergio@gmail.com
MFC after: 2 days
|
|
|
|
| |
Add regression test about it
|
|
|
|
|
|
|
|
| |
Readd the function to create the parents home directory if it does not exists.
if it is only a directory at the top level of the hierarchy symlink it into /usr
as it used to be done before.
Reported by: kevlo, adrian
|
|
|
|
| |
Reported by: gjb
|
| |
|
|
|
|
| |
Reported by: adrian
|
|
|
|
|
| |
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next':
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now each subcommands checks its arguments in a dedicated functions.
This helps improving input validation, code readability/maintainability
While here:
- Add a -y option to pw userdel/usermod so it can maintain NIS servers if
nispasswd is not defined in pw.conf(5)
- Allow pw -r <rootdir> to remove directory with userdel -r
- Fix bug when renaming a user which was not renaming the user name it groups
it is a member of.
- Only parse pw.conf(5) when needed.
|
|
|
|
| |
More work needed on the cli validation
|
| |
|
|
|
|
| |
uid/gid size remains a implementation detail
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supposed to be manipulated
This prevent pw usermod creating a new local user when requesting to usermod on
a username is defined in LDAP.
This issue only happens when modifying the local user database (not inpacting
commands when -V or -R are used).
PR: 187653
Submitted by: tmwalaszek@gmail.com
|
|
|
|
|
| |
PR: 37672
Submitted by: chris+freebsd@chrullrich.de
|
|
|
|
| |
Reported by: Jan Mikkelsen <janm@transactionware.com>
|
| |
|
|
|
|
|
|
|
| |
Rewrite rm_r to use *at function, allowing to remove home directories along with
users. only crontabs and at(1) installation are not removed
Relnotes: yes
|
|
|
|
|
|
|
|
|
| |
functions
This allows to simplify the code a bit for -R by not having to keep modifying
path and also prepare the code to improve support -R in userdel
While here, add regression tests for the functionality
|
| |
|
|
|
|
| |
id if possible and nothing in particular was specified
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Small cleanups
|
|
|
|
|
|
|
| |
Push the code that set the password into a separate function to improve
readability
Add regression tests about pw usermod -h and pw usermod -H
|
|
|
|
|
|
| |
While the return code is broken, some corner case usage depends on the
functionnality, so backout until we get better regression tests covering those
corner case usage.
|
|
|
|
|
|
| |
the intent of -q in this command is to return as exit status the value of the
next group/user id, which does not make sense given exit status are limited to
values between 0 and 255.
|