Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | pw_checkname since the beginning if too strict on GECOS field, | Baptiste Daroussin | 2015-12-02 | 1 | -1/+2 | |
| | | | | | | | | | | | relax it a bit so gecos can be used to store multibytes data. This was unseen before FreeBSD 10.2 as this validation function was motly unused since FreeBSD 10.2 the usage of this function has been generalized to improve validation. Reported by: des MFC after: 1 week | |||||
* | Fix handling of numeric-only names with pw lock | Baptiste Daroussin | 2015-12-02 | 1 | -9/+12 | |
| | | | | | | | Add a regression test about it PR: 204968 MFC after: 1 week | |||||
* | In pw_userlock, set 'name' to NULL when we encounter an all number string | Xin LI | 2015-10-30 | 1 | -2/+3 | |
| | | | | | | | | because it is also used as an indicator of whether a name or an UID is being used and we may have undefined results as 'name' may contain uninitialized stack contents. MFC after: 2 weeks | |||||
* | Fix unlikely memory leak. | Bryan Drewery | 2015-10-29 | 1 | -1/+3 | |
| | | | | | | | It is unlikely since the first check in the function is that dir[0] is '/', but later code changes may make it real. Coverity CID: 1332104 | |||||
* | Initialize `quiet` to false so `pw groupnext` again prints out the next gid | Enji Cooper | 2015-10-19 | 1 | -1/+1 | |
| | | | | | | | | | by default Reported by: Florian Degner <f.degner@gmx.de> MFC after: 1 week PR: 203876 Sponsored by: EMC / Isilon Storage Division | |||||
* | Fix a repeated typo: rootir -> rootdir. | Warren Block | 2015-10-09 | 1 | -11/+11 | |
| | | | | | Approved by: bapt MFC after: 1 week | |||||
* | Regression: fix usershow -7 | Baptiste Daroussin | 2015-09-14 | 1 | -1/+1 | |
| | | | | | Submitted by: Dan McGregor (via IRC) MFC after: 2 days | |||||
* | Regression: fix pw usermod -d | Baptiste Daroussin | 2015-09-12 | 1 | -0/+1 | |
| | | | | | | | | | Mark the user has having been edited if -d option is passed to usermod and so the request change of home directory actually happen PR: 203052 Reported by: lenzi.sergio@gmail.com MFC after: 2 days | |||||
* | Fix err pointer not initialized to NULL resulting | Baptiste Daroussin | 2015-08-21 | 1 | -0/+1 | |
| | | | | Reported by: "O. Hartmann" <ohartman@zedat.fu-berlin.de> | |||||
* | Fix /home symlink creation | Baptiste Daroussin | 2015-08-21 | 1 | -1/+1 | |
| | | | | Add regression test about it | |||||
* | Fix useradd regression: | Baptiste Daroussin | 2015-08-21 | 1 | -0/+66 | |
| | | | | | | | | Readd the function to create the parents home directory if it does not exists. if it is only a directory at the top level of the hierarchy symlink it into /usr as it used to be done before. Reported by: kevlo, adrian | |||||
* | Regression: fix pw usermod -w xxx | Baptiste Daroussin | 2015-08-14 | 1 | -0/+2 | |
| | | | | Reported by: gjb | |||||
* | Avoid calling strlen() where we can use the strspn() return value. | Ed Schouten | 2015-08-03 | 2 | -9/+9 | |
| | ||||||
* | Clarify pw(8) manual w/respect to required arguments. Break long lines at | Devin Teske | 2015-08-03 | 1 | -90/+118 | |
| | | | | | | | | | punctuation while here. Differential Revision: https://reviews.freebsd.org/D2700 Reviewed by: wblock, bapt MFC after: 3 days X-MFC-to: stable/10 | |||||
* | Fix bugs spotted by gcc | Baptiste Daroussin | 2015-08-03 | 1 | -3/+4 | |
| | | | | Reported by: adrian | |||||
* | Actually set quiet to something. | Adrian Chadd | 2015-08-03 | 1 | -1/+1 | |
| | | | | | /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect | |||||
* | Use intmax_t rather than long long | Baptiste Daroussin | 2015-08-02 | 1 | -2/+2 | |
| | ||||||
* | Fix build on 32bits | Baptiste Daroussin | 2015-08-02 | 1 | -2/+2 | |
| | ||||||
* | Split some extra long lines | Baptiste Daroussin | 2015-08-02 | 1 | -2/+4 | |
| | ||||||
* | Split some extra long lines | Baptiste Daroussin | 2015-08-02 | 1 | -5/+10 | |
| | ||||||
* | Cleanup a bit includes | Baptiste Daroussin | 2015-08-02 | 12 | -52/+43 | |
| | ||||||
* | Fix regression: report if a group already exists when creating it | Baptiste Daroussin | 2015-08-02 | 1 | -0/+2 | |
| | ||||||
* | Fix regression: report again if a username already exists when creating it | Baptiste Daroussin | 2015-08-02 | 1 | -0/+3 | |
| | ||||||
* | Remove dead code | Baptiste Daroussin | 2015-08-02 | 1 | -11/+0 | |
| | ||||||
* | Rewrite parsing subcommands arguments of pw(8) | Baptiste Daroussin | 2015-08-02 | 10 | -1482/+1951 | |
| | | | | | | | | | | | | | Now each subcommands checks its arguments in a dedicated functions. This helps improving input validation, code readability/maintainability While here: - Add a -y option to pw userdel/usermod so it can maintain NIS servers if nispasswd is not defined in pw.conf(5) - Allow pw -r <rootdir> to remove directory with userdel -r - Fix bug when renaming a user which was not renaming the user name it groups it is a member of. - Only parse pw.conf(5) when needed. | |||||
* | Remove things that crept in after badly checked revert | Baptiste Daroussin | 2015-08-01 | 1 | -2/+0 | |
| | ||||||
* | Partial revert of r286152 | Baptiste Daroussin | 2015-08-01 | 4 | -16/+6 | |
| | | | | More work needed on the cli validation | |||||
* | Fix build | Baptiste Daroussin | 2015-08-01 | 1 | -0/+1 | |
| | ||||||
* | Fix formatting of new code | Baptiste Daroussin | 2015-08-01 | 1 | -20/+26 | |
| | | | | | | | Fix sorting or errstr Remove useless initialisation or errstr Reported by: bde | |||||
* | Validate expiration days and password days from commmand line and pw.conf | Baptiste Daroussin | 2015-08-01 | 4 | -8/+28 | |
| | ||||||
* | Validate the max_uid/max_gid boundaries and entry type in pw.conf | Baptiste Daroussin | 2015-08-01 | 1 | -7/+23 | |
| | ||||||
* | Cast uid/git to uintmax_t when using printf-like functions so the size of | Baptiste Daroussin | 2015-08-01 | 3 | -23/+27 | |
| | | | | uid/gid size remains a implementation detail | |||||
* | Improve strtounum | Baptiste Daroussin | 2015-07-30 | 2 | -24/+21 | |
| | | | | | | | | | Fix many style bugs Better variable naming Use C99 'restrict' were apropriate Fix potential errno race Submitted by: bde | |||||
* | Cleanup includes | Baptiste Daroussin | 2015-07-29 | 1 | -6/+3 | |
| | ||||||
* | Actually set the proper license | Baptiste Daroussin | 2015-07-29 | 1 | -12/+13 | |
| | | | | Reported by: trasz | |||||
* | Actually add the new code | Baptiste Daroussin | 2015-07-29 | 1 | -0/+73 | |
| | ||||||
* | Create a strtounum function using the same API as strtonum | Baptiste Daroussin | 2015-07-29 | 3 | -4/+8 | |
| | | | | | This function returns uintmax_t Use this function to convert to gid_t/uid_t | |||||
* | Reject usermod and userdel if the user concerned is not on the user database | Baptiste Daroussin | 2015-07-28 | 1 | -0/+19 | |
| | | | | | | | | | | | | | supposed to be manipulated This prevent pw usermod creating a new local user when requesting to usermod on a username is defined in LDAP. This issue only happens when modifying the local user database (not inpacting commands when -V or -R are used). PR: 187653 Submitted by: tmwalaszek@gmail.com | |||||
* | Check uid/gid used when creating a user/group are not larger than ↵ | Baptiste Daroussin | 2015-07-28 | 1 | -2/+2 | |
| | | | | | | | UID_MAX/GID_MAX PR: 173977 Reported by: nvass@gmx.com | |||||
* | Fix wrong warning printed after changing or updating NIS users | Baptiste Daroussin | 2015-07-28 | 1 | -2/+2 | |
| | | | | | PR: 37672 Submitted by: chris+freebsd@chrullrich.de | |||||
* | when -n is passed to any pw subcommand it is always expected to be considered as | Baptiste Daroussin | 2015-07-28 | 1 | -8/+1 | |
| | | | | | | | | a name so do not try to convert it to an id if it is a numeric value PR: 31933 Reported by: ted@impulse.net Sponsored by: gandi.net | |||||
* | Really fix -o | Baptiste Daroussin | 2015-07-13 | 1 | -1/+1 | |
| | ||||||
* | Regression fix: allow to create users with uid0 | Baptiste Daroussin | 2015-07-13 | 1 | -1/+1 | |
| | | | | Reported by: Jan Mikkelsen <janm@transactionware.com> | |||||
* | Fix logic of check duplicates that has been inverted | Baptiste Daroussin | 2015-07-13 | 1 | -1/+2 | |
| | ||||||
* | Ensure skeldir is abolute path (relatively to the rootdir) | Baptiste Daroussin | 2015-07-12 | 1 | -4/+10 | |
| | ||||||
* | pw -R <rootdir> userdel can now cleanup installation | Baptiste Daroussin | 2015-07-12 | 3 | -84/+76 | |
| | | | | | | | Rewrite rm_r to use *at function, allowing to remove home directories along with users. only crontabs and at(1) installation are not removed Relnotes: yes | |||||
* | Rework the home directory creation and copy or the skel content to use *at | Baptiste Daroussin | 2015-07-12 | 4 | -87/+90 | |
| | | | | | | | | | functions This allows to simplify the code a bit for -R by not having to keep modifying path and also prepare the code to improve support -R in userdel While here, add regression tests for the functionality | |||||
* | Make getarg return NULL if args is NULL | Baptiste Daroussin | 2015-07-12 | 2 | -5/+7 | |
| | ||||||
* | Fix regression: ensure when try to create the group and the user with the same | Baptiste Daroussin | 2015-07-11 | 1 | -12/+4 | |
| | | | | id if possible and nothing in particular was specified | |||||
* | Remove now unused variable | Baptiste Daroussin | 2015-07-11 | 1 | -3/+0 | |
| |