Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Improve readability by reducing indentations levels | Baptiste Daroussin | 2015-06-07 | 1 | -9/+11 |
| | |||||
* | Remove one level of indentation | Baptiste Daroussin | 2015-06-07 | 1 | -7/+6 |
| | |||||
* | Move user deletion code into a separate function to improve readability | Baptiste Daroussin | 2015-06-07 | 1 | -106/+115 |
| | |||||
* | Instead of always casting the pw_checkname input to u_char * and casting it back | Baptiste Daroussin | 2015-06-07 | 3 | -11/+12 |
| | | | | to char *, change pw_checkname to directly take char * in input | ||||
* | Document pw(8) '-R' option, added in r283961. | Glen Barber | 2015-06-03 | 1 | -1/+20 |
| | | | | | | MFC after: 1 week X-MFC-after: r283961 Sponsored by: The FreeBSD Foundation | ||||
* | New pw -R rootdir option | Baptiste Daroussin | 2015-06-03 | 3 | -38/+89 |
| | | | | | | | | This allows to set an alternate root directory in which the users/groups will be manipulated Requested by: gjb, ian Tested by: gjb | ||||
* | Cast to gid_t for groups not uid_t | Baptiste Daroussin | 2015-05-31 | 1 | -1/+1 |
| | |||||
* | Remove useless cast in printf and printf-like functions: | Baptiste Daroussin | 2015-05-31 | 3 | -23/+23 |
| | | | | use %u for uid_t and gid_t | ||||
* | Cast -1 to uid_t and bump WARNING level to 3 | Baptiste Daroussin | 2015-05-31 | 3 | -4/+4 |
| | |||||
* | Move cleanup functions to the right place | Baptiste Daroussin | 2015-05-31 | 1 | -2/+3 |
| | |||||
* | Remove useless test before free() | Baptiste Daroussin | 2015-05-31 | 1 | -2/+1 |
| | |||||
* | Return early in case we cannot read the configuration file | Baptiste Daroussin | 2015-05-31 | 1 | -110/+111 |
| | | | | This drops one level of indentation | ||||
* | Make pw_user()/pw_group() more consitent about errors | Baptiste Daroussin | 2015-05-31 | 2 | -37/+24 |
| | | | | | | | | Some of errors were returned to the main function, some others caused a direct exit via err(3). The main function is only interested in EXIT_SUCCESS, so in all other cases replace warn(3) + return err by err(3) | ||||
* | Remove uneeded intermediate variable | Baptiste Daroussin | 2015-05-31 | 1 | -4/+1 |
| | |||||
* | Remove uneeded intermediate variable | Baptiste Daroussin | 2015-05-31 | 1 | -4/+1 |
| | |||||
* | Use asprintf instead of malloc + snprintf and test the memory allocation | Baptiste Daroussin | 2015-05-31 | 1 | -2/+3 |
| | |||||
* | Remove dead declaration | Baptiste Daroussin | 2015-05-29 | 1 | -1/+0 |
| | | | | | PR: 195928 MFC after: 2 days | ||||
* | Remove extendline definition | Baptiste Daroussin | 2015-05-10 | 1 | -3/+0 |
| | | | | Remove now unused PWBUFSZ define | ||||
* | Use calloc(3) instead of malloc(3) + memset(3) | Baptiste Daroussin | 2015-05-10 | 1 | -2/+4 |
| | | | | While here check the return of calloc(3) | ||||
* | The initial logic for allocating the new string was wrong, the conversion | Baptiste Daroussin | 2015-05-10 | 1 | -5/+2 |
| | | | | | to strndup(3) duplicated the same mistake, actually strdup(3) is good enough to allocate the new string. | ||||
* | Use strndup(3) instead of malloc(3) + memcpy(3) | Baptiste Daroussin | 2015-05-10 | 1 | -7/+11 |
| | | | | Check the return of strndup | ||||
* | Remove useless call to extendarray | Baptiste Daroussin | 2015-05-10 | 1 | -1/+0 |
| | |||||
* | The pwdb function is only used once to check the database rename it | Baptiste Daroussin | 2015-05-10 | 1 | -10/+4 |
| | | | | pwdb_check and simplify it accordingly | ||||
* | if the check of the pw db fails return the failed value | Baptiste Daroussin | 2015-05-10 | 1 | -37/+35 |
| | |||||
* | Some style(9) fixes | Baptiste Daroussin | 2015-05-10 | 1 | -9/+16 |
| | |||||
* | Replace sprintf(3) with snprintf(3) | Baptiste Daroussin | 2015-05-09 | 1 | -7/+7 |
| | |||||
* | Use snprintf(3) instead of sprintf(3) | Baptiste Daroussin | 2015-05-09 | 1 | -8/+7 |
| | | | | Remove useless "else" | ||||
* | Remove now unused LNBUFSZ buffer size | Baptiste Daroussin | 2015-05-09 | 1 | -3/+0 |
| | |||||
* | Return from the function as early as possible | Baptiste Daroussin | 2015-05-09 | 1 | -117/+116 |
| | | | | This reduces the depth of the if statements and improves clarity of the code | ||||
* | Remove some uneeded headers | Baptiste Daroussin | 2015-05-09 | 3 | -8/+0 |
| | |||||
* | Remove unneeded headers | Baptiste Daroussin | 2015-05-09 | 1 | -8/+0 |
| | |||||
* | Replace malloc(3) + strcpy(3) + strcat(3) by asprintf(3) | Baptiste Daroussin | 2015-05-09 | 1 | -3/+1 |
| | |||||
* | Use snprintf(3) instead of strcpy(3) + strncat(3) | Baptiste Daroussin | 2015-05-09 | 1 | -2/+1 |
| | |||||
* | Use sbuf(9) instead of homebrewed buffered string | Baptiste Daroussin | 2015-05-09 | 3 | -62/+47 |
| | |||||
* | Revert r277652 | Baptiste Daroussin | 2015-01-26 | 2 | -9/+2 |
| | | | | | | uid and gid are never and should never be negative. The pw(8) manpage clearly states the -u and -g arguments are for uids/gids, hence using negative values is abusing a bug in former versions of pw(8) | ||||
* | Allow negative numbers in -u and -g options | Baptiste Daroussin | 2015-01-24 | 2 | -2/+9 |
| | | | | | PR: 196514 MFC after: 1 week | ||||
* | Convert to LIBADD. | Brad Davis | 2014-11-24 | 1 | -2/+1 |
| | | | | Reviewed by: bapt | ||||
* | Fix wrong message when using pw -V with a non existent directory | Baptiste Daroussin | 2014-11-12 | 1 | -0/+8 |
| | | | | | | | Add a regression test about it PR: 194971 Submitted by: Freddy DISSAUX <bugzilla@dsx.bsdsx.fr> | ||||
* | Ensure pw userdel -u <invalid> do not try to remove root | Baptiste Daroussin | 2014-10-28 | 1 | -0/+3 |
| | | | | | | Check the uid passed is actually a number as early as possible MFC after: 1 week | ||||
* | Do not delete the group wheel when bad argument is passed to pw groupdel -g | Baptiste Daroussin | 2014-10-28 | 1 | -0/+5 |
| | | | | | | | | | | | | Check that the -g argument is actually a number, if not report an error. This argument is converted without checking with atoi(3) later so without this check it converts any alpha entries into 0 meaning it deletes the group wheel Add a regression test about it PR: 90114 Reported by: bkoenig@cs.tu-berlin.de MFC after: 1 week | ||||
* | Fix a regression in pw usermod -G list | Baptiste Daroussin | 2014-10-28 | 1 | -1/+19 |
| | | | | | | | | | | The user was perperly adding the to different groups from "list" but was not removed from the other groups it could have belong to. While here add a regression test about this bug PR: 185666 Reported by: sub.mesa@gmail.com MFC after: 1 week | ||||
* | When a group is renamed then the group has been invalidated for sure. | Baptiste Daroussin | 2014-10-28 | 1 | -3/+6 |
| | | | | | | | | | In that case get the group information using the new name. Add a regression test about this bug PR: 193704 Reported by: az | ||||
* | Two more places where login_setcryptfmt() defaults to MD5 were missed | Dag-Erling Smørgrav | 2014-10-09 | 1 | -2/+2 |
| | | | | | | in r252688. MFC after: 3 days | ||||
* | - Add a test for bug 191427 where pw(8) will go into an infinite loop | Brad Davis | 2014-10-02 | 1 | -0/+6 |
| | | | | | Reviewed by: will MFC after: 1 month | ||||
* | pw: fix up deletion of users from groups | Mateusz Guzik | 2014-06-27 | 1 | -4/+3 |
| | | | | | | | | | Previuosly given 'foo,bar' members, removing 'foo' would result in an infinite loop. PR: 191427 Submitted by: Voradesh Yenbut <yenbut cs.washington.edu> MFC after: 1 week | ||||
* | Fix changing the username | Baptiste Daroussin | 2014-06-20 | 1 | -1/+1 |
| | | | | | | PR: 189172 Submitted by: fullermd@over-yonder.net MFC after: 1 week | ||||
* | Removed compatibility with pre FreeBSD 2.2 pw_mkdb command | Baptiste Daroussin | 2014-06-20 | 1 | -13/+2 |
| | | | | | | | | Fix some broken indentattion PR: 189173 Submitted by: fullermd@over-yonder.net MFC after: 1 week | ||||
* | Simplify reading pw.conf(5) by using getline(3) | Baptiste Daroussin | 2014-04-22 | 2 | -0/+504 |
| | |||||
* | Fix pw(8) deletion of group "username" on userdel even if group "username" | Devin Teske | 2014-03-13 | 1 | -1/+9 |
| | | | | | | | | | | | | is not associated with user "username". E.g., user "foo" has primary group "wheel" and is unassociated with group "foo", yet userdel would delete the group "foo" when deleting user "foo" (despite the fact that user "foo" is not associated with group "foo" in any way). Patch committed with minor style(9) changes. PR: bin/169471 Submitted by: Alexander Pyhalov <apyhalov@gmail.com> | ||||
* | Part 2 of bug 187310.. had to commit separately due to local confusion. | Julian Elischer | 2014-03-06 | 1 | -15/+21 |
| | | | | | | | | Don't let pw crash when give certain input. PR: 187310 Submitted by: Kim Shrier MFC after: 1 week |