From ee6068b5a7f0eefa3967019282f9bd398d9a1e19 Mon Sep 17 00:00:00 2001 From: Yaroslav Tykhiy Date: Mon, 28 Jan 2002 17:59:09 +0000 Subject: Keep similar things together: Check for too long usernames inside the function that verifies username validity. --- adduser/adduser.perl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/adduser/adduser.perl b/adduser/adduser.perl index 2aa9c31..322bac6 100644 --- a/adduser/adduser.perl +++ b/adduser/adduser.perl @@ -317,10 +317,6 @@ sub new_users_name { while(1) { $name = &confirm_list("Enter username", 1, $usernameregexp, ""); - if (length($name) > 16) { - warn "Username is longer than 16 chars\a\n"; - next; - } last if (&new_users_name_valid($name)); } return $name; @@ -332,6 +328,9 @@ sub new_users_name_valid { if ($name eq $usernameregexp) { # user/admin just pressed warn "Please enter a username\a\n"; return 0; + } elsif (length($name) > 16) { + warn "Username is longer than 16 characters.\a\n"; + return 0; } elsif ($name =~ /[:\n]/) { warn "Username cannot contain colon or newline characters.\a\n"; return 0; -- cgit v1.2.3-56-ge451