From 59fd6541b608c1f683af5af0e09dd8d600622ac3 Mon Sep 17 00:00:00 2001 From: Peter Pentchev Date: Thu, 23 Sep 2004 13:09:42 +0000 Subject: In fullpath_from_shell(), move the nologin detection before the cat | while loop to avoid an incorrect display of the nologin path twice. PR: 71786 Submitted by: Andrew Hayden Reviewed by: mtm MFC after: 3 days --- adduser/adduser.sh | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'adduser/adduser.sh') diff --git a/adduser/adduser.sh b/adduser/adduser.sh index 050f2b1..0014e4c 100644 --- a/adduser/adduser.sh +++ b/adduser/adduser.sh @@ -126,6 +126,17 @@ fullpath_from_shell() { _shell=$1 [ -z "$_shell" ] && return 1 + # /usr/sbin/nologin is a special case; it needs to be handled + # before the cat | while loop, since a 'return' from within + # a subshell will not terminate the function's execution, and + # the path to the nologin shell might be printed out twice. + # + if [ "$_shell" = "${NOLOGIN}" -o \ + "$_shell" = "${NOLOGIN_PATH}" ]; then + echo ${NOLOGIN_PATH} + return 0; + fi + cat ${ETCSHELLS} | while read _path _junk ; do case "$_path" in @@ -141,13 +152,6 @@ fullpath_from_shell() { esac done - # /usr/sbin/nologin is a special case - if [ "$_shell" = "${NOLOGIN}" -o \ - "$_shell" = "${NOLOGIN_PATH}" ]; then - echo ${NOLOGIN_PATH} - return 0; - fi - return 1 } -- cgit v1.2.3-56-ge451