From 80285e3e194993731e573e5ffa1eba819e283ddd Mon Sep 17 00:00:00 2001 From: Alan Somers Date: Wed, 13 Jul 2016 17:09:20 +0000 Subject: pw should sanitize the argument of -w. Otherwise, it will silently disable the login for the selected account if the argument is unrecognizable. usr.sbin/pw/pw.h usr.sbin/pw/pw_conf.c usr.sbin/pw/pw_user.c Use separate rules to validate boolean parameters and passwd parameters. Error out if a password parameter cannot be parsed. usr.sbin/pw/tests/Makefile usr.sbin/pw/tests/crypt.c usr.sbin/pw/tests/pw_useradd.sh usr.sbin/pw/tests/pw_usermod.sh Add tests for the validation. Also, enhance existing password-related tests to actually validate that the correct hash is written to master.passwd. Reviewed by: bapt MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D6840 --- pw/tests/Makefile | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'pw/tests/Makefile') diff --git a/pw/tests/Makefile b/pw/tests/Makefile index 1c69d50..1ae14f3 100644 --- a/pw/tests/Makefile +++ b/pw/tests/Makefile @@ -2,6 +2,11 @@ PACKAGE= tests +BINDIR= ${TESTSDIR} + +PROGS+= crypt +LIBADD+= crypt + ATF_TESTS_SH= pw_etcdir \ pw_lock \ pw_config \ -- cgit v1.2.3-56-ge451