From adfec1630313d82cd79f0d7a2ecefc14629fd610 Mon Sep 17 00:00:00 2001 From: Ed Maste Date: Sat, 19 Aug 2017 00:19:23 +0000 Subject: pw usermod: Properly deal with empty secondary group lists (-G '') "pw usermod someuser -G ''" is supposed make sure that someuser doesn't have any secondary group memberships. Previouly it was a nop because split_groups() only intitialised "groups" if at least one group was specified. As a result the existing secondary group memberships were kept. PR: 221417 Submitted by: Fabian Keil Obtained from: ElectroBSD MFC after: 1 week Relnotes: yes --- pw/tests/pw_usermod_test.sh | 3 +++ 1 file changed, 3 insertions(+) (limited to 'pw/tests') diff --git a/pw/tests/pw_usermod_test.sh b/pw/tests/pw_usermod_test.sh index 6a13130..cf3622f 100755 --- a/pw/tests/pw_usermod_test.sh +++ b/pw/tests/pw_usermod_test.sh @@ -128,6 +128,9 @@ user_mod_nogroups_body() { atf_check -s exit:0 ${PW} usermod foo -G test3,test4 atf_check -s exit:0 -o inline:"test3\ntest4\n" \ awk -F\: '$4 == "foo" { print $1 }' ${HOME}/group + atf_check -s exit:0 ${PW} usermod foo -G "" + atf_check -s exit:0 -o empty \ + awk -F\: '$4 == "foo" { print $1 }' ${HOME}/group } atf_test_case user_mod_rename -- cgit v1.2.3-56-ge451