avoid uninit memory and use memmove vs strncpy for a will be

truncated on purpose string.

diff --git a/tetris/scores.c b/tetris/scores.c
index 04424cb43e1afd59a2447c5f20d5db32b2c0008a..1335df7ba18c8162074b67e6b376d16df77edbb6 100644 (file)
--- a/tetris/scores.c
+++ b/tetris/scores.c
@@ -1,4 +1,4 @@
-/*     $NetBSD: scores.c,v 1.24 2018/06/24 12:55:36 mrg Exp $  */
+/*     $NetBSD: scores.c,v 1.25 2020/09/07 00:31:11 mrg Exp $  */

 
 /*-
  * Copyright (c) 1992, 1993
 
 /*-
  * Copyright (c) 1992, 1993


@@ -599,7 +599,7 @@ putscores(int sd)
 {
 #ifdef ALLOW_SCORE_UPDATES
        struct highscore_header header;
 {
 #ifdef ALLOW_SCORE_UPDATES
        struct highscore_header header;

-       struct highscore_ondisk buf[MAXHISCORES];
+       struct highscore_ondisk buf[MAXHISCORES] = {0};

        int i;
 
        if (sd == -1) {
        int i;
 
        if (sd == -1) {


@@ -611,7 +611,7 @@ putscores(int sd)
        header.hsh_version = HSH_VERSION;
 
        for (i=0; i<nscores; i++) {
        header.hsh_version = HSH_VERSION;
 
        for (i=0; i<nscores; i++) {

-               strncpy(buf[i].hso_name, scores[i].hs_name,
+               memcpy(buf[i].hso_name, scores[i].hs_name,

                        sizeof(buf[i].hso_name));
                buf[i].hso_score = scores[i].hs_score;
                buf[i].hso_level = scores[i].hs_level;
                        sizeof(buf[i].hso_name));
                buf[i].hso_score = scores[i].hs_score;
                buf[i].hso_level = scores[i].hs_level;