summaryrefslogtreecommitdiffstats
path: root/atc/extern.h
diff options
context:
space:
mode:
authorhubertf <hubertf@NetBSD.org>1999-07-17 19:57:03 +0000
committerhubertf <hubertf@NetBSD.org>1999-07-17 19:57:03 +0000
commit3809a8fdebc7087514443871f875d64c9e24e447 (patch)
tree0418f6d2f091389108a0620a5d5194a1def8d50d /atc/extern.h
parentfd34b018820af4ff065b05d39c0d53a362fb2783 (diff)
downloadbsdgames-darwin-3809a8fdebc7087514443871f875d64c9e24e447.tar.gz
bsdgames-darwin-3809a8fdebc7087514443871f875d64c9e24e447.tar.zst
bsdgames-darwin-3809a8fdebc7087514443871f875d64c9e24e447.zip
The patch below improves the security of the game atc(6), by having it
open the score file at the start and then drop all setgid privileges while keeping a (close-on-exec) file descriptor open to it. In order to allow this the static data files have to be made world readable. In addition a potential buffer overrun with corrupted score files is avoided by more careful use of scanf (note that SCORE_SCANF_FMT is defined alongside the definition of the relevant structure). Submitted in PR 8015 by Joseph Myers <jsm28@cam.ac.uk>
Diffstat (limited to 'atc/extern.h')
-rw-r--r--atc/extern.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/atc/extern.h b/atc/extern.h
index 802ae9b2..7931c3ec 100644
--- a/atc/extern.h
+++ b/atc/extern.h
@@ -1,4 +1,4 @@
-/* $NetBSD: extern.h,v 1.7 1998/11/10 13:43:30 hubertf Exp $ */
+/* $NetBSD: extern.h,v 1.8 1999/07/17 19:57:03 hubertf Exp $ */
/*-
* Copyright (c) 1990, 1993
@@ -97,6 +97,7 @@ char name __P((const PLANE *));
int next_plane __P((void));
void noise __P((void));
int number __P((char));
+void open_score_file __P((void));
void planewin __P((void));
int pop __P((void));
void push __P((int, int));