summaryrefslogtreecommitdiffstats
path: root/rogue/rogue.h
diff options
context:
space:
mode:
authorjsm <jsm@NetBSD.org>1999-09-12 09:02:20 +0000
committerjsm <jsm@NetBSD.org>1999-09-12 09:02:20 +0000
commit2f593094f0c4f828fd81a3b052ee426135135694 (patch)
tree7b98927c7e61fffdc04daa44d0d99f2316fa1a47 /rogue/rogue.h
parentb8724a0a95054da51b0a8bfca19d6d2b2662609f (diff)
downloadbsdgames-darwin-2f593094f0c4f828fd81a3b052ee426135135694.tar.gz
bsdgames-darwin-2f593094f0c4f828fd81a3b052ee426135135694.tar.zst
bsdgames-darwin-2f593094f0c4f828fd81a3b052ee426135135694.zip
Security improvements for games (largely from or inspired by OpenBSD).
Games which run setgid from dm, but don't need to, should drop their privileges at startup. Games which have a scorefile should open it at startup, then drop all privileges leaving just the open writable file descriptor. If the game can invoke subprocesses, this should be made close-on-exec. Games with scorefiles should make sure they do not get a file descriptor < 3. (Otherwise, they could get confused and corrupt the scorefile when using stdin, stdout or stderr.) Some old setuid revokes from the days of setuid games change into gid revokes.
Diffstat (limited to 'rogue/rogue.h')
-rw-r--r--rogue/rogue.h6
1 files changed, 5 insertions, 1 deletions
diff --git a/rogue/rogue.h b/rogue/rogue.h
index 92d49c09..0bf1e105 100644
--- a/rogue/rogue.h
+++ b/rogue/rogue.h
@@ -1,4 +1,4 @@
-/* $NetBSD: rogue.h,v 1.9 1999/09/08 21:45:30 jsm Exp $ */
+/* $NetBSD: rogue.h,v 1.10 1999/09/12 09:02:23 jsm Exp $ */
/*
* Copyright (c) 1988, 1993
@@ -457,6 +457,8 @@ extern char *CL;
*/
#include <stdio.h>
#include <string.h>
+#include <sys/types.h>
+#include <unistd.h>
object *alloc_object __P((void));
object *check_duplicate __P((object *, object *));
@@ -817,3 +819,5 @@ extern short r_rings;
extern short regeneration;
extern short ring_exp;
extern short stealthy;
+extern gid_t gid;
+extern gid_t egid;