]> git.cameronkatri.com Git - cgit.git/commitdiff
ui-snapshot: filter permitted snapshot requests
authorJohn Keeping <john@keeping.me.uk>
Sat, 31 Mar 2018 14:19:52 +0000 (15:19 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Wed, 27 Jun 2018 16:11:19 +0000 (18:11 +0200)
Currently the snapshots configuration option only filters which links
are displayed, not which snapshots may be generated and downloaded.
Apply the filter also to requests to ensure that the system policy is
enforced.

Signed-off-by: John Keeping <john@keeping.me.uk>
Reviewed-by: Christian Hesse <mail@eworm.de>
ui-snapshot.c

index b9e2a36f9dd57a475c364437c7de82d487986565..abf83995011075db6668810a8df3da993fc109d5 100644 (file)
@@ -194,7 +194,7 @@ void cgit_print_snapshot(const char *head, const char *hex,
        }
 
        f = get_format(filename);
-       if (!f) {
+       if (!f || !(ctx.repo->snapshots & f->bit)) {
                cgit_print_error_page(400, "Bad request",
                                "Unsupported snapshot format: %s", filename);
                return;