]> git.cameronkatri.com Git - cgit.git/commitdiff
cgit_print_snapshot_links(): Free prefix variable
authorLukas Fleischer <cgit@cryptocrack.de>
Mon, 4 Mar 2013 12:25:38 +0000 (13:25 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Tue, 5 Mar 2013 01:47:54 +0000 (20:47 -0500)
Fixes following memory leak seen with "PATH_INFO=/cgit/commit/":

    ==16894== 12 bytes in 1 blocks are definitely lost in loss record 9 of 92
    ==16894==    at 0x4C2C04B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==16894==    by 0x56F2DF1: strdup (in /usr/lib/libc-2.17.so)
    ==16894==    by 0x46CAC8: xstrdup (wrapper.c:35)
    ==16894==    by 0x414E34: cgit_print_snapshot_links (ui-shared.c:926)
    ==16894==    by 0x40CFA1: cgit_print_commit (ui-commit.c:102)
    ==16894==    by 0x407B06: commit_fn (cmd.c:54)
    ==16894==    by 0x405E16: process_request (cgit.c:574)
    ==16894==    by 0x4074C8: cache_process (cache.c:322)
    ==16894==    by 0x406C4F: main (cgit.c:872)

Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
ui-shared.c

index 77a302d0c5bba8a54c29a6551b15cea6f02c9205..d3e64882109a2d0ef2408ca55aeebf4d0d1922d8 100644 (file)
@@ -931,4 +931,5 @@ void cgit_print_snapshot_links(const char *repo, const char *head,
                cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename);
                html("<br/>");
        }
+       free(prefix);
 }