]> git.cameronkatri.com Git - cgit.git/commitdiff
diffstat: do not rely on uninitialized data
authorJason A. Donenfeld <Jason@zx2c4.com>
Thu, 20 Feb 2014 18:48:24 +0000 (19:48 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Thu, 20 Feb 2014 18:48:24 +0000 (19:48 +0100)
Right now if you visit:
<http://git.zx2c4.com/systemd/diff/src/udev/udev-builtin-input_id.c?id=bcfce235>
you'll see that if you reload the page a few times, a bunch of times the
diffstat comes out with no lines being shown or changed. I'm not
currently sure what the cause of this is, but I suspect it might have to
do with this uninitialized data.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
shared.c

index 7e88bbd4fb33555066d14df98402277a97e96bee..8ed14c0bdbcbf378dd2adc439e21f5895b6e4ac9 100644 (file)
--- a/shared.c
+++ b/shared.c
@@ -368,6 +368,7 @@ void cgit_diff_tree(const unsigned char *old_sha1,
        struct diff_options opt;
        struct pathspec_item item;
 
+       memset(&item, 0, sizeof(item));
        diff_setup(&opt);
        opt.output_format = DIFF_FORMAT_CALLBACK;
        opt.detect_rename = 1;