Specify static storage class for file-local declarations

Also fix some whitespace issues while at it.

Noticed by Kristian Høgsberg <krh@bitplanet.net>

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

diff --git a/ui-commit.c b/ui-commit.c
index 20a7cb2259d978c72dab0084c1f4dd091c857176..b6a106fb0681a9e93638787f54443dff93dc17f8 100644 (file)
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -8,11 +8,11 @@
 
 #include "cgit.h"
 
-int files = 0, slots = 0;
-int total_adds = 0, total_rems = 0, max_changes = 0;
-int lines_added, lines_removed;
+static int files, slots;
+static int total_adds, total_rems, max_changes;
+static int lines_added, lines_removed;
 
-struct fileinfo {
+static struct fileinfo {
        char status;
        unsigned char old_sha1[20];
        unsigned char new_sha1[20];

diff --git a/ui-summary.c b/ui-summary.c
index 9388f5fbf69c3df2f12d30f871d79509107b4a84..f6120f92c365dec331629075e4ec36f074c1f737 100644 (file)
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -8,7 +8,7 @@
 
 #include "cgit.h"
 
-int items = 0;
+static int items;
 
 static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1,
                                int flags, void *cb_data)
@@ -22,7 +22,7 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1,
        if (commit && !parse_commit(commit)){
                info = cgit_parse_commit(commit);
                html("<tr><td>");
-               url = cgit_pageurl(cgit_query_repo, "log", 
+               url = cgit_pageurl(cgit_query_repo, "log",
                                   fmt("h=%s", refname));
                html_link_open(url, NULL, NULL);
                html_txt(buf);
@@ -32,7 +32,7 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1,
                html("</td><td>");
                html_txt(info->author);
                html("</td><td>");
-               url = cgit_pageurl(cgit_query_repo, "commit", 
+               url = cgit_pageurl(cgit_query_repo, "commit",
                                   fmt("id=%s", sha1_to_hex(sha1)));
                html_link_open(url, NULL, NULL);
                html_ntxt(cgit_max_msg_len, info->subject);
@@ -61,10 +61,10 @@ static void cgit_print_object_ref(struct object *obj)
        else
                page = "view";
 
-       url = cgit_pageurl(cgit_query_repo, page, 
+       url = cgit_pageurl(cgit_query_repo, page,
                           fmt("id=%s", sha1_to_hex(obj->sha1)));
        html_link_open(url, NULL, NULL);
-       htmlf("%s %s", typename(obj->type), 
+       htmlf("%s %s", typename(obj->type),
              sha1_to_hex(obj->sha1));
        html_link_close();
 }
@@ -76,7 +76,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1,
        struct taginfo *info;
        struct object *obj;
        char buf[256], *url;
- 
+
        strncpy(buf, refname, sizeof(buf));
        obj = parse_object(sha1);
        if (!obj)
@@ -93,7 +93,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1,
                }
                items++;
                html("<tr><td>");
-               url = cgit_pageurl(cgit_query_repo, "view", 
+               url = cgit_pageurl(cgit_query_repo, "view",
                                   fmt("id=%s", sha1_to_hex(sha1)));
                html_link_open(url, NULL, NULL);
                html_txt(buf);