]> git.cameronkatri.com Git - cgit.git/commitdiff
Return 404 on command not found
authorDan McGee <dpmcgee@gmail.com>
Wed, 12 Jan 2011 18:06:08 +0000 (12:06 -0600)
committerLars Hjemli <hjemli@gmail.com>
Sat, 19 Feb 2011 14:00:18 +0000 (15:00 +0100)
We were returning 200 before. Even 404 is questionable in all cases, but
200 was totally wrong. Also match the case of all of the "Not found"
status messsages.

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
cgit.c

diff --git a/cgit.c b/cgit.c
index 65fad7a2ff1532663f44e325d20af1cf52dc9cdb..e0c2d9fb45e252d107853d03317c99c4b08d83ae 100644 (file)
--- a/cgit.c
+++ b/cgit.c
@@ -429,7 +429,7 @@ static int prepare_repo_cmd(struct cgit_context *ctx)
                tmp = xstrdup(ctx->qry.head);
                ctx->qry.head = ctx->repo->defbranch;
                ctx->page.status = 404;
-               ctx->page.statusmsg = "not found";
+               ctx->page.statusmsg = "Not found";
                cgit_print_http_headers(ctx);
                cgit_print_docstart(ctx);
                cgit_print_pageheader(ctx);
@@ -448,6 +448,8 @@ static void process_request(void *cbdata)
        cmd = cgit_get_cmd(ctx);
        if (!cmd) {
                ctx->page.title = "cgit error";
+               ctx->page.status = 404;
+               ctx->page.statusmsg = "Not found";
                cgit_print_http_headers(ctx);
                cgit_print_docstart(ctx);
                cgit_print_pageheader(ctx);