If the last data row of a tbl(7) contains nothing but a horizontal line,

do not skip closing the table and cleaning up memory at the end of the
table in the HTML output module.

This bug resulted in skipping the tblcalc() function and reusing
the existing roffcol array for the next tbl(7) processed.  If the
next table had more columns than the one ending with a horizontal
line in the last data row, uninitialized memory was read, potentially
resulting in near-infinite output.

The bug was introduced in rev. 1.29 (2018/11/26) but only fully exposed
by rev. 1.38 (2021/09/09).  Until rev. 1.37, it could only cause
misformatting and invalid HTML output syntax but not huge output
because up to that point, the function did not use the roffcol array.

Nasty bug found the hard way by Michael Stapelberg on the production
server manpages.debian.org.  Michael also supplied example files
and excellent instructions how to reproduce the bug, which was very
difficult because no real-world manual page is known that triggers
the bug by itself, so to reproduce the bug, mandoc(1) had to be
invoked with at least two file name arguments.

diff --git a/tbl_html.c b/tbl_html.c
index 7fd1c42ddb1fcb9c16f00292f51a32cbe0c2e1a3..57d90c4c2d6786723363effcb1cc5c1842598058 100644 (file)
--- a/tbl_html.c
+++ b/tbl_html.c
@@ -1,6 +1,7 @@
-/* $Id: tbl_html.c,v 1.40 2022/04/14 16:43:44 schwarze Exp $ */
+/* $Id: tbl_html.c,v 1.41 2022/04/23 14:02:17 schwarze Exp $ */
 /*
- * Copyright (c) 2014,2015,2017,2018,2021 Ingo Schwarze <schwarze@openbsd.org>
+ * Copyright (c) 2014, 2015, 2017, 2018, 2021, 2022
+ *               Ingo Schwarze <schwarze@openbsd.org>
  * Copyright (c) 2011 Kristaps Dzonsons <kristaps@bsd.lv>
  *
  * Permission to use, copy, modify, and distribute this software for any
@@ -137,7 +138,7 @@ print_tbl(struct html *h, const struct tbl_span *sp)
         */
 
        if (sp->pos != TBL_SPAN_DATA)
-               return;
+               goto out;
 
        /* Inhibit printing of spaces: we do padding ourselves. */
 
@@ -289,6 +290,7 @@ print_tbl(struct html *h, const struct tbl_span *sp)
 
        h->flags &= ~HTML_NONOSPACE;
 
+out:
        if (sp->next == NULL) {
                assert(h->tbl.cols);
                free(h->tbl.cols);