diff options
| author |   Ingo Schwarze <schwarze@openbsd.org> | 2022-05-19 16:09:26 +0000 |
|---|---|---|
| committer | Ingo Schwarze <schwarze@openbsd.org> | 2022-05-19 16:09:26 +0000 |
| commit | ea1d65e49518d8b908c7c1678f7c9225b4920955 (patch) | |
| tree | b967e12e2ebf679953e1469b968cd7b5d19db1ba | |
| parent | 96bcb711a9cb11f5ee66d7aaf78561c905bfad65 (diff) | |
| download | mandoc-ea1d65e49518d8b908c7c1678f7c9225b4920955.tar.gz mandoc-ea1d65e49518d8b908c7c1678f7c9225b4920955.tar.zst mandoc-ea1d65e49518d8b908c7c1678f7c9225b4920955.zip | |
Adjust a column number in an error message
after the roff_expand() reorganization in roff.c rev. 1.388.
The new parsing direction has two effects:
1. Correct output when a line contains more than one expanding
escape sequence that has a side effect.
2. Column numbers in diagnostic messages now report the changed
column numbers after any expansions left of them have taken place;
in the past, column numbers refered to the original input line.
Arguably, item 2 was a bit better in its old state, but slightly
less helpful diagnostics are a small price to pay for correct
output. Besides, when the expansion of user-defined strings or
macros is involved, in many cases, mandoc(1) is already unable to
report meaningful line and column numbers, so item 2 is not a
noteworthy regression. The effort and code complication for fixing
that would probably be excessive, in particular since well-written
manual pages are not supposed to use such features in the first place.
| -rw-r--r-- | regress/roff/return/basic.out_lint | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/regress/roff/return/basic.out_lint b/regress/roff/return/basic.out_lint index f4b15bac..51e1c790 100644 --- a/regress/roff/return/basic.out_lint +++ b/regress/roff/return/basic.out_lint @@ -1,3 +1,3 @@ mandoc: basic.in:10:2: ERROR: ignoring request outside macro: return -mandoc: basic.in:18:32: ERROR: using macro argument outside macro: \$1 +mandoc: basic.in:18:28: ERROR: using macro argument outside macro: \$1 mandoc: basic.in:21:2: ERROR: ignoring request outside macro: return |