summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBaptiste Daroussin <bapt@FreeBSD.org>2015-05-10 10:15:36 +0000
committerBaptiste Daroussin <bapt@FreeBSD.org>2015-05-10 10:15:36 +0000
commit97f18faf798474452fd15880e7e8c81d786465e7 (patch)
tree7deeaf31b0496fa849298c3819ecf26bc6163069
parent23c65c2198c1b58184f7fafd8a70e8274fe1e91a (diff)
downloadpw-darwin-97f18faf798474452fd15880e7e8c81d786465e7.tar.gz
pw-darwin-97f18faf798474452fd15880e7e8c81d786465e7.zip
The initial logic for allocating the new string was wrong, the conversion
to strndup(3) duplicated the same mistake, actually strdup(3) is good enough to allocate the new string.
-rw-r--r--pw/pw_conf.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/pw/pw_conf.c b/pw/pw_conf.c
index 46474a1..e988f4b 100644
--- a/pw/pw_conf.c
+++ b/pw/pw_conf.c
@@ -213,15 +213,12 @@ char *
newstr(char const * p)
{
char *q;
- size_t l;
if ((p = unquote(p)) == NULL)
return (NULL);
- l = strlen(p) + 1;
-
- if ((q = strndup(p, l)) == NULL)
- err(1, "strndup()");
+ if ((q = strdup(p)) == NULL)
+ err(1, "strdup()");
return (q);
}