Remove useless calls to basename().

There are a couple of places in the source three where we call
basename() on constant strings. This is bad, because the prototype
standardized by POSIX allows the implementation to use its argument as a
storage buffer.

This change eliminates some of these unportable calls to basename() in
cases where it was only added for cosmetical reasons, namely to trim
argv[0]. There's nothing wrong with setting argv[0] to the full path.

Reviewed by:	jilles
Differential Revision:	https://reviews.freebsd.org/D6093

diff --git a/libutil/pw_util.c b/libutil/pw_util.c
index af749d5240de5e1dc26109294b8fbf6a761bd41a..2838871d93f6679307814271a79077e2a715c345 100644 (file)
--- a/libutil/pw_util.c
+++ b/libutil/pw_util.c
@@ -58,7 +58,6 @@ static const char rcsid[] =
 #include <err.h>
 #include <fcntl.h>
 #include <inttypes.h>
-#include <libgen.h>
 #include <paths.h>
 #include <pwd.h>
 #include <signal.h>
@@ -315,7 +314,7 @@ pw_edit(int notsetuid)
                        (void)setuid(getuid());
                }
                errno = 0;
-               execlp(editor, basename(editor), tempname, (char *)NULL);
+               execlp(editor, editor, tempname, (char *)NULL);
                _exit(errno);
        default:
                /* parent */