Flag empty UID entries as errors (to stop typos from turning into

alternate root accounts).

diff --git a/libc/gen/pw_scan.c b/libc/gen/pw_scan.c
index 5190686e5e78c180622ddb08026cecaaae382914..0ce9b1d6b19ae8e6e183b53391393cfd65baafe3 100644 (file)
--- a/libc/gen/pw_scan.c
+++ b/libc/gen/pw_scan.c
@@ -78,7 +78,12 @@ pw_scan(bp, pw)
 
        if (!(p = strsep(&bp, ":")))                    /* uid */
                goto fmt;
-       if(p[0]) pw->pw_fields |= _PWF_UID;
+       if (p[0])
+               pw->pw_fields |= _PWF_UID;
+       else {
+               warnx("no uid for user %s", pw->pw_name);
+               return (0);
+       }
        id = atol(p);
        if (root && id) {
                warnx("root uid should be 0");