summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBaptiste Daroussin <bapt@FreeBSD.org>2014-10-28 16:27:29 +0000
committerBaptiste Daroussin <bapt@FreeBSD.org>2014-10-28 16:27:29 +0000
commita887b64ca6b39abb49804cdfcf24bff5d476f9cd (patch)
tree7e425dbfff2518e9c8bbf12394ff6fcb222b0424
parent3dbd5cfb7b9eec912c68ae204ea36bec869b48cd (diff)
downloadpw-darwin-a887b64ca6b39abb49804cdfcf24bff5d476f9cd.tar.gz
pw-darwin-a887b64ca6b39abb49804cdfcf24bff5d476f9cd.tar.zst
pw-darwin-a887b64ca6b39abb49804cdfcf24bff5d476f9cd.zip
Fix renaming a group via the gr_copy function
Add a regression test to pw(8) because the bug was discovered via using: pw groupmod PR: 187189 Reported by: mcdouga9@egr.msu.edu Tested by: mcdouga9@egr.msu.edu Patch by: Marc de la Gueronniere
-rwxr-xr-xpw/tests/pw_modify.sh14
1 files changed, 14 insertions, 0 deletions
diff --git a/pw/tests/pw_modify.sh b/pw/tests/pw_modify.sh
index 5888111..b81f105 100755
--- a/pw/tests/pw_modify.sh
+++ b/pw/tests/pw_modify.sh
@@ -58,9 +58,23 @@ usermod_bug_185666_body() {
atf_check -o inline:"testgroup2:*:1003:testuser\n" -x pw -V ${HOME} groupshow testgroup2
}
+atf_test_case do_not_duplicate_group_on_gid_change
+do_not_duplicate_group_on_gid_change_head() {
+ atf_set "descr" "Do not duplicate group on gid change"
+}
+
+do_not_duplicate_group_on_gid_change_body() {
+ populate_etc_skel
+ atf_check -s exit:0 -x pw -V ${HOME} groupadd testgroup
+ atf_check -s exit:0 -x pw -V ${HOME} groupmod testgroup -g 12345
+ # use grep to see if the entry has not be duplicated
+ atf_check -o inline:"testgroup:*:12345:\n" -s exit:0 -x grep "^testgroup" ${HOME}/group
+}
+
atf_init_test_cases() {
atf_add_test_case groupmod_user
atf_add_test_case groupmod_invalid_user
atf_add_test_case groupmod_bug_193704
atf_add_test_case usermod_bug_185666
+ atf_add_test_case do_not_duplicate_group_on_gid_change
}