diff options
| author |   jnemeth <jnemeth@NetBSD.org> | 2006-03-29 01:19:51 +0000 |
|---|---|---|
| committer | jnemeth <jnemeth@NetBSD.org> | 2006-03-29 01:19:51 +0000 |
| commit | f01282b66ee470388fbdfd0bfd5631060888d063 (patch) | |
| tree | cbe3eb280e260aa2f11ae0ac38fc2e7e3f6b7d1f /hack | |
| parent | e0360616809f0f00834009161e54df0d39ef831c (diff) | |
| download | bsdgames-darwin-f01282b66ee470388fbdfd0bfd5631060888d063.tar.gz bsdgames-darwin-f01282b66ee470388fbdfd0bfd5631060888d063.tar.zst bsdgames-darwin-f01282b66ee470388fbdfd0bfd5631060888d063.zip | |
Fix Coverity issues 2366 and 2365 -- REVERSE_INULL.
Approved by Christos@.
Diffstat (limited to 'hack')
| -rw-r--r-- | hack/hack.invent.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/hack/hack.invent.c b/hack/hack.invent.c index c33d502b..6bc8a173 100644 --- a/hack/hack.invent.c +++ b/hack/hack.invent.c @@ -1,4 +1,4 @@ -/* $NetBSD: hack.invent.c,v 1.9 2004/01/27 20:30:29 jsm Exp $ */ +/* $NetBSD: hack.invent.c,v 1.10 2006/03/29 01:19:51 jnemeth Exp $ */ /* * Copyright (c) 1985, Stichting Centrum voor Wiskunde en Informatica, @@ -63,7 +63,7 @@ #include <sys/cdefs.h> #ifndef lint -__RCSID("$NetBSD: hack.invent.c,v 1.9 2004/01/27 20:30:29 jsm Exp $"); +__RCSID("$NetBSD: hack.invent.c,v 1.10 2006/03/29 01:19:51 jnemeth Exp $"); #endif /* not lint */ #include <stdlib.h> @@ -214,9 +214,12 @@ freeobj(obj) if (obj == fobj) fobj = fobj->nobj; else { - for (otmp = fobj; otmp->nobj != obj; otmp = otmp->nobj) - if (!otmp) + otmp = fobj; + while (otmp->nobj != obj) { + if (otmp->nobj == NULL) panic("error in freeobj"); + otmp = otmp->nobj; + } otmp->nobj = obj->nobj; } } @@ -231,9 +234,12 @@ freegold(gold) if (gold == fgold) fgold = gold->ngold; else { - for (gtmp = fgold; gtmp->ngold != gold; gtmp = gtmp->ngold) - if (!gtmp) + gtmp = fgold; + while (gtmp->ngold != gold) { + if (gtmp->ngold == NULL) panic("error in freegold"); + gtmp = gtmp->ngold; + } gtmp->ngold = gold->ngold; } free((char *) gold); |